From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alex Bochannek Newsgroups: gmane.emacs.bugs Subject: bug#43496: 28.0.50; [PATCH] Fix edge case in gnus-summary-catchup-from-here Date: Fri, 18 Sep 2020 14:35:31 -0700 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2343"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) To: 43496@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 18 23:36:29 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJO3P-0000OM-AW for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Sep 2020 23:36:27 +0200 Original-Received: from localhost ([::1]:46536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJO3O-0005J1-Cc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Sep 2020 17:36:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJO30-0005Ht-Tc for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 17:36:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33143) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJO30-0003da-Iw for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 17:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJO30-0007fv-G4 for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 17:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Bochannek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Sep 2020 21:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.160046494629477 (code B ref -1); Fri, 18 Sep 2020 21:36:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Sep 2020 21:35:46 +0000 Original-Received: from localhost ([127.0.0.1]:44689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJO2k-0007fN-Dj for submit@debbugs.gnu.org; Fri, 18 Sep 2020 17:35:46 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:40588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJO2j-0007fF-8w for submit@debbugs.gnu.org; Fri, 18 Sep 2020 17:35:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJO2i-000533-Vn for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 17:35:45 -0400 Original-Received: from 50-0-39-243.dsl.static.fusionbroadband.com ([50.0.39.243]:44428 helo=mail.lapseofthought.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJO2h-0003R2-1C for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 17:35:44 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.lapseofthought.com (Postfix) with ESMTP id 4BtRvm3s34z3jhxj for ; Fri, 18 Sep 2020 14:35:32 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at lapseofthought.com Original-Received: from mail.lapseofthought.com ([127.0.0.1]) by localhost (mail.lapseofthought.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MTaz3ZF8kY1k for ; Fri, 18 Sep 2020 14:35:31 -0700 (PDT) Original-Received: from awb-mbp.local (unknown [IPv6:2601:646:4200:b470:d2d:93ad:8c01:3409]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4BtRvl57Jsz3jhhc for ; Fri, 18 Sep 2020 14:35:31 -0700 (PDT) Received-SPF: softfail client-ip=50.0.39.243; envelope-from=alex@bochannek.com; helo=mail.lapseofthought.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 17:35:33 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: 2 X-Spam_score: 0.2 X-Spam_bar: / X-Spam_report: (0.2 / 5.0 requ) BAYES_00=-1.9, FORGED_SPF_HELO=1, KHOP_HELO_FCRDNS=0.4, SPF_HELO_PASS=-0.001, SPF_SOFTFAIL=0.665, TVD_RCVD_IP=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188354 Archived-At: --=-=-= Content-Type: text/plain The gnus-summary-catchup-from-here function also marks the current article, which it fails to do if that article is the last one in the summary buffer. --=-=-= Content-Type: text/x-patch; name=gnus-sum.el.diff Content-Disposition: inline Content-Description: Fix edge case in gnus-summary-catchup-from-here diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index 2f0ea0c58f..8e27a94e5b 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -11537,7 +11537,7 @@ gnus-summary-catchup-from-here (gnus-save-hidden-threads (let ((beg (point))) ;; We check that there are unread articles. - (when (or all (gnus-summary-find-next)) + (when (or all (gnus-summary-last-article-p) (gnus-summary-find-next)) (gnus-summary-catchup all t beg nil t))))) (gnus-summary-position-point)) --=-=-= Content-Type: text/plain -- Alex. --=-=-=--