all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alex Bochannek <alex@bochannek.com>
To: 43496@debbugs.gnu.org
Subject: bug#43496: 28.0.50; [PATCH] Fix edge case in gnus-summary-catchup-from-here
Date: Fri, 18 Sep 2020 14:35:31 -0700	[thread overview]
Message-ID: <m2imcan4yk.fsf@bochannek.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

The gnus-summary-catchup-from-here function also marks the current
article, which it fails to do if that article is the last one in the
summary buffer.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Fix edge case in gnus-summary-catchup-from-here --]
[-- Type: text/x-patch; name=gnus-sum.el.diff, Size: 506 bytes --]

diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el
index 2f0ea0c58f..8e27a94e5b 100644
--- a/lisp/gnus/gnus-sum.el
+++ b/lisp/gnus/gnus-sum.el
@@ -11537,7 +11537,7 @@ gnus-summary-catchup-from-here
     (gnus-save-hidden-threads
       (let ((beg (point)))
 	;; We check that there are unread articles.
-	(when (or all (gnus-summary-find-next))
+	(when (or all (gnus-summary-last-article-p) (gnus-summary-find-next))
 	  (gnus-summary-catchup all t beg nil t)))))
   (gnus-summary-position-point))

[-- Attachment #3: Type: text/plain, Size: 10 bytes --]

-- 
Alex.

             reply	other threads:[~2020-09-18 21:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18 21:35 Alex Bochannek [this message]
2020-09-19 14:49 ` bug#43496: 28.0.50; [PATCH] Fix edge case in gnus-summary-catchup-from-here Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2imcan4yk.fsf@bochannek.com \
    --to=alex@bochannek.com \
    --cc=43496@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.