From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS: Forwording symbols Date: Mon, 17 Jun 2024 21:19:26 +0200 Message-ID: References: <87jziod6yc.fsf@gmail.com> <874j9rcuf6.fsf@gmail.com> <87y173bda9.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38604"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Emacs Devel , Eli Zaretskii To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 17 21:20:14 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJHtl-0009uQ-3n for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Jun 2024 21:20:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJHt8-0001u4-0c; Mon, 17 Jun 2024 15:19:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJHt6-0001to-B9 for emacs-devel@gnu.org; Mon, 17 Jun 2024 15:19:32 -0400 Original-Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJHt4-0000Y9-On; Mon, 17 Jun 2024 15:19:32 -0400 Original-Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a6ef64b092cso575454666b.1; Mon, 17 Jun 2024 12:19:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718651968; x=1719256768; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UsbiiTt6VdcR96EB0XGbDjCLu2AFQtStMt0wKRd63mY=; b=LmOteA9uePBblfCkPxE1Z7zuksX48zHOUBMHBX47i+gVZGV0Lr1po+gEVqltWgjI/0 ImcKvq3LHEzaReER2g+z4T45diqNRI5I2Cjlv5KOIZgOCEZBCmpR45KBQDK7s7Fdhok9 Tr1SCkh+ALgVx02HZHkiBqjx/uNG2Mlmsl5Wu4mi4MOgSZ5DGk3YFqm1ag19pJNw6Q0I Zjww5WowQ/pKIcn4eouR8OZ0LMMuIaZ93fGfqsXbh+fCN8C1SCJ6QOR3LBY/+GtgcBmJ mPjGVfPMl9HKps674pA3x0+trCZj9a7hveDXm8rSN3vG5skVpiu+km95xKAfUHDnW16V +NlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718651968; x=1719256768; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UsbiiTt6VdcR96EB0XGbDjCLu2AFQtStMt0wKRd63mY=; b=rGcEPAt4qOayWTVzR7RibwNrA/8gFBdbfVfUp1IY9ixk1SMfIk4is8g7vOG9mCCv8D dVye0tw8OFGte+k9jGNSFhGFtcFxKo3uZLl3YHw5RYLWcFVsmo0IM2bxNTAWpQR8o++l 5EzxHsCVRamScjqI4eIkoxq5Uj9ZAlELEvyspP3OqdcUm7ai+HPVX0JYU9xs9TgGQA2c T7CbQcdNbfM05HmqHLD4yPJfrjHb8UOpzdeobI4mrSj1QznPZYaKpfJDlyCSVINMr9+/ w42cJevkf8IH0t41GEcp7eJuD68LBennMD5Oan0CMDOjoaZYTWYUI6TjGbo5qmXb013k l42Q== X-Forwarded-Encrypted: i=1; AJvYcCWRTgPzyi8/0rFsHfbSFldd3Jpdltg8UJEPTi/IdWqqHLEvZkMZROMN59bcRDVPfnUyhZfZ5Ke2LhsMrCg= X-Gm-Message-State: AOJu0YwZqEdcsT5US6AfyG/+DqoV8SgOXvJPP8lDwtre/LXe2RabsAu6 aVpmdnfPYfhoDGQCkOpYaQYGCFrYuvMjaiJgEwHW2zROnmCCQh1qHd6yGQ== X-Google-Smtp-Source: AGHT+IH23pwHn9UjETdJ1D/EWhZqfk/IquGHhUXN2Nj3Ti9ARayi7hN4Ne16OjPT0cBYLQF9oXxsNA== X-Received: by 2002:a17:906:b751:b0:a6f:2ee7:b21a with SMTP id a640c23a62f3a-a6f60de2580mr734840366b.65.1718651967998; Mon, 17 Jun 2024 12:19:27 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e36d9b.dip0.t-ipconnect.de. [217.227.109.155]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f56dd135esm544778666b.96.2024.06.17.12.19.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 12:19:27 -0700 (PDT) In-Reply-To: <87y173bda9.fsf@gmail.com> (Helmut Eller's message of "Mon, 17 Jun 2024 21:05:34 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::632; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320220 Archived-At: Helmut Eller writes: > On Mon, Jun 17 2024, Gerd M=C3=B6llmann wrote: > >> Looks like the client object passed in is bogus >> >> (lldb) p *h >> (igc_header) (obj_type =3D IGC_OBJ_INVALID, hash =3D 128931976, nword= s =3D 1) >> (lldb) > > Hm, is_mps used filter that out. Now pdumper_object_p must > called explicitly: > > if (is_mps (client) && !pdumper_object_p (client)) ... With char * igc_dump_finish_obj (void *client, enum igc_obj_type type, char *base, char *end) { if (client =3D=3D NULL) return end; struct igc_header *out =3D (struct igc_header *) base; if (is_mps (client) && !pdumper_object_p (client)) { struct igc_header *h =3D client_to_base (client); if (h->obj_type =3D=3D IGC_OBJ_VECTOR_WEAK) igc_assert ( (type =3D=3D IGC_OBJ_VECTOR && h->obj_type =3D=3D IGC_OBJ_VECTO= R_WEAK) || h->obj_type =3D=3D type); igc_assert (base + obj_size (h) >=3D end); I still get the same assertion because client is not pdumper_object_p. Could it be that we have to use pdumper_cold_object_p? I'll give it a try. Strangely, I can't call that function in LLDB... :-(