From: Martyn Jago <martyn.jago@btinternet.com>
To: emacs-devel@gnu.org
Subject: Re: Evil defvars in org.el
Date: Tue, 08 May 2012 23:48:26 +0100 [thread overview]
Message-ID: <m2havq5lxh.fsf@btinternet.com> (raw)
In-Reply-To: 87k411g8xa.fsf@gnu.org
Chong Yidong <cyd@gnu.org> writes:
> org.el (and org-agenda.el, and maybe others) have defvars like this:
>
> (defvar entry)
> (defvar date)
>
> This is going to blow up in someone's face, because it makes `entry' and
> `date' unusable as lexical variables, even though those are very common
> variable names. That is to say, loading Org mode would change the
> behavior of packages using lexical binding in some unpredictable way.
>
> Why does org need to do this? Could you try to clean it up?
Perhaps Emacs can prefix the `evil vars' and alias them to the original,
with a deprecation warning?
Best, Martyn
next prev parent reply other threads:[~2012-05-08 22:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 3:17 Evil defvars in org.el Chong Yidong
2012-04-27 6:07 ` Bastien
2012-04-27 14:48 ` Bastien
2012-04-27 14:57 ` Edward Reingold
2012-04-27 16:14 ` Bastien
2012-04-27 17:09 ` SAKURAI Masashi
2012-04-27 16:05 ` Glenn Morris
2012-04-27 16:33 ` Drew Adams
2012-04-28 0:15 ` Miles Bader
2012-04-28 0:17 ` Drew Adams
2012-04-28 0:48 ` Miles Bader
2012-04-28 2:25 ` Chong Yidong
2012-05-04 6:56 ` Glenn Morris
2012-05-04 15:29 ` Stefan Monnier
2012-05-04 20:53 ` Johan Bockgård
2012-05-05 0:37 ` Stefan Monnier
2012-05-05 20:00 ` Glenn Morris
2012-05-07 14:57 ` Stefan Monnier
2012-04-28 2:14 ` Stefan Monnier
2012-04-28 5:57 ` Achim Gratz
2012-04-28 15:10 ` Stefan Monnier
2012-04-28 16:31 ` Achim Gratz
2012-04-28 19:33 ` Stefan Monnier
2012-04-28 6:00 ` Drew Adams
2012-05-08 22:48 ` Martyn Jago [this message]
2012-05-09 17:37 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2havq5lxh.fsf@btinternet.com \
--to=martyn.jago@btinternet.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.