From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs Subject: bug#12796: Optimize `ido-completing-read' for larger lists with flex matching enabled Date: Thu, 08 Nov 2012 10:00:58 +0800 Message-ID: References: <5096040B.50002@yandex.ru> <50982835.2050106@yandex.ru> <5099DE35.2060402@yandex.ru> <509AD8AB.90703@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1352340187 4555 80.91.229.3 (8 Nov 2012 02:03:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 8 Nov 2012 02:03:07 +0000 (UTC) Cc: 12796@debbugs.gnu.org, Kim Storm To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 08 03:03:16 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TWHSe-0003lz-Ap for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Nov 2012 03:03:16 +0100 Original-Received: from localhost ([::1]:50039 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TWHSV-0007wO-6g for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Nov 2012 21:03:07 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:46952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TWHST-0007wE-0D for bug-gnu-emacs@gnu.org; Wed, 07 Nov 2012 21:03:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TWHSR-0006ld-Iu for bug-gnu-emacs@gnu.org; Wed, 07 Nov 2012 21:03:04 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TWHSR-0006lK-Bs for bug-gnu-emacs@gnu.org; Wed, 07 Nov 2012 21:03:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TWHSP-0004PE-Se for bug-gnu-emacs@gnu.org; Wed, 07 Nov 2012 21:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Nov 2012 02:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12796 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12796-submit@debbugs.gnu.org id=B12796.135234016316907 (code B ref 12796); Thu, 08 Nov 2012 02:03:01 +0000 Original-Received: (at 12796) by debbugs.gnu.org; 8 Nov 2012 02:02:43 +0000 Original-Received: from localhost ([127.0.0.1]:55055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TWHS6-0004Od-CL for submit@debbugs.gnu.org; Wed, 07 Nov 2012 21:02:42 -0500 Original-Received: from mail-pb0-f44.google.com ([209.85.160.44]:55185) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TWHS4-0004OW-Mm for 12796@debbugs.gnu.org; Wed, 07 Nov 2012 21:02:41 -0500 Original-Received: by mail-pb0-f44.google.com with SMTP id ro8so1635494pbb.3 for <12796@debbugs.gnu.org>; Wed, 07 Nov 2012 18:02:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=fC8Q+zbu12kiC1qEVjMbpi68LAn/UZSIJJ2uzPu+ho8=; b=JBLoI0vbhHsUvWotFhLPf4usqx3+g4HxtHNZmaeslq0vWq80bYBD0pWEETp+60PnxQ y1NqdEQeILQA+AIfUYRw2aW1TET7qCNycSh7V1xKfqP4JbZwpRj+lJxN7lLFDIHU5Dbm 6SIn+4tmJ/h5tM5i/MCV8BRstwRrKxFeHSU0vhXYPeIxNivplfaEeDiNNbBD3ibiwCue 9V6dAwZymo3TbiCR6Bwej66ZTLjs2mRe+f3PloMXBob6aeKfbEbdEA+GcY9Aon3h9QcG /Umrbswzzd4AIJlxBuosFH9BxekMvE+PDjS9Md53l24DmJyLo3Vh0GRq0AybLUvC7D+6 a3+g== Original-Received: by 10.68.115.75 with SMTP id jm11mr4630143pbb.28.1352340160946; Wed, 07 Nov 2012 18:02:40 -0800 (PST) Original-Received: from localhost ([119.255.41.67]) by mx.google.com with ESMTPS id x8sm15202762paw.16.2012.11.07.18.02.37 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 07 Nov 2012 18:02:39 -0800 (PST) In-Reply-To: <509AD8AB.90703@yandex.ru> (Dmitry Gutov's message of "Thu, 08 Nov 2012 01:54:51 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (OS X 10.8.2) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:66607 Archived-At: On 2012-11-08 05:54 +0800, Dmitry Gutov wrote: > It looks like, with either patch, flex matching is not the bottleneck > anymore. Excellent. The other patch is definitely simpler. So I prefer it. Stefan, for concluding this bug, I think we should make this change. >From this bit in ido-set-matches-1: (if ido-enable-prefix (setq re (concat "\\`" re))) It seems not including the leading and trailing .* is intended. So do you mind installing the following small change for 24.3 that greatly improves ido performance: diff --git a/lisp/ido.el b/lisp/ido.el index 31d5279d..c8bc0bb7 100644 --- a/lisp/ido.el +++ b/lisp/ido.el @@ -3783,7 +3783,7 @@ (defun ido-set-matches-1 (items &optional do-full) ido-enable-flex-matching (> (length ido-text) 1) (not ido-enable-regexp)) - (setq re (mapconcat #'regexp-quote (split-string ido-text "") ".*")) + (setq re (mapconcat #'regexp-quote (split-string ido-text "" t) ".*")) (if ido-enable-prefix (setq re (concat "\\`" re))) (mapc Leo