From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Helmut Eller Newsgroups: gmane.emacs.devel Subject: Re: Generalizing find-definition Date: Thu, 04 Dec 2014 10:11:36 +0100 Message-ID: References: <20141102151524.0d9c665c@forcix> <20141117211039.37f03409@forcix> <877fymghgb.fsf@bredband.net> <85ppc0qf9a.fsf@stephe-leake.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1417684341 1895 80.91.229.3 (4 Dec 2014 09:12:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 4 Dec 2014 09:12:21 +0000 (UTC) Cc: Stephen Leake To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 04 10:12:14 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XwSSL-00015d-OW for ged-emacs-devel@m.gmane.org; Thu, 04 Dec 2014 10:12:13 +0100 Original-Received: from localhost ([::1]:45009 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwSSL-00077F-AF for ged-emacs-devel@m.gmane.org; Thu, 04 Dec 2014 04:12:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwSSB-00076S-KO for emacs-devel@gnu.org; Thu, 04 Dec 2014 04:12:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwSS3-00022x-Bw for emacs-devel@gnu.org; Thu, 04 Dec 2014 04:12:03 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:53834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwSS3-00022W-48 for emacs-devel@gnu.org; Thu, 04 Dec 2014 04:11:55 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XwSRx-0000tl-Tj for emacs-devel@gnu.org; Thu, 04 Dec 2014 10:11:49 +0100 Original-Received: from 212.46.172.140 ([212.46.172.140]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 04 Dec 2014 10:11:49 +0100 Original-Received: from eller.helmut by 212.46.172.140 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 04 Dec 2014 10:11:49 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 39 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 212.46.172.140 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) Cancel-Lock: sha1:q9SmDLHNGg+v+d/6d/uj6xnuBhU= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:178808 Archived-At: On Wed, Dec 03 2014, Stephen Leake wrote: [...] > A couple comments: > > The current copyright on xref.el is Helmut Eller; I assume you've got a > copyright assignment on file. Yes, I have the paperwork. > I'd like to add to xref.el: > > (defun xref-find-definition-at-point () > (interactive) > (xref--find-definition (xref-identifier-at-point (xref--backend)) nil)) > > That's the function I use most often. Hmm, xref-find-definition does this, except for the case when it's not called interactively. Do you need the non-interactive version? Maybe it would be better to make xref-find-definition more useful non-interactively than to define an almost identical function. > There is a FIXME on xref-push-marker-stack. I gather you'd like this to > be independent of etags? > > It would not be hard to implement an independent marker ring/stack. But > I think it makes more sense to use the etags marker ring; that way, > if I am navigating thru code that uses multiple languages, and one > language mode uses xref while another uses tags, there is still only one > tag ring. > > Eventually, when most modes have migrated to xref, it might make sense > to switch to a separate marker ring. My idea was to move the ring from etags.el to xref.el and perhaps define some aliases for backward compatibility. Helmut