From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Tue, 02 Apr 2019 19:50:59 +0200 Message-ID: References: <20190318114249.ouqxfghhw5dfr5ry@Ergus> <83y35cumzs.fsf@gnu.org> <20190402124236.cpb63pdopfk6vpj5@Ergus> <87k1gczhi8.fsf@telefonica.net> <20190402133718.z464xomdq6l3pfrl@Ergus> <83pnq4fnte.fsf@gnu.org> <20190402153504.jfliuexzn4ntqnn4@Ergus> <83k1gcfm3y.fsf@gnu.org> <20190402163623.2gvlraa5qitzgi6y@Ergus> <20190402172619.6jfwwqn4cpomoa2b@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="13882"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 02 19:52:03 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBNZn-0003Qp-Vx for ged-emacs-devel@m.gmane.org; Tue, 02 Apr 2019 19:52:00 +0200 Original-Received: from localhost ([127.0.0.1]:46361 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBNZm-0000Mh-Pd for ged-emacs-devel@m.gmane.org; Tue, 02 Apr 2019 13:51:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57477) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBNYu-0000HO-GR for emacs-devel@gnu.org; Tue, 02 Apr 2019 13:51:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBNYt-0007aN-Hq for emacs-devel@gnu.org; Tue, 02 Apr 2019 13:51:04 -0400 Original-Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:35933) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBNYt-0007Xw-8d for emacs-devel@gnu.org; Tue, 02 Apr 2019 13:51:03 -0400 Original-Received: by mail-wm1-x331.google.com with SMTP id h18so4882328wml.1 for ; Tue, 02 Apr 2019 10:51:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=DTGzB3yOUEtqCRg9CDPx9D6ZgIwtPVFhe/FRBaUaoHQ=; b=TVzU+DpN4XF1hzRtRfWHX/YXIABb61bs6vFHY5cOLmcVqTPg4kAeFsdA9sPGNij4+J SuMxJaUbWcnGpwOXfhX5wYC4EbAPKYbuOk6G4o2YGICrGlEw5uLLX7/ff+35BChhd+IA /r/2WfqbFp+J4bI7sSKiG6Qij1u/geciPdyZZl+n4GgXqnryxqcAfxc4vpVTv9sCts2Y Yrk8DV/v+wV7LQj4Oh7tpobByRekw2FgCx1+WyvHMR5Eysloozk75Izn2WAZD07Ajs2P daikfe6Bbh3gULhzDyPWn4bXBUH6KNU3tQcDsKE7uVo29q7hjaBn82iQzPqrmR7yDIvW nAmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=DTGzB3yOUEtqCRg9CDPx9D6ZgIwtPVFhe/FRBaUaoHQ=; b=uLN58smM4aEf4VgtBfrhCaVAz9C7rQIGqwueyyD1V+S+grg47GnbZm2b3G3vUfZnEy b4gHOXdtnCypCYLOsiJCxbLgOlYZoCaZDUrjDsa9aVcBI9i/G/z6+0X9ZzE1GubwohuM Lr1il6LL9gZk9MACWOMnld2y/W1DqCdqdTcqCIVypKpkwAOTeffdQ40G/XLdDZLjW05j ZV3H7vUtCZjyhyxSMdEqF8Qg6Fx/EDNPjala2JoLt9PpXUayST9qh0ZyeYczJm2p1J0n McfaTljar1LoPD9jy15bVVdSx4S10MEZeBxAiOh1CrLequZveWyQMTxZyljW0LfWviNm vizg== X-Gm-Message-State: APjAAAWGsEDi8EnJ708+7HgfCbvugyJ8E2JxGyOXMTZNlnzPgq5jmZMo y/6blgKymaV2MCvds3yDy6ZCVhtQ X-Google-Smtp-Source: APXvYqxVASSVSPHdqHXIMPk6IvCfzCgZqiahrLg8dqStKySgaviKn3yRa84IUNgwNowtC+h1mb8I8A== X-Received: by 2002:a1c:c186:: with SMTP id r128mr4451409wmf.100.1554227461323; Tue, 02 Apr 2019 10:51:01 -0700 (PDT) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:f514:32e2:4dcd:993e]) by smtp.gmail.com with ESMTPSA id x192sm16481457wmf.48.2019.04.02.10.51.00 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 02 Apr 2019 10:51:00 -0700 (PDT) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <20190402172619.6jfwwqn4cpomoa2b@Ergus> (Ergus's message of "Tue, 2 Apr 2019 19:26:20 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::331 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234886 Archived-At: >>>>> On Tue, 2 Apr 2019 19:26:20 +0200, Ergus said: Ergus> On Tue, Apr 02, 2019 at 07:01:45PM +0200, Robert Pluim wrote: >>>>>>> On Tue, 2 Apr 2019 18:36:23 +0200, Ergus >>>>>>> said: >>=20 Ergus> I just pushed a new branch with the fill-column-indicator Ergus> feature. I would prefer to rebase before pushing to the Ergus> master branch. (In my ideal world I will rebase and then do Ergus> a merge with -no-ff. But this is not the workflow you have Ergus> here) >>=20 >> I took a quick look. It=CA=BCs three commits, including the NEWS >> changes. Any reason you don=CA=BCt want to squash those into a >> single commit? >>=20 Ergus> No, I do the squash when I rebase before merging to master Ergus> and I do all the changes and fixes recommended on top of Ergus> this branch. That=CA=BCs what I meant. One other point: none of your commits have ChangeLog style entries, see "** Commit messages" in CONTRIBUTE for a long description of the format (and learn to love "C-x 4 a") Ergus> I just keep it like this now because recommendations will Ergus> arrive and I don't want to overwrite public history Ergus> constantly if many changes are suggested before the Ergus> approval. This is like a develop branch for the feature, so Ergus> I'll put things "pretty" in the last moment. and in the Ergus> mean time I will just add commits on top of it. Sure. Ergus> So, how is decided when to move this to the master branch? Ergus> (the equivalent to accept the pull request) =20=20=20=20 When Eli says it=CA=BCs ready, which requires some people to try it out and give feedback. >>=20 Ergus> There are changes in the NEWS already but not in the Ergus> manual. So, just tell me the following steps. >>=20 >> The NEWS changes have some minor issues (spelling, two spaces >> after full stop, spurious whitespace), but the new user >> variables and modes need descriptions in the user manual. >>=20 >> Robert >>=20 Ergus> So you mean that the variables descriptions shouldn't be in Ergus> NEWS? What you've put in NEWS now is pretty comprehensive, perhaps too much so. I=CA=BCd cut down what's in NEWS and move the extensive description to the manual, probably (info "(emacs)Fill Commands") Robert