From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master ed2b0bd: New faces in xref (bug#23179) Date: Tue, 16 Apr 2019 17:20:02 +0200 Message-ID: References: <20190413215421.15465.98417@vcs0.savannah.gnu.org> <20190413215422.72DC12044D@vcs0.savannah.gnu.org> <87o958wdwt.fsf@mail.linkov.net> <83lg0bibh6.fsf@gnu.org> <83ef62gf9f.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="109909"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 16 17:20:21 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGPsh-000SMc-6v for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 17:20:19 +0200 Original-Received: from localhost ([127.0.0.1]:38309 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGPsg-0004xV-1O for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 11:20:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37609) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGPsV-0004uZ-2N for emacs-devel@gnu.org; Tue, 16 Apr 2019 11:20:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGPsU-00021s-2l for emacs-devel@gnu.org; Tue, 16 Apr 2019 11:20:07 -0400 Original-Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:52037) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hGPsT-00020O-RB; Tue, 16 Apr 2019 11:20:06 -0400 Original-Received: by mail-wm1-x336.google.com with SMTP id 4so25899271wmf.1; Tue, 16 Apr 2019 08:20:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=XsvaGRrgdi1fTx10REJYYOQUwIpXfTVGQX5ivQZV2rI=; b=UuGVbl8WlbLJlkyOViGdfb8wrP6aR7ZsX+VsSeDAeddbKnrkKxeNSSJwPXuxosvUib h85/PaQEdNTQ08PQOl09f/Y/pYY7c7ISg7tMcj3jvjbfD3DsGamGKQJeHgmf3kjm+/Hj IyU5lzIS9VJADjKJhGZTghX4Cyzm5b/PFPTsUQTtfhsTs8t90HypJ/HrR5o1WZ0i5tyU 3JDF/s9LVPJccsjA7245wFOJcnKsO2BHniHUC2yDx2E2TuizX5I0hTars4Y+e54H339J 6X3mrqDOcH1BNBIL2muTNjXcBnSQTuk5ZQ2DxjvKqS/oQsqgzPrItr25Sh3LTIL8n/i0 OrRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version; bh=XsvaGRrgdi1fTx10REJYYOQUwIpXfTVGQX5ivQZV2rI=; b=bIhzCL/NmqsqKcRZqC7RbsnxkU09YqvsO4eK5M+GUDnfk1d2dVYx9uE0e9m0GEk2AW ciB3RddKdp8bCqCSLWHEjKEMgilv+dwEQkNm5Ma5VDU0gSo1c6S0Yjzj1yyaAmlRSVnU hEuM0AC0rAA+w0Ox2BKR8a9+LZZ2iAQ/LTgZAjI41dTmPF0EVzJq2iz/4ScW6qWhK4Sz QL9PnbeL0Mr6b+UOB/RsaFSbRVy2TfiN0v4U7ogyYcEXvPNGViexgdz7WqGMkZBmUfF5 /o0Hu7uuWJQNcQMWZqqziFLtG75DTv6bYhjaj1lsX84pjWCrb/DN7JDkOjZDamqqef2N 7/dQ== X-Gm-Message-State: APjAAAUdqREm7FdjshGQ61HIJGrN9iUBuXtEoP9HpItlzJ7TAQsUD5OM Ehc0Ul0B2kSQVFkziCK8UX9+uq3l X-Google-Smtp-Source: APXvYqxY13D3ltofnATx3Z2IK/5xmXs5s+S3LBOVIRXpdCb7Iddc6yTlH+/nGvg3YOZlAaUXk1DZDA== X-Received: by 2002:a05:600c:219:: with SMTP id 25mr28404943wmi.7.1555428004215; Tue, 16 Apr 2019 08:20:04 -0700 (PDT) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id z7sm53956349wrt.10.2019.04.16.08.20.02 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 16 Apr 2019 08:20:03 -0700 (PDT) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <83ef62gf9f.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 16 Apr 2019 18:07:40 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::336 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235522 Archived-At: >>>>> On Tue, 16 Apr 2019 18:07:40 +0300, Eli Zaretskii said: >> From: Robert Pluim Cc: emacs-devel@gnu.org >> Date: Tue, 16 Apr 2019 16:02:36 +0200 >> >> +@cindex compilation mode faces +@cindex compilation mode >> appearance +@vindex compilation-error-face +@vindex >> compilation-error +@vindex compilation-warning-face +@vindex >> compilation-warning Eli> It is generally not useful to have several index entries Eli> which start with the same text and point to the same place. Eli> So I would leave the odd-numbered entries above and delete Eli> the even-numbered. I did it slightly differently. The name of the face is 'compilation-error', and 'compilation-error-face' holds the name of the face to use. customize-face uses the former, so I left that one. >> + The appearance of the @file{*compilation*} buffer can be >> controlled +by customizing the faces which are used to >> highlight parts of the +@file{*compilation*} buffer, >> e.g. @code{compilation-error} or Eli> Either "e.g.,", or "e.g.@:", so that TeX doesn't by chance Eli> consider this end of sentence. The former seems vastly preferred, so I went with it. Eli> Otherwise LGTM, thanks. emacs-26, I imagine. diff --git a/doc/emacs/building.texi b/doc/emacs/building.texi index 78d07b8d39..518d157e4e 100644 --- a/doc/emacs/building.texi +++ b/doc/emacs/building.texi @@ -151,6 +151,20 @@ Compilation Mode the error message in a separate window. The locus is the specific position in a file where that error occurred. +@cindex compilation mode faces +@vindex compilation-error +@vindex compilation-warning + The appearance of the @file{*compilation*} buffer can be controlled +by customizing the faces which are used to highlight parts of the +@file{*compilation*} buffer, e.g., @code{compilation-error} or +@code{compilation-warning}, for error and warning messages +respectively. Note that since those faces inherit from the +@code{error} and @code{warning} faces, it is also possible to +customize the parent face directly instead. + + Use @w{@kbd{M-x customize-group RET compilation}} to see the entire +list of customization variables and faces. + @findex compile-goto-error @vindex compilation-auto-jump-to-first-error If you change the variable