From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master ed2b0bd: New faces in xref (bug#23179)
Date: Tue, 16 Apr 2019 17:20:02 +0200 [thread overview]
Message-ID: <m2h8ayf04d.fsf@gmail.com> (raw)
In-Reply-To: <83ef62gf9f.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 16 Apr 2019 18:07:40 +0300")
>>>>> On Tue, 16 Apr 2019 18:07:40 +0300, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com> Cc: emacs-devel@gnu.org
>> Date: Tue, 16 Apr 2019 16:02:36 +0200
>>
>> +@cindex compilation mode faces +@cindex compilation mode
>> appearance +@vindex compilation-error-face +@vindex
>> compilation-error +@vindex compilation-warning-face +@vindex
>> compilation-warning
Eli> It is generally not useful to have several index entries
Eli> which start with the same text and point to the same place.
Eli> So I would leave the odd-numbered entries above and delete
Eli> the even-numbered.
I did it slightly differently. The name of the face is
'compilation-error', and 'compilation-error-face' holds the name of
the face to use. customize-face uses the former, so I left that one.
>> + The appearance of the @file{*compilation*} buffer can be
>> controlled +by customizing the faces which are used to
>> highlight parts of the +@file{*compilation*} buffer,
>> e.g. @code{compilation-error} or
Eli> Either "e.g.,", or "e.g.@:", so that TeX doesn't by chance
Eli> consider this end of sentence.
The former seems vastly preferred, so I went with it.
Eli> Otherwise LGTM, thanks.
emacs-26, I imagine.
diff --git a/doc/emacs/building.texi b/doc/emacs/building.texi
index 78d07b8d39..518d157e4e 100644
--- a/doc/emacs/building.texi
+++ b/doc/emacs/building.texi
@@ -151,6 +151,20 @@ Compilation Mode
the error message in a separate window. The locus is the specific
position in a file where that error occurred.
+@cindex compilation mode faces
+@vindex compilation-error
+@vindex compilation-warning
+ The appearance of the @file{*compilation*} buffer can be controlled
+by customizing the faces which are used to highlight parts of the
+@file{*compilation*} buffer, e.g., @code{compilation-error} or
+@code{compilation-warning}, for error and warning messages
+respectively. Note that since those faces inherit from the
+@code{error} and @code{warning} faces, it is also possible to
+customize the parent face directly instead.
+
+ Use @w{@kbd{M-x customize-group RET compilation}} to see the entire
+list of customization variables and faces.
+
@findex compile-goto-error
@vindex compilation-auto-jump-to-first-error
If you change the variable
next prev parent reply other threads:[~2019-04-16 15:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190413215421.15465.98417@vcs0.savannah.gnu.org>
[not found] ` <20190413215422.72DC12044D@vcs0.savannah.gnu.org>
2019-04-14 10:39 ` master ed2b0bd: New faces in xref (bug#23179) Robert Pluim
2019-04-14 20:05 ` Juri Linkov
2019-04-15 8:27 ` Robert Pluim
2019-04-15 14:34 ` Eli Zaretskii
2019-04-16 14:02 ` Robert Pluim
2019-04-16 15:07 ` Eli Zaretskii
2019-04-16 15:20 ` Robert Pluim [this message]
2019-04-16 16:01 ` Eli Zaretskii
2019-04-16 16:12 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2h8ayf04d.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.