Re: master 8542f66 2/3: Automatically rotate images in image-mode based on Exif data

Re: master 8542f66 2/3: Automatically rotate images in image-mode based on Exif data

[Robert Pluim]

>>>>> On Sun, 22 Sep 2019 08:23:54 -0400 (EDT), larsi@gnus.org (Lars Ingebrigtsen) said:

    Lars> branch: master
    Lars> commit 8542f666023931f85817f590926cc3e9bc992b68
    Lars> Author: Lars Ingebrigtsen <larsi@gnus.org>
    Lars> Commit: Lars Ingebrigtsen <larsi@gnus.org>

    Lars>     Automatically rotate images in image-mode based on Exif data
    
    Lars>     * lisp/image-mode.el (image-toggle-display-image): Get the
    Lars>     orientation from the Exif data, if any.

So I attempted to visit a PNG file from emacs, and got a buffer
containing the image data, and the following in *Messages*

    Cannot display image: ((app1 (cdr (assq 65505 (exif--parse-jpeg)))))

Itʼs unclear to me whether emacs should be able to display PNG
natively here. (featurep 'png) is nil, but this is on macOS, which
allegedly has builtin support for PNG. In any case Iʼm not expecting
an error message about exif data.

Robert

Re: master 8542f66 2/3: Automatically rotate images in image-mode based on Exif data

[Lars Ingebrigtsen]

Robert Pluim <rpluim@gmail.com> writes:

> So I attempted to visit a PNG file from emacs, and got a buffer
> containing the image data, and the following in *Messages*
>
>     Cannot display image: ((app1 (cdr (assq 65505 (exif--parse-jpeg)))))
>
> Itʼs unclear to me whether emacs should be able to display PNG
> natively here. (featurep 'png) is nil, but this is on macOS, which
> allegedly has builtin support for PNG. In any case Iʼm not expecting
> an error message about exif data.

I'm unable to reproduce this error -- viewing png images works fine for
me.

Could you post a backtrace?  The easiest is probably to say

M-: (image-toggle-display-image)

in the .png buffer.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 8542f66 2/3: Automatically rotate images in image-mode based on Exif data

[Robert Pluim]

>>>>> On Wed, 30 Oct 2019 15:45:09 +0100, Lars Ingebrigtsen <larsi@gnus.org> said:

    Lars> Robert Pluim <rpluim@gmail.com> writes:
    >> So I attempted to visit a PNG file from emacs, and got a buffer
    >> containing the image data, and the following in *Messages*
    >> 
    >> Cannot display image: ((app1 (cdr (assq 65505 (exif--parse-jpeg)))))
    >> 
    >> Itʼs unclear to me whether emacs should be able to display PNG
    >> natively here. (featurep 'png) is nil, but this is on macOS, which
    >> allegedly has builtin support for PNG. In any case Iʼm not expecting
    >> an error message about exif data.

    Lars> I'm unable to reproduce this error -- viewing png images works fine for
    Lars> me.

    Lars> Could you post a backtrace?  The easiest is probably to say

    Lars> M-: (image-toggle-display-image)

Debugger entered--Lisp error: (error "The buffer is not in Image mode")
  signal(error ("The buffer is not in Image mode"))
  error("The buffer is not in Image mode")
  image-toggle-display-image()
  eval((image-toggle-display-image) t)
  eval-expression((image-toggle-display-image) nil nil 127)
  funcall-interactively(eval-expression (image-toggle-display-image) nil nil 127)
  call-interactively(eval-expression nil nil)
  command-execute(eval-expression)

which is a whole different error (although the modeline says
"(Fundamental Image)"

Robert

Re: master 8542f66 2/3: Automatically rotate images in image-mode based on Exif data

[Lars Ingebrigtsen]

Robert Pluim <rpluim@gmail.com> writes:

>     Lars> Could you post a backtrace?  The easiest is probably to say
>
>     Lars> M-: (image-toggle-display-image)
>
> Debugger entered--Lisp error: (error "The buffer is not in Image mode")
>   signal(error ("The buffer is not in Image mode"))
>   error("The buffer is not in Image mode")

Uhm...  try (setq major-mode 'image-mode) first or something?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 8542f66 2/3: Automatically rotate images in image-mode based on Exif data

[Robert Pluim]

>>>>> On Wed, 30 Oct 2019 17:18:36 +0100, Lars Ingebrigtsen <larsi@gnus.org> said:

    Lars> Robert Pluim <rpluim@gmail.com> writes:
    Lars> Could you post a backtrace?  The easiest is probably to say
    >> 
    Lars> M-: (image-toggle-display-image)
    >> 
    >> Debugger entered--Lisp error: (error "The buffer is not in Image mode")
    >> signal(error ("The buffer is not in Image mode"))
    >> error("The buffer is not in Image mode")

    Lars> Uhm...  try (setq major-mode 'image-mode) first or something?

Uhm, yes, of course. Bit of a senior moment there :-)

Debugger entered--Lisp error: (invalid-function (app1 (cdr (assq 65505 (exif--parse-jpeg)))))
  (app1 (cdr (assq 65505 (exif--parse-jpeg))))()
  exif-parse-buffer()
  image-toggle-display-image()
  eval((image-toggle-display-image) t)
  eval-expression((image-toggle-display-image) nil nil 127)
  funcall-interactively(eval-expression (image-toggle-display-image) nil nil 127)
  call-interactively(eval-expression nil nil)
  command-execute(eval-expression)

Re: master 8542f66 2/3: Automatically rotate images in image-mode based on Exif data

[Lars Ingebrigtsen]

Robert Pluim <rpluim@gmail.com> writes:

>     Lars> Uhm...  try (setq major-mode 'image-mode) first or something?
>
> Uhm, yes, of course. Bit of a senior moment there :-)
>
> Debugger entered--Lisp error: (invalid-function (app1 (cdr (assq 65505
> (exif--parse-jpeg)))))
>   (app1 (cdr (assq 65505 (exif--parse-jpeg))))()
>   exif-parse-buffer()

I think you may have a build error -- it sounds like exif.el was
compiled in an Emacs that didn't have when-let ;;;###autoloaded.

Try deleting exif.elc, or say "make bootstrap" and see whether the bug
goes away.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 8542f66 2/3: Automatically rotate images in image-mode based on Exif data

[Robert Pluim]

>>>>> On Wed, 30 Oct 2019 17:45:29 +0100, Lars Ingebrigtsen <larsi@gnus.org> said:

    Lars> Robert Pluim <rpluim@gmail.com> writes:
    Lars> Uhm...  try (setq major-mode 'image-mode) first or something?
    >> 
    >> Uhm, yes, of course. Bit of a senior moment there :-)
    >> 
    >> Debugger entered--Lisp error: (invalid-function (app1 (cdr (assq 65505
    >> (exif--parse-jpeg)))))
    >> (app1 (cdr (assq 65505 (exif--parse-jpeg))))()
    >> exif-parse-buffer()

    Lars> I think you may have a build error -- it sounds like exif.el was
    Lars> compiled in an Emacs that didn't have when-let ;;;###autoloaded.

    Lars> Try deleting exif.elc, or say "make bootstrap" and see whether the bug
    Lars> goes away.

That was it. Compiling exif.el complained about when-let being
undefined, so I did 'make -C lisp autoloads', and now emacs displays
PNG fine. Sorry for the noise.

Robert

Re: master 8542f66 2/3: Automatically rotate images in image-mode based on Exif data

[Stefan Monnier]

> Sorry for the noise.

FWIW, I love that meta-noise,


        Stefan