From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#39808: 28.0.50; toolbar broken Date: Thu, 27 Feb 2020 17:49:15 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="69390"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Markus FFM , 39808@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 27 17:50:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j7MMe-000Hwi-E3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Feb 2020 17:50:20 +0100 Original-Received: from localhost ([::1]:34448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7MMc-00026f-Fx for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Feb 2020 11:50:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43496) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7MMP-00026I-6Y for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 11:50:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7MMN-0004Uo-Hh for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 11:50:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54243) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j7MMM-0004UY-D8 for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 11:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j7MMM-0001OO-A3 for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 11:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Feb 2020 16:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39808 X-GNU-PR-Package: emacs Original-Received: via spool by 39808-submit@debbugs.gnu.org id=B39808.15828221655283 (code B ref 39808); Thu, 27 Feb 2020 16:50:02 +0000 Original-Received: (at 39808) by debbugs.gnu.org; 27 Feb 2020 16:49:25 +0000 Original-Received: from localhost ([127.0.0.1]:60216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7MLl-0001N9-4l for submit@debbugs.gnu.org; Thu, 27 Feb 2020 11:49:25 -0500 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:36054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7MLj-0001Mu-Gr for 39808@debbugs.gnu.org; Thu, 27 Feb 2020 11:49:24 -0500 Original-Received: by mail-wm1-f53.google.com with SMTP id f19so78644wmh.1 for <39808@debbugs.gnu.org>; Thu, 27 Feb 2020 08:49:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=YMo7eSr18/o2IYgV4yp48mer4nVvESzx0ExTl8fZ95I=; b=lf1OArbKkX9l43zUdl5xlEaSKBfTbKlHtniwwZ2joeC09DPxC+zhZAPjgGPjj/YxkO I5ecnFUArf3FVpVfmMuQ2beYCcmLGc/JjhgeQdohyAm+vpObOaYrwMypFWL2EJu3xycT IYattoAyAdrsD/IF4HZ7eoyPj60Nq9HvPHY1MhxRxP7ZQTwOqh1kAzDGZOsSt22IuchG 72w8zwpUfWyuaftQqm7V6eCI4XKdoOYrFaOG9sSTq8tCJZ5e117qrRmD0NMjoNiPrfpd aX8MtOK6DwHAS30cLHkX2azPR0S6ybLkpGnPPOXX8C30dYm3gSPaeiaYen+6G9pTwGW9 WryQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=YMo7eSr18/o2IYgV4yp48mer4nVvESzx0ExTl8fZ95I=; b=X1djMuw6GTuFlMDNCViCPyX2GT2hyxJAdHyKxbba2AtXuWYPd2M3VlSIW0YLx/iumD enLoG750GK/MoWDcTBRCT3DCwV7c1oatBpkP1dGNufldwZw3kb652zSaMwdTgqxBw3/n vdCTsOlFMo6zU3mv443kIs/aJcKH2hs0p0fZ+nMJwADvpVX56DbSXI0x3IS9tjUyD6EU 1cw+uUyQpBvlt1EPI0JrSt/TRMYDa4AG/4Dp/XhzoIrj8ZnFz4j8D2GkXi15k5MqEguZ aWU5QDR9V99SWntX5iOPOHGCGoLu7rmtQ6s8gqmPttJdyT3EiP9Be5AJX30bTbkieBew FBzQ== X-Gm-Message-State: APjAAAU+aW+rMdrVDCSrlXSh8Mh3cxQy6ru+2iWgxqYiK6gdZV8DCfoI Ec2Z5Y5OxUcjXimqPmB3S1a5Swsr+h0= X-Google-Smtp-Source: APXvYqykWa/7K3cTVAOIogW1QnGXPiwXiG6Sgv/m1OX5uHpLKjae1ryAZeqvSL1nR7DNDB3KV+053w== X-Received: by 2002:a7b:c257:: with SMTP id b23mr411347wmj.70.1582822157188; Thu, 27 Feb 2020 08:49:17 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id h205sm8319896wmf.25.2020.02.27.08.49.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 08:49:16 -0800 (PST) In-Reply-To: (Robert Pluim's message of "Thu, 27 Feb 2020 17:43:46 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176536 Archived-At: >>>>> On Thu, 27 Feb 2020 17:43:46 +0100, Robert Pluim s= aid: Robert> That fixes it for GTK. For NS, the buffer does not get killed, = and I Robert> get the following in the terminal: Robert> 2020-02-27 17:40:03.139 emacs[41579:935742] -[NSControlAuxiliary Robert> modifierFlags]: unrecognized selector sent to instance 0x7fd582= c6c8c0 Robert> To be fair, it might have been doing this before: I never run w= ith the Robert> tool bar. I think you were over-enthusiastic with your pruning, I put back the initialisation of theEvent, that fixes this (I=CA=BCm a bit pressed for time tonight, so can=CA=BCt commit it right now). diff --git a/src/nsterm.m b/src/nsterm.m index aefbb2721e..84acb61dcd 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -8185,6 +8185,7 @@ - (instancetype)toolbarClicked: (id)item if (!emacs_event) return self; =20 + theEvent =3D [[self window] currentEvent]; emacs_event->kind =3D TOOL_BAR_EVENT; /* XSETINT (emacs_event->code, 0); */ emacs_event->arg =3D AREF (emacsframe->tool_bar_items,