From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#68244: hash-table improvements Date: Tue, 13 Feb 2024 13:12:08 +0100 Message-ID: References: <170438379722.3921.9312235725296561206@vcs2.savannah.gnu.org> <08314177-5AE9-4352-94A0-641830B4094D@gmail.com> <19265EA5-E6F3-446C-AD9B-763693CF0A48@gmail.com> <6F3E332D-54ED-4E70-BBAA-A207750B52F8@gmail.com> <13877748-AFAB-4310-A0CA-104752C8BF2D@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6014"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Dmitry Gutov , Eli Zaretskii , 68244@debbugs.gnu.org, Stefan Monnier , Stefan Kangas To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 13 13:31:47 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZrww-0001S5-MQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Feb 2024 13:31:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZrfZ-0001be-58; Tue, 13 Feb 2024 07:13:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZrfV-0001Z4-3z for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 07:13:45 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZrfU-0004Rd-RY for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 07:13:44 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZrfm-0000td-6v for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 07:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Feb 2024 12:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68244 X-GNU-PR-Package: emacs Original-Received: via spool by 68244-submit@debbugs.gnu.org id=B68244.17078264173398 (code B ref 68244); Tue, 13 Feb 2024 12:14:02 +0000 Original-Received: (at 68244) by debbugs.gnu.org; 13 Feb 2024 12:13:37 +0000 Original-Received: from localhost ([127.0.0.1]:42502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZrfN-0000sk-4a for submit@debbugs.gnu.org; Tue, 13 Feb 2024 07:13:37 -0500 Original-Received: from mail-ed1-f53.google.com ([209.85.208.53]:43362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZrfK-0000sU-8Q for 68244@debbugs.gnu.org; Tue, 13 Feb 2024 07:13:35 -0500 Original-Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-562117d3dbfso65356a12.1 for <68244@debbugs.gnu.org>; Tue, 13 Feb 2024 04:13:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707826331; x=1708431131; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GiToL/A46RbX00Pwbz9AakYif1H/4T3DWacC0+nrWEg=; b=hnmWAAl+hPSZtr5AgrmmKMlQF0ltb+t/ZM6/iKh9u0HGIwtSFxINOVjzUgC8svU5RZ LthETz2wJmAGfAvmf3j8CFD6/rSMznXN93j1fwObH1W7VYLByLbZwlY3Ygkoc+kLSqkU /iAxhYQbV1XPFynhTblQqLAN6iXCp30fEmqCzdwfqEXKQnzcSAdAf2GQ3pCTqhGYfBup 8ma4XxOpj2fnaqL0B7kqF5DRCe2uO5Zb527owrIDxhGv6EBDExO9m7He0WeLK7XnThEF AIEHx99JgKU7OZhhh6wiwqlSHTA3WpXO2isgZILiJJwEB3b17X1yP37U7vWFqAB1omyx 0WKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707826331; x=1708431131; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GiToL/A46RbX00Pwbz9AakYif1H/4T3DWacC0+nrWEg=; b=dKYcY4r7Tbku/xgNvyBoZXZh1WTklauS4uf7SPisa8PTj1Zg3o9lEZ37+dB8VxFYVL L5dmCoz2MVpn7eqoIrQm0Qgrdw1JPrv2kZcut/ISVi0fDNBBMBWzLrCwQFS5iWEUK7WC 0DN+iSwnshH/31bf1Y+wO2zWSMwts0WH3jCrHpbF2Ooz1HNhTWr5+GTVquaYD1LKEKjH AeXHSbLqx9accRKSG31Vfp+Ju83KdkeV4P2wjDwbMpPvBaDo3PpbUHDXFW7zz6W6WBj9 MmWyAchFVYQjiEEzKdz/jxG5SfsYxqgTAmwsgPDJadT45UehAVuIDt01D7ywunQiSG9M 4YOA== X-Forwarded-Encrypted: i=1; AJvYcCVdzAhyU4b0YD68ut6h5Khd0+guTrlq87S0d4trPK5dQWuGCzMMzl/jqulV/5z/SPGOQfm82O4+tEiTkf46Ix/KZbagFyc= X-Gm-Message-State: AOJu0YzUMMipm/UWDpyuRAvxFTSC7SiQGhppyiK4gP3UN9ICAWqesx1N HAHOP9XoY+E/Zfk5OD7GfqC+O+Px7D8IjhIILVs+xLEfROLJ/0VQmiabm9kZ X-Google-Smtp-Source: AGHT+IESCqARdOyUgO6aIpMiZwNkyMS6+T9AOjmL412t0D1utJzhjfFEu71XRB4TEwvFO26bBamM2g== X-Received: by 2002:a05:6402:290a:b0:561:ed6b:2848 with SMTP id ee10-20020a056402290a00b00561ed6b2848mr1792918edb.3.1707826330798; Tue, 13 Feb 2024 04:12:10 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVm1Yo/w4dOZShacgXyanybk4DWg9q1rECPP1/3hnBjSSeQS0iW8i5U+bOuQpS85D0+M2SVAdnKcq6dDp/E2PDT4LApfHxh+7ldpf/L6Q60zmyvtnVYuwsMoIIjP2XNYOyp/Fy7uB1RaVDuhEqqwnuWysAJENMWEfpIGEeZGw== Original-Received: from Pro.fritz.box (pd9e36e83.dip0.t-ipconnect.de. [217.227.110.131]) by smtp.gmail.com with ESMTPSA id f17-20020a056402355100b005620a2b5cedsm168955edd.49.2024.02.13.04.12.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 04:12:10 -0800 (PST) In-Reply-To: <13877748-AFAB-4310-A0CA-104752C8BF2D@gmail.com> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Tue, 13 Feb 2024 11:12:37 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279956 Archived-At: Mattias Engdeg=C3=A5rd writes: > 13 feb. 2024 kl. 10.05 skrev Gerd M=C3=B6llmann : > >> I wonder, what does your code do for the places using (make-vector n 0) >> create obarrays? I'm not 100% sure, but I think Cedet was an example of >> that in Emacs itself. > > That code would still work, but just for completeness I changed all > those instances to using `obarray-make`, including cedet. (See the > branch scratch/obarray.) > > A more worrying problem is code that uses `obarray-make` but assumes > the result to be vectors. It may be unsafe to let obarray-make return > an obarray object for that reason. With Stefan's suggestion, if I > understood it right, we'd have `obarray-make` return (vector 0). I'll > give it a try. Thanks for the pointer.