Re: MPS image cache

["Gerd Möllmann" <gerd.moellmann@gmail.com>]

Gerd Möllmann <gerd.moellmann@gmail.com> writes:

> Gerd Möllmann <gerd.moellmann@gmail.com> writes:
>
>> Helmut Eller <eller.helmut@gmail.com> writes:
>>
>>> On Fri, May 03 2024, Gerd Möllmann wrote:
>>>
>>>> I think I have one: struct terminal's image_cache is not traced. AFAICS,
>>>> the cache is malloc'd and contains struct image which is an MPS object.
>>>>
>>>> WDYT?
>>>
>>> Two options come to mind:
>>>   1) trace it in fix_terminal
>>>   2) register terminal.c:terminal_list as root.
>>>
>>> It seems to me that creating a root is more "correct".
>>
>> I'm meanhile tending ta the third option: make iamge_cache an MPS object
>> like face_cache. For a reason that's proobably the reason why I made
>> fache_cache an MPS object:
>>
>> While we scan an object, MPS gives us exclusive access to it. I think we
>> want that for these caches, so that scanning does not interfere iwth the
>> client modifying the cache?
>>
>> Right?
>
> I've doen that now. It is right :-)

The next one I get is in nsterm.m

      NSWindow *parentWindow = [FRAME_NS_VIEW (parentFrame) window];

where parentFrame is a struct frame *. That can take some time...