From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS symbols Date: Fri, 28 Jun 2024 14:36:11 +0200 Message-ID: References: <87r0chwnzx.fsf@gmail.com> <87ikxtwljl.fsf@gmail.com> <87cyo1wadz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1965"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 28 14:37:11 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNAql-0000NK-4Y for ged-emacs-devel@m.gmane-mx.org; Fri, 28 Jun 2024 14:37:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNApv-0002vb-4p; Fri, 28 Jun 2024 08:36:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNAps-0002v5-8h for emacs-devel@gnu.org; Fri, 28 Jun 2024 08:36:17 -0400 Original-Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNApq-0001xp-P1 for emacs-devel@gnu.org; Fri, 28 Jun 2024 08:36:16 -0400 Original-Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-584ef6c07c2so2546387a12.1 for ; Fri, 28 Jun 2024 05:36:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719578173; x=1720182973; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7zePNIlT9I8tPDZ4eKqDm4sB+jJacW/UM8lsx3ym7R0=; b=GLysib8XRGKx0nPIgbXR7OYZCCYdtdPuOkV0C3+zkNuA0oZTthQy/KKvihp/VH3O5X JIBR7ZcrV6O6BuySYtf+XE0G1vZgYOOpVrdBqeJDsu2CQBoE0CN1d45If0VUFf38k3WN UcZDxPd+l7DzfiVWUPNQ7Icr04jvQz1jyygjMu1ZnVnNuKtnz6VNIomkNRQmwxKy40IH D+aB3eYGfYGeKWsT3Y4Wyis/uMS77s7unRNi35+poLW7TzcH0oFY3krsg6dxYWm3/nrs aJDSiCGlPFzjGIPoTc7BodALROEdpzlrPMXOR7xvKiCHuLl/xmlSFcrQa5ZHQpAJDu/M Ce0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719578173; x=1720182973; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7zePNIlT9I8tPDZ4eKqDm4sB+jJacW/UM8lsx3ym7R0=; b=jGR+iTZf4BHiJe8GZdAY5xyK0bUk3ahA3QBV1DN+0QJ7iKoUHVWNimsxB2hO23dJTb UJwjMwamLHcpx/FRTDB4Dtw3JER1uukY6s5BEZ1ZckhrVRji6ITfnO7IglhAfq+sngZz TjVMDwFiQ3moC2AB6MWUUhh1QU0174KQsrAI+b+pMt9OYhnK4z0MFULms0yYnvxCMdCH kIePvduaI/ZtC+AcPPlKy2fwD/Zj4e9es3eStENDGTUxqvl99uEAs61NLoqZz9kbqYyy ZmO1C71O/+NM8Bq88hQloi0tIlbazmsZjwl4DEcJNd04mxfnOe5bD02vmEyhcXrlBURi r4gA== X-Gm-Message-State: AOJu0YwxEEkspzgEpxWYQjRmCusVSp0XCp6XvRP/tgNvr3w05phNABLt wezL2+lVcLckpPs2ds2yfLNjmAdQiPRFW5AUm3sVRoWVplzFNtL1RYSYVQ== X-Google-Smtp-Source: AGHT+IGwgY8psl5yIuSqcQSeaw9zRDq5uTRf1aStmXdvvkvTzKf+Ye27iDurrt8uNlOw5LdvQO3OrQ== X-Received: by 2002:a17:907:a4b:b0:a72:afd9:6109 with SMTP id a640c23a62f3a-a72afd9622dmr129925166b.16.1719578172879; Fri, 28 Jun 2024 05:36:12 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e360da.dip0.t-ipconnect.de. [217.227.96.218]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72aaf638fesm75584566b.68.2024.06.28.05.36.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jun 2024 05:36:12 -0700 (PDT) In-Reply-To: ("Gerd =?utf-8?Q?M=C3=B6llman?= =?utf-8?Q?n=22's?= message of "Fri, 28 Jun 2024 14:13:45 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::531; envelope-from=gerd.moellmann@gmail.com; helo=mail-ed1-x531.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320814 Archived-At: Gerd M=C3=B6llmann writes: > Helmut Eller writes: > >> On Fri, Jun 28 2024, Gerd M=C3=B6llmann wrote: >> >>> Gerd M=C3=B6llmann writes: >>> >>>> Forgot something. While looking at the scanner, I wondered if we could >>>> remove the is_mps check from fix_lisp_obj now that we have the dump >>>> in MPS... >>> >>> Let's find out, pushed. Works for me :-) >> >> I think this uncovered a bug. Now this >> >> emacs -Q -eval '(progn (view-hello-file) (forward-line 7) (dotimes (_ = 5) >> (redisplay) (igc--collect) (forward-line)))' -f kill-emacs >> >> causes a SIGSEGV in fix_font, >> >> case FONT_OBJECT_MAX: >> { >> struct font *f =3D (struct font *)v; >> const Lisp_Object *type =3D &f->driver->type; >> IGC_FIX12_OBJ (ss, igc_const_cast (Lisp_Object *, type)); >> } >> >> It turns out that f->driver is the variable xfont_driver and it is >> actually const and the type field is a builtin symbol. So it looks like >> we can remove fix_font completely. > > Hm, okay. Can you see why is segfaults? I'm wondering because I'd have > thought that we'd crash all over the place if we couldn't handle > built-in symbols... Please scratch that, I see it (macOS doesn't even have a definition for struct font_driver...). I'll remove fix_font.