From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS: weak hash tables Date: Sat, 06 Jul 2024 16:38:46 +0200 Message-ID: References: <-plQctKgNkvp-LJ9ov2QAiXQKxd9V-hI0yz_opRGxQtbknubCjH4rH2-ymgbw_Qr1ZhB1rtlmiEW8XtuIVNr7nR_Yj20AH6WkH6kUGp68g0=@protonmail.com> <_mNcR6ailVKpYHLxgfo_tJlYGeR0AQIzQWluspYYp5_g5pIIKkHLNfFkklQQgOKNiVW8jn8NS3i2dJ7_B2Qyx9v-Dq3MQ9mP8HNL30UWsqY=@protonmail.com> <878qyf4sgm.fsf@gmail.com> <878qye3l81.fsf@gmail.com> <86ikxi4vt5.fsf@gnu.org> <871q4639z0.fsf@gmail.com> <86zfqu39k4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30048"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Helmut Eller , pipcet@protonmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 06 16:39:41 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQ6Zg-0007Z2-6i for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Jul 2024 16:39:40 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQ6Yv-0003pG-8l; Sat, 06 Jul 2024 10:38:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQ6Yt-0003os-Kq for emacs-devel@gnu.org; Sat, 06 Jul 2024 10:38:51 -0400 Original-Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sQ6Yr-0000Ad-Vi; Sat, 06 Jul 2024 10:38:51 -0400 Original-Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-52e97e5a84bso3745742e87.2; Sat, 06 Jul 2024 07:38:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720276727; x=1720881527; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=U1R5yUYWEYIZZrSczn1y3tCo9VYokpNFFfNDv17CtLc=; b=lVDJ/Tfy6aafqcUBp8zh1HXpJRo1Il+wca2q+HZ5uCMDV5hBH4I/FaAkYtQHXt5aZP kSK4lneYQpb632OIJLnRF0ub256/8OaVkG4f0d0pnIRW0i3dz8vt2PTOB37IT3JXUBIh Vhw1vZu+KAccJcNjEkoo6PKioUMYtJDMJnxoL8YMGN8C2mFykg867lw/ADwF58j9Iv7R IixocaSUlPioisz0xR3Aa5WxpqSAcPGOsX1J2QnoAzLEXLSSAojankGA3PeaSEMbdBM5 qU2xy5qsUfx1QhGvGp9bp7KQTR/mFsYwRurU2URflN2rFVib/i2bA2yv/hXNgW0za5ku DmZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720276727; x=1720881527; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U1R5yUYWEYIZZrSczn1y3tCo9VYokpNFFfNDv17CtLc=; b=HRHJRrTZOlo+s/huK2mn9l2XWYjyVtONjxcoyq9GbDegX2rd/qHgfSvOFnoI/6E5XL IjzFsI6S6YnmYRxuI8jlzrj73xHLf5cDIJoGa2Eh0oCZSGu0k9K7dXC9mPXi9caWuEfw Ssrs7LEOmI4DRJ5SFTdzIquC0HbnqY1OaaApwTfmI6h629MJ1AjsH5VvegQWzLkUJnIe rF1XYaKR7Fu1IO1QV0vayM0n1sQvt07T21He4gYRqva9OrVjt8CaPnhSjyOnK77aDPvb jMXlaL2LB2LvxK9UbsoJtRrj0Z/iLFB7GvQjWC4Nyf7SMr47+ZDT9GX1p5OnUrakXCnl tkmw== X-Forwarded-Encrypted: i=1; AJvYcCVPRCYZuZMr5YMNLgynoBYOoyXm6c28g3abwh/IdKVuAJbn8HFkqy3kBzDOHSyLNHdBRWpKS9e0Oo2U9hH7ESvkpEpi X-Gm-Message-State: AOJu0YwTfYNBhb6KEyXhewk1SF9s2nsCepWe7wPrIkkdTuBAr1Ropqls mmA++GNlZf4H1KfzjXfO2gB+TWd9PIoov0fYlTOukDuy0+nAxkPRoY6EGw== X-Google-Smtp-Source: AGHT+IFcGOkID4M6Mc3CQUGKN/A2B6Q5VzuhToVRPOSpXsIjwJ3ZF3pNjve+uPMAqoInPIjux4DY1w== X-Received: by 2002:ac2:5315:0:b0:52c:db76:2a7a with SMTP id 2adb3069b0e04-52ea0632597mr5948961e87.34.1720276727253; Sat, 06 Jul 2024 07:38:47 -0700 (PDT) Original-Received: from pro2.fritz.box (p4fe3a82e.dip0.t-ipconnect.de. [79.227.168.46]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72ab0657a6sm770366366b.129.2024.07.06.07.38.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jul 2024 07:38:46 -0700 (PDT) In-Reply-To: <86zfqu39k4.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 Jul 2024 16:59:55 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::12b; envelope-from=gerd.moellmann@gmail.com; helo=mail-lf1-x12b.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321440 Archived-At: Eli Zaretskii writes: >> From: Helmut Eller >> Cc: gerd.moellmann@gmail.com, pipcet@protonmail.com, emacs-devel@gnu.org >> Date: Sat, 06 Jul 2024 15:50:59 +0200 >> >> On Sat, Jul 06 2024, Eli Zaretskii wrote: >> >> > Isn't the call to balance_an_interval made from sweep_buffers and >> > sweep_strings? We balance the intervals of the buffers and strings >> > that survived GC, to make accessing these trees faster. >> >> I don't know; I thought that the interval tree is a red-black tree that >> is always balanced. > > No, the interval tree is not a red-black tree. > >> > How did you conclude that rebalancing interval trees is needed for >> > printing backtraces? >> >> What else could cause it in ert-test-run-tests-batch-expensive? > > I don't know, and I don't see why we should guess. Run that under a > debugger with a breakpoint in balance_an_interval that shows the > backtrace, and you will see the answer very quickly. Just for info: (defun backtrace-to-string (&optional frames) "Format FRAMES, a list of `backtrace-frame' objects, for output. Return the result as a string. If FRAMES is nil, use all function calls currently active." (substring-no-properties (backtrace--to-string (or frames (backtrace-get-frames 'backtrace-to-string))))) which ert uses, calls backteace-get-frames which uses filtered-buffer-substring and so on, and then we throw all the properties away.