From: Andreas Schwab <schwab@linux-m68k.org>
To: Toru TSUNEYOSHI <t_tuneyosi@hotmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: macro FIXNUM_OVERFLOW_P in lisp.h is valid ?
Date: Fri, 23 Oct 2009 22:57:07 +0200 [thread overview]
Message-ID: <m2fx99q15o.fsf@igel.home> (raw)
In-Reply-To: <BLU0-SMTP78C64056174E8A0EBF01DCE2BD0@phx.gbl> (Toru TSUNEYOSHI's message of "Sat, 24 Oct 2009 02:51:47 +0900")
Toru TSUNEYOSHI <t_tuneyosi@hotmail.com> writes:
> I read the code of function `string-to-number', and traced functions or
> macros recursively.
>
> traces of string-to-number:
>
> data.c: Fstring_to_number
> lisp.h: make_fixnum_or_float
> lisp.h: FIXNUM_OVERFLOW_P
>
> citation of FIXNUM_OVERFLOW_P (in Emacs 23.1):
>
> /* Value is non-zero if C integer I doesn't fit into a Lisp fixnum. */
>
> #define FIXNUM_OVERFLOW_P(i) \
> ((EMACS_INT)(i) > MOST_POSITIVE_FIXNUM \
> || (EMACS_INT) (i) < MOST_NEGATIVE_FIXNUM)
>
> I think FIXNUM_OVERFLOW_P is problematic.
Thanks for the report. The right fix is to remove the cast, so that the
compiler will promote the operands to the appropriate common type.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2009-10-23 20:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 17:51 macro FIXNUM_OVERFLOW_P in lisp.h is valid ? Toru TSUNEYOSHI
2009-10-23 19:33 ` Eli Zaretskii
2009-10-24 1:50 ` Toru TSUNEYOSHI
2009-10-24 9:05 ` Eli Zaretskii
2009-10-24 11:59 ` Toru TSUNEYOSHI
2009-10-24 13:00 ` Eli Zaretskii
2009-10-24 18:45 ` Toru TSUNEYOSHI
2009-10-24 15:14 ` Andreas Schwab
2009-10-24 18:39 ` Stefan Monnier
2009-10-26 14:48 ` Toru TSUNEYOSHI
[not found] ` <20091024.105033.100383844.t_tuneyosi@hotmail.com>
2009-10-24 6:07 ` Toru TSUNEYOSHI
[not found] ` <20091024.150744.186061320.t_tuneyosi@hotmail.com>
2009-10-24 7:46 ` Toru TSUNEYOSHI
2009-10-24 10:11 ` Eli Zaretskii
2009-10-23 20:57 ` Andreas Schwab [this message]
2009-10-23 22:02 ` Eli Zaretskii
2009-10-24 1:05 ` Stefan Monnier
2009-10-24 9:15 ` Eli Zaretskii
2009-10-24 9:40 ` Andreas Schwab
2009-10-24 10:16 ` Eli Zaretskii
2009-10-24 10:01 ` Andreas Schwab
2009-10-23 21:14 ` Stefan Monnier
2009-10-25 8:51 ` Toru TSUNEYOSHI
[not found] ` <20091025.175131.55657724.t_tuneyosi@hotmail.com>
2009-10-25 11:30 ` Toru TSUNEYOSHI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2fx99q15o.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=emacs-devel@gnu.org \
--cc=t_tuneyosi@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.