(org-element-context) :end property

(org-element-context) :end property

[Thomas S. Dye]

Aloha all,

I've started to use John Kitchin's unlinkify function, which he posted
to the list last year.

(defun jk/unlinkify ()
  "Replace an org-link with the description, or if this absent, the path."
  (interactive)
  (let ((eop (org-element-context)))
    (when (eq 'link (car eop))
      (message "%s" eop)
      (let* ((start (org-element-property :begin eop))
             (end (org-element-property :end eop))
             (contents-begin (org-element-property :contents-begin eop))
             (contents-end (org-element-property :contents-end eop))
             (path (org-element-property :path eop))
             (desc (and contents-begin
                        contents-end
                        (buffer-substring contents-begin contents-end))))
        (setf (buffer-substring start end) (or desc path))))))

However, I get different results depending on whether the link ends with
a space or a character, e.g.

Foo [[http:www.tsdye.com][desc]] bar.
Foo [[http:www.tsdye.com][desc]], bar.

Foo descbar.
Foo desc, bar.

How can I fix this?  I'm guessing that org-element-context sets :end
differently depending on the character following the link?

All the best,
Tom
-- 
Thomas S. Dye
http://www.tsdye.com

Re: (org-element-context) :end property

[Nicolas Goaziou]

Hello,

Thomas S. Dye <tsd@tsdye.com> writes:

> I've started to use John Kitchin's unlinkify function, which he posted
> to the list last year.
>
> (defun jk/unlinkify ()
>   "Replace an org-link with the description, or if this absent, the path."
>   (interactive)
>   (let ((eop (org-element-context)))
>     (when (eq 'link (car eop))
>       (message "%s" eop)
>       (let* ((start (org-element-property :begin eop))
>              (end (org-element-property :end eop))
>              (contents-begin (org-element-property :contents-begin eop))
>              (contents-end (org-element-property :contents-end eop))
>              (path (org-element-property :path eop))
>              (desc (and contents-begin
>                         contents-end
>                         (buffer-substring contents-begin contents-end))))
>         (setf (buffer-substring start end) (or desc path))))))
>
> However, I get different results depending on whether the link ends with
> a space or a character, e.g.
>
> Foo [[http:www.tsdye.com][desc]] bar.
> Foo [[http:www.tsdye.com][desc]], bar.
>
> Foo descbar.
> Foo desc, bar.
>
> How can I fix this?  I'm guessing that org-element-context sets :end
> differently depending on the character following the link?

White spaces following an object are included in the object. They are
stored in :post-blank property. You can add them with

  (setf (buffer-substring start end)
        (concat (or desc path) 
                (make-string (org-element-property :post-blank eop) ?\s)))


Regards,

-- 
Nicolas Goaziou

Re: (org-element-context) :end property

[Thomas S. Dye]

Aloha Nicolas,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> White spaces following an object are included in the object. They are
> stored in :post-blank property. You can add them with
>
>   (setf (buffer-substring start end)
>         (concat (or desc path) 
>                 (make-string (org-element-property :post-blank eop) ?\s)))

Perfect.  Thanks!

All the best,
Tom

-- 
Thomas S. Dye
http://www.tsdye.com

Re: (org-element-context) :end property

[Thomas S. Dye]

Aloha all,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
>
> White spaces following an object are included in the object. They are
> stored in :post-blank property. You can add them with
>
>   (setf (buffer-substring start end)
>         (concat (or desc path) 
>                 (make-string (org-element-property :post-blank eop) ?\s)))

To wrap this up, the revised unlinkify function (and a hydra with the
org-link-edit functions) are here:

https://github.com/abo-abo/hydra/wiki/Org-mode-links

All the best,
Tom
-- 
Thomas S. Dye
http://www.tsdye.com

Re: (org-element-context) :end property

[John Kitchin]

Neat! Where does one find org-link-edit.el? Is it this one:
https://github.com/kyleam/org-link-edit?



Thomas S. Dye writes:

> Aloha all,
>
> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>
>> Hello,
>>
>>
>> White spaces following an object are included in the object. They are
>> stored in :post-blank property. You can add them with
>>
>>   (setf (buffer-substring start end)
>>         (concat (or desc path)
>>                 (make-string (org-element-property :post-blank eop) ?\s)))
>
> To wrap this up, the revised unlinkify function (and a hydra with the
> org-link-edit functions) are here:
>
> https://github.com/abo-abo/hydra/wiki/Org-mode-links
>
> All the best,
> Tom

--
Professor John Kitchin
Doherty Hall A207F
Department of Chemical Engineering
Carnegie Mellon University
Pittsburgh, PA 15213
412-268-7803
@johnkitchin
http://kitchingroup.cheme.cmu.edu

Re: (org-element-context) :end property

[Kyle Meyer]

John Kitchin <jkitchin@andrew.cmu.edu> writes:

> Neat! Where does one find org-link-edit.el? Is it this one:
> https://github.com/kyleam/org-link-edit?

It is that one, but it's also in contrib.

-- 
Kyle