all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: charles@aurox.ch (Charles A. Roelli)
To: 30079-done@debbugs.gnu.org
Subject: bug#30079: 26.0.90; comint commands killing pending input
Date: Mon, 15 Jan 2018 21:21:37 +0100	[thread overview]
Message-ID: <m2fu76dga6.fsf@aurox.ch> (raw)
In-Reply-To: <m2inc8ceto.fsf@aurox.ch> (charles@aurox.ch)

> Date: Thu, 11 Jan 2018 21:37:07 +0100
> From: charles@aurox.ch (Charles A. Roelli)
> 
> The following four commands all claim to "kill the pending input",
> which they don't actually seem to do.  Should the documentation or
> implementation be changed?
> 
> 
> (defun comint-interrupt-subjob ()
>   "Interrupt the current subjob.
> This command also kills the pending input
> between the process mark and point."
>   (interactive)
>   (comint-skip-input)
>   (interrupt-process nil comint-ptyp)
>   ;; (process-send-string nil "\n")
>   )
> 
> (defun comint-kill-subjob ()
>   "Send kill signal to the current subjob.
> This command also kills the pending input
> between the process mark and point."
>   (interactive)
>   (comint-skip-input)
>   (kill-process nil comint-ptyp))
> 
> (defun comint-quit-subjob ()
>   "Send quit signal to the current subjob.
> This command also kills the pending input
> between the process mark and point."
>   (interactive)
>   (comint-skip-input)
>   (quit-process nil comint-ptyp))
> 
> (defun comint-stop-subjob ()
>   "Stop the current subjob.
> This command also kills the pending input
> between the process mark and point.
> 
> WARNING: if there is no current subjob, you can end up suspending
> the top-level process running in the buffer.  If you accidentally do
> this, use \\[comint-continue-subjob] to resume the process.  (This
> is not a problem with most shells, since they ignore this signal.)"
>   (interactive)
>   (comint-skip-input)
>   (stop-process nil comint-ptyp))

I pushed a documentation fix to emacs-26:

  commit 98e5fb9bf3b49bea82a4d3e38be20415bd7f7684
  Author: Charles A. Roelli <charles@aurox.ch>
  Date:   Mon Jan 15 21:14:05 2018 +0100

    Remove incorrect documentation in comint.el

    * lisp/comint.el (comint-interrupt-subjob, comint-kill-subjob)
    (comint-quit-subjob, comint-stop-subjob): Remove incorrect
    documentation.  (Bug#30079)

If there's any interest in reinstating the old, documented (but
unimplemented) behavior in the master branch, please reopen.





      reply	other threads:[~2018-01-15 20:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-11 20:37 bug#30079: 26.0.90; comint commands killing pending input Charles A. Roelli
2018-01-15 20:21 ` Charles A. Roelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2fu76dga6.fsf@aurox.ch \
    --to=charles@aurox.ch \
    --cc=30079-done@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.