From: Robert Pluim <rpluim@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master fe939b3 1/2: Fix reference to `tags-loop-continue' in doc string
Date: Sun, 04 Aug 2019 14:03:24 +0200 [thread overview]
Message-ID: <m2ftmh87eb.fsf@gmail.com> (raw)
In-Reply-To: <877e7vpgmt.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Fri, 02 Aug 2019 20:27:22 +0200")
>>>>> On Fri, 02 Aug 2019 20:27:22 +0200, Lars Ingebrigtsen <larsi@gnus.org> said:
Lars> Robert Pluim <rpluim@gmail.com> writes:
>> Ah, you mean like this? I hope I have the eval-when-compile stuff
>> right. And if you do 'dired-do-search' followed by
>> 'xref-find-definitions' it would be easy to confuse yourself.
>>
>> We could find a new binding for fileloop-continue, which also breaks
>> backwards compatibility, but then at least thereʼs a default binding.
Lars> [...]
>> +(eval-when-compile (declare-function fileloop-continue "fileloop" ()))
Lars> I don't think this is necessary -- you can just have the
Lars> `declare-function' without any `eval-when-compile'. But you should
Lars> probably include the arg list?
I did :-)
fileloop.el:
(defun fileloop-continue ()
>> + (if (ring-empty-p ring)
>> + ;; Just in case we were in a fileloop sequence
>> + (fileloop-continue)
Lars> Yes, that's what I wondered would work. Are there any drawbacks to
Lars> doing something like this? Perhaps the interface becomes a bit...
Lars> unpredictable?
Itʼs perfectly deterministic, just potentially confusing :-)
It begs the question why xrefs replaced a 'do the next thing' type
binding with a 'go back' type binding in the first place. Iʼm tempted
to say that xref-pop-marker-stack should use a different binding, and
M-, should be fileloop-continue, but the xref one has existed for 5
years now.
Robert
next prev parent reply other threads:[~2019-08-04 12:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190801195403.16246.49802@vcs0.savannah.gnu.org>
[not found] ` <20190801195406.087AF20CC8@vcs0.savannah.gnu.org>
2019-08-02 8:59 ` master fe939b3 1/2: Fix reference to `tags-loop-continue' in doc string Robert Pluim
2019-08-02 10:49 ` Lars Ingebrigtsen
2019-08-02 12:23 ` Robert Pluim
2019-08-02 18:27 ` Lars Ingebrigtsen
2019-08-04 12:03 ` Robert Pluim [this message]
2019-08-04 12:09 ` Lars Ingebrigtsen
2019-08-04 12:24 ` Robert Pluim
2019-08-05 9:12 ` Lars Ingebrigtsen
2019-08-05 10:39 ` Dmitry Gutov
2019-08-05 10:46 ` Lars Ingebrigtsen
2019-08-05 10:54 ` Lars Ingebrigtsen
2019-08-05 13:12 ` Robert Pluim
2019-08-05 10:42 ` Dmitry Gutov
2019-08-05 15:05 ` Drew Adams
2019-08-05 18:50 ` Dmitry Gutov
2019-08-05 19:58 ` Juri Linkov
2019-08-07 18:33 ` Lars Ingebrigtsen
2019-08-07 22:11 ` Dmitry Gutov
2019-08-08 20:45 ` Juri Linkov
2019-08-06 3:23 ` Richard Stallman
2019-08-05 10:36 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ftmh87eb.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.