From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 50c5d56: --with-cairo is no longer experimental
Date: Wed, 06 Nov 2019 08:39:54 +0100 [thread overview]
Message-ID: <m2ftj1h2r9.fsf@gmail.com> (raw)
In-Reply-To: <83d0e5he3w.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 06 Nov 2019 05:34:43 +0200")
>>>>> On Wed, 06 Nov 2019 05:34:43 +0200, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Tue, 05 Nov 2019 21:07:20 +0100
>> Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org
>>
>> I can crash the Xft one in about 2 seconds, even with my recent
>> patch. Iʼve not run the Cairo build in anger, but it seems stable.
Eli> Can't we provide some band-aid to prevent Xft from crashing Emacs?
We could filter out 'Noto Color Emoji' in gtkutil.c:xg_get_font, but
the relevant GTK interface is marked as deprecated, so weʼd have to
match on font name or something. Itʼs not pretty:
diff --git a/src/gtkutil.c b/src/gtkutil.c
index 16d765533a..ccdba27ff2 100644
--- a/src/gtkutil.c
+++ b/src/gtkutil.c
@@ -2281,12 +2281,14 @@ xg_get_font (struct frame *f, const char *default_name)
gint size = pango_font_description_get_size (desc);
PangoWeight weight = pango_font_description_get_weight (desc);
PangoStyle style = pango_font_description_get_style (desc);
-
- font = CALLN (Ffont_spec,
- QCfamily, build_string (family),
- QCsize, make_float (pango_units_to_double (size)),
- QCweight, XG_WEIGHT_TO_SYMBOL (weight),
- QCslant, XG_STYLE_TO_SYMBOL (style));
+ if (strcmp (family, "Noto Color Emoji") == 0)
+ font = Qnil;
+ else
+ font = CALLN (Ffont_spec,
+ QCfamily, build_string (family),
+ QCsize, make_float (pango_units_to_double (size)),
+ QCweight, XG_WEIGHT_TO_SYMBOL (weight),
+ QCslant, XG_STYLE_TO_SYMBOL (style));
pango_font_description_free (desc);
dupstring (&x_last_font_name, family);
next prev parent reply other threads:[~2019-11-06 7:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190619070851.22726.77187@vcs0.savannah.gnu.org>
[not found] ` <20190619070853.E841E208EC@vcs0.savannah.gnu.org>
2019-11-05 10:33 ` [Emacs-diffs] master 50c5d56: --with-cairo is no longer experimental Robert Pluim
2019-11-05 18:25 ` Eli Zaretskii
2019-11-05 20:07 ` Robert Pluim
2019-11-06 3:34 ` Eli Zaretskii
2019-11-06 7:39 ` Robert Pluim [this message]
2019-11-06 16:11 ` Eli Zaretskii
2019-11-07 8:48 ` Robert Pluim
2019-11-07 14:31 ` Eli Zaretskii
2019-11-07 16:11 ` Robert Pluim
2019-11-07 17:24 ` Eli Zaretskii
2019-11-08 21:40 ` Robert Pluim
2019-11-08 22:59 ` Paul Eggert
2019-11-12 7:47 ` Robert Pluim
2019-11-12 13:32 ` Stefan Monnier
2019-11-09 6:44 ` Eli Zaretskii
2019-11-12 7:51 ` Robert Pluim
2019-11-14 9:48 ` Robert Pluim
2019-11-14 14:10 ` Eli Zaretskii
2019-11-14 11:53 ` Eli Zaretskii
2019-11-14 12:21 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ftj1h2r9.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.