From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS: native comp Date: Mon, 29 Apr 2024 10:02:58 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38444"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel missing value To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 29 10:04:00 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s1LzU-0009lT-HV for ged-emacs-devel@m.gmane-mx.org; Mon, 29 Apr 2024 10:04:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s1Lyc-0002gR-Fz; Mon, 29 Apr 2024 04:03:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1Lya-0002gG-9b for emacs-devel@gnu.org; Mon, 29 Apr 2024 04:03:04 -0400 Original-Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s1LyY-0004wn-7y; Mon, 29 Apr 2024 04:03:03 -0400 Original-Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-34cdb750bb3so480777f8f.0; Mon, 29 Apr 2024 01:03:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714377780; x=1714982580; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=WKVO5PRmVCHverMv826gKL8YArtsW/5xfxqQJ1Wu55E=; b=OzPatkbP78oumjucaKMQuCJ9XoPxHrbB6zYlkMB05raYSsPppKSnbyDJzm3UYnCw6t CepuEcya+1zVBw6IkJf3XdqbQDARuZNY+VeXf1kybwWagPIXG7M0Sn2w4yuCE7UpsnhW vEQQcd2xK1SOZUFb589KO7BJhXhms38YDGUAEqoQQzZTwH1844dwyYMg1qt5V9/kdeYQ jXu8QTvK0VvB4mH7WuMebpdFvIiReOrGRt7kHJPE40DQLGMUMB0a4XPzxiyGFoT/1vzt v1bttBlsJ6MflGHJ+v54DJ7d0h/9jNsn+nscl5/4aRu/T2Wq5Xdwmz6oS9YztBekbil+ bzjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714377780; x=1714982580; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WKVO5PRmVCHverMv826gKL8YArtsW/5xfxqQJ1Wu55E=; b=ZZF3pt931XfZI+Y8VpzMb7H+4Yn2pmi05j2yA7ZkdfDdOdxUlVv19o7zzZ8bqAQJqW yVP2meH2e9QDaLpmFCcyp1jl1bqlBuwrDQGJaxpptutNGrfHXzzOd/xxFV9n6HcZdC1L Uw9pJ0LC28YeT8VwJ/09/0t5JKFygP0luLrAN9dL06sVfiTrR8uOZvr51FGw+iBfQNGU Kt5XI12TvSg6gbDuHUKhIIM0Fv7Pjv+IKgclpPdMKksYbomekWiZb2vyOAUytBr2yCLW DUgccwXsM4T47paHdJ/p7tGHBCcvfkYbhHtYNl5yAxZRxuC72YgDiGy+2pJhybcOQn5n OZxQ== X-Gm-Message-State: AOJu0YwTjxgt7moHSrmQnI92kbX4Mz0SaIs4W22WllBpLwYCnoSfiPuo lVYWIfopdvncp9YRfuR69OhQM93qEY4qWvqLcYS/R4c6v+t4rzOur9IwSw== X-Google-Smtp-Source: AGHT+IGIx5sng3Ij7p09gvMe2CVvFb6sUXfiXQKX/qK2YyGXWGdYDYTeYVdt6elEJX/4wNnEQbhRmA== X-Received: by 2002:adf:e48d:0:b0:34c:ce6a:96fa with SMTP id i13-20020adfe48d000000b0034cce6a96famr3345490wrm.34.1714377779811; Mon, 29 Apr 2024 01:02:59 -0700 (PDT) Original-Received: from pro2.fritz.box (p4fe3a6a8.dip0.t-ipconnect.de. [79.227.166.168]) by smtp.gmail.com with ESMTPSA id f9-20020a0560001b0900b003456c693fa4sm28561754wrz.93.2024.04.29.01.02.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 01:02:59 -0700 (PDT) In-Reply-To: (Andrea Corallo's message of "Mon, 29 Apr 2024 03:29:44 -0400") Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=gerd.moellmann@gmail.com; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318324 Archived-At: Andrea Corallo writes: >> So, it looks like the string constant "Eager..." is a reference that is >> not traced. Can you please tell me where I can find these string >> constants in native cu data structures? > > "Eager macro-expansion failure: %S" is an immediate stored in the eln of > macroexp.el. This should be deserialized by 'load_static_obj' and > referenced by 'comp_u->data_vec' (see 'load_comp_unit' comp.c:5402). > > Maybe mps is not tracking Lisp_Native_Comp_Unit's fields? Thanks! Hm. I think I'm tracing data_vec already. Here is what I do static mps_res_t fix_native_cu (mps_ss_t ss, struct Lisp_Native_Comp_Unit *u) { MPS_SCAN_BEGIN (ss) { IGC_FIX_CALL_FN (ss, struct Lisp_Vector, u, fix_vectorlike); if (u->data_imp_relocs) { size_t n = ASIZE (u->data_impure_vec); IGC_FIX12_NOBJS (ss, u->data_imp_relocs, n); } } MPS_SCAN_END (ss); return MPS_RES_OK; } The fix_vectorlike should cover all Lisp_Objects in u that are in the Lisp part of the pseudovecor (you know what I mean). That's strange. Could the non-Lisp part of u contain a reference to the string somewhere else? The difference to the old GC with MPS is that we need to trace all references because MPS is a moving collector, and all references must be changed when an object mvoes.