From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id AFbvNzG4M2bhDAAAe85BDQ:P1 (envelope-from ) for ; Thu, 02 May 2024 17:58:42 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id AFbvNzG4M2bhDAAAe85BDQ (envelope-from ) for ; Thu, 02 May 2024 17:58:42 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=adamkovic.org header.s=fm1 header.b=jtYmQ70H; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="F GCvZE3"; dmarc=pass (policy=none) header.from=adamkovic.org; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1714665521; a=rsa-sha256; cv=none; b=VD3fdAY5UP8bynSAIzO/OBjRVtkcpwf3Ch3WAhDWUS9Y5fXNoVPZeqB0egTqtqWi3pM+Ne FrmMVmw260e9Hucb2VHcgDt4aUvVWV5Budii8h589mOAPHTIwcZbTKFV4Ksk7LaVtSF2PJ If1RkgKwUf2HXG3XOAFtNNl/eUcD3i48iysr1RfdD8CHLHJlYynFvaohLHPMyQPgAYX9UR Y4CvVFEC/DKL2FdYXkSnnqRr/KotlqMnse4mI46I4Gc7pYpcZhjQ2Ww8LkxiPyS/FT+U94 QWfA8oe8CSZcMsATjPUV8BCqxSUj0oa9tpsBWhfLuV9ofSf4ySR9OJXqGpiXXw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=adamkovic.org header.s=fm1 header.b=jtYmQ70H; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="F GCvZE3"; dmarc=pass (policy=none) header.from=adamkovic.org; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1714665521; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=+6N4DgJwLlgKJfz458LrSY01mezLjxX0ZHKvjmfSLzM=; b=ft0xUerdLZroc4jF8+nncaeLr1qQVu2L/Z9U9fgrWxNxskw7ZEO51mHaRax8vbQWgNLqRo g6j4R2Wxq937Vh6cP9Sj/R+CnS/s75lMP3ixQoIsPvrFahV5Rj6IO6ZabFnxDxV/oJNyxA 6/c+kERO2afFN56BLhr6pYuUZyuUGbaEIVowZNWF7Twux246o5x7kPyOGOU4syI1V5QGOx 73E70k2hrohv9zszM5sH+pNNIwtJ/PNU1VE9PnV00VJgLMM6yDZ98/qb+ufCeXqgkGetGo 9qvX9uiRgN38OkKRyaN7PH1QlJx/ZaGhmqf+V7WJ9cc8CusD9VIOrtAf9+Fn2g== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D184334E3D for ; Thu, 2 May 2024 17:58:41 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2Yp4-0001zU-Kl; Thu, 02 May 2024 11:58:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2Yp3-0001yx-4u for emacs-orgmode@gnu.org; Thu, 02 May 2024 11:58:13 -0400 Received: from fhigh5-smtp.messagingengine.com ([103.168.172.156]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2Yox-0003M9-W0 for emacs-orgmode@gnu.org; Thu, 02 May 2024 11:58:12 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 77DAD114010D; Thu, 2 May 2024 11:58:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 02 May 2024 11:58:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamkovic.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm1; t=1714665487; x=1714751887; bh=+6N4DgJwLlgKJfz458LrSY01mezLjxX0 ZHKvjmfSLzM=; b=jtYmQ70HywXcuYGSGZR3XOIPIgu90fV6kCWBchhC/4tCMoSq UsOJsjGTvsF0vdIPZ5CngpuTqoYU4w/NJAHKHm5Opgu8A9niseDHLVRYOLEcAFzl s0SnqbiVBMa/TSUy7yb3Pe2sLveAz+GeO3NRDs5yjax0+l+Lbcj79438eKBN46a5 wls08HTmMcukh1r7mS4jIInp01VgqnlKcxhrsSsk6oJNajHrZhJuOrLoNQ0NZN/l hcifGZ8zfIi+tuKpjhSTm4dSbzW8A9aroyV37Vsf+n+otIopIcr5U2PCA4dThCQ/ gOUGP1xMaa6ZnYs/fogAp+ki7Sqnipa41acvpg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1714665487; x= 1714751887; bh=+6N4DgJwLlgKJfz458LrSY01mezLjxX0ZHKvjmfSLzM=; b=F GCvZE3ggrPK8RsHUxt2AaejHePLXKgptxElIdRUSLGBKqQQxWnrJDYS+Q5b0/XgN mGdRngfkyZzYPWTsSK/IksMrXVbEwOGTQQfK5NWqhmgM/PfHXYzCUtJMqmwfjgVx UL+2J7lDeZQdzXn43TeC/ezKF9ewZgpm26jdEMF/hJt78CKVC7q1Z3SNZTNa1lXY XMVzAnoD8ZDdsd1RjYShyDvpNlyQGjMlznPtkTnFSyqa7PG31BConNB5y6hy8fax qr/xxA7rDwzwF/+2faclwujjgg9w9csa7b4l8k+ulLL9kLTnv8g09BbjHD5lnEHR 1MmtHoiPiWjMPzAJMKBbA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddukedgleeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufgjfhffkfggtgfgsehtqh ertddttdejnecuhfhrohhmpeftuhguohhlfhcutegurghmkhhovhhitgcuoehruhguohhl fhesrggurghmkhhovhhitgdrohhrgheqnecuggftrfgrthhtvghrnhepkeegffdttdduve dvtdeuvdeugeeugfeffedvhffhveekjeetffdtfeeigeettefgnecuvehluhhsthgvrhfu ihiivgepudenucfrrghrrghmpehmrghilhhfrhhomheprhhuugholhhfsegruggrmhhkoh hvihgtrdhorhhg X-ME-Proxy: Feedback-ID: i88214938:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 May 2024 11:58:06 -0400 (EDT) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] ob-lua: Support all types and multiple values in results In-Reply-To: <874jbjywq3.fsf@localhost> References: <20240423164458.33702-1-rudolf@adamkovic.org> <8734raewr6.fsf@localhost> <87pluctf6m.fsf@localhost> <87il01k6k1.fsf@localhost> <874jbjywq3.fsf@localhost> Date: Thu, 02 May 2024 17:58:05 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=103.168.172.156; envelope-from=rudolf@adamkovic.org; helo=fhigh5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: D184334E3D X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -9.55 X-Spam-Score: -9.55 X-TUID: uxua8aqP2HyA Ihor Radchenko writes: > May you please elaborate why this breaking change is going to lead to > significant improvement? How is using "," worse than using "|"? Either > way, strings containing the separator will become problematic and need > to be escaped. Moreover, using "|" may lead to interpreting the output > as Org tables, which may be surprising to users. Thank you for the review! The change of the separator was a lazy move on my part. I appologize. I changed the separator because I could not figure out how to make Org behave sanely. The problem is not specific to Lua: src_elisp{"3, 2, 1, and go!"} {{{results(=3D3\, 2\, 1\, and go!=3D)}}} Why Org is escaping commas here? In other words, should my tests expect \-escapes in front of commas, or is that a bug? I am attaching a V2 of the patch that: - does not modify the separator anymore (resulting in 3 failing tests) - adds one more test (which is just a sanity check, you can ignore it) - fixes Lua code indentation (as indented by the Lua major mode) Thank you for your guidance. Rudy --=20 "Be especially critical of any statement following the word 'obviously.'" --- Anna Pell Wheeler, 1883-1966 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25, 84103 Bratislava, Slovakia, European Union