From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Al Haji-Ali Newsgroups: gmane.emacs.bugs Subject: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs Date: Thu, 06 Jun 2024 00:44:28 +0100 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33369"; mail-complaints-to="usenet@ciao.gmane.io" To: 71386@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 06 02:11:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sF0iq-0008WA-SI for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jun 2024 02:11:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sF0iQ-0004CY-Fg; Wed, 05 Jun 2024 20:10:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sF0iP-0004CF-3H for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 20:10:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sF0iO-0003ov-RH for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 20:10:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sF0ic-0001yM-MF for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 20:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Al Haji-Ali Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Jun 2024 00:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71386 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17176326217495 (code B ref -1); Thu, 06 Jun 2024 00:11:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Jun 2024 00:10:21 +0000 Original-Received: from localhost ([127.0.0.1]:49530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sF0ht-0001wg-4B for submit@debbugs.gnu.org; Wed, 05 Jun 2024 20:10:21 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:58024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sF0Ma-0000zh-US for submit@debbugs.gnu.org; Wed, 05 Jun 2024 19:48:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sF0MM-0003XW-D9 for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 19:48:02 -0400 Original-Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sF0MK-00081c-Uo for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 19:48:02 -0400 Original-Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4210aa00c94so4310775e9.1 for ; Wed, 05 Jun 2024 16:48:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717631279; x=1718236079; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=x3Od+kHQiYw10KJUCEWfl19VRFpwdq31FvZ+w9rMBwk=; b=UgZcV+4+3dLMgPjoSj/Y+Xv3ilfC2FneLUE947mnGQ7SVQgByEhJhcm3iLgeuwCTiR vfwCFbkfauNYw2z4zCM+NomHh+LDCnr/3PGjN7PM5w03H1YPBs+VKioO0iqRbyRmE9L9 AsWQpRVeIXWN1RPoUsasZi8ksCqDUAcL0+Ons+AmUvoxQ44IC8Hj9jqi3JqJvdDLaTvw xviGQJUdHl6CUoV0LxSL/lP3YhCzWJJHijAvvTxEq2yDexUhCU8U/pQwixNikYujgnUS mH79kB8NP8RW9zz+0/y7u/Yu1vaY2d8yaGObDWKz6CggLb0ghc1BAtRSVNuaXWfSO8Y0 DTXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717631279; x=1718236079; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=x3Od+kHQiYw10KJUCEWfl19VRFpwdq31FvZ+w9rMBwk=; b=hBfSChgRpXlQSL0lpo2tnVgVHGiDQmYnZyurlriBFev2OdAl4BI8Deg3iYPkJh8d/I UoDa9IqlMilYxv/YPiKb+ENYBkNcHpHEMaCYkGCSSDICGDjmsbfQb/lGjcVh1U/af3Bg K9JhMRP2+QtWksv+djhAfDQBUE7OV2MtzkFIbebhcpdtgbw1oV/EUZ7Uue1+0/vjfEVx 0v3986Pw01qvZJkS6/DogeUNsrNwEtjaqQvd7WulSNOevVVL8JSYfY2XGBVTQam6jyu2 pmlItOPBX6ER7Z7Bb8uZgomxNvQnAXG1A7z/RCMcuwkpHsvq7EGcZkz9Aw3STqhC9fYf nutQ== X-Gm-Message-State: AOJu0YzvkqA/QbddzddEs1QvHJEe5stBbQm6gGVFzM2j040tfbCNf5Xc KVdb+y1Hu7VL5IsnHhfwgEOkMjwQxVldOuOT19GGmEUbhJGBpj0l8Mi7cw== X-Google-Smtp-Source: AGHT+IEPZBuKNU1xrSjK9yVdIw6j3QtCYitqYpnx/KjWPq6rXszr3B03IowdD5G0/uTcollRdnn2mw== X-Received: by 2002:a05:600c:3108:b0:421:2cb3:160 with SMTP id 5b1f17b1804b1-421562df35amr31929455e9.8.1717631278587; Wed, 05 Jun 2024 16:47:58 -0700 (PDT) Original-Received: from localhost (sgyl-45-b2-v4wan-166941-cust3717.vm6.cable.virginm.net. [82.37.190.134]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42158102ab8sm37741965e9.18.2024.06.05.16.47.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 16:47:57 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=abdo.haji.ali@gmail.com; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286644 Archived-At: If I open a frame with multiple tabs, and one of the tabs has a dedicated window, then kill the buffer with the dedicated window, the frame is deleted along with its tabs. I understand that this is the documented behaviour, however my expectation is that the tab should be deleted but the frame should stay when other tabs are available, similar to how the frame is not deleted if other windows are visible. The following code illustrates the issue: ,---- | (with-selected-frame (make-frame) | (tab-bar-mode) | (switch-to-buffer (generate-new-buffer "test")) | (tab-bar-new-tab) | (switch-to-buffer (generate-new-buffer "test2")) | (set-window-dedicated-p (selected-window) t) | ;;(kill-buffer) ;; Kill buffer manually to see the issue | ) `---- I am unable to test this on Emacs 30, but I checked the source code and `window--delete` in `window.el`, which is the function that I think should be changed, seems to do the same as in Emacs 29.1. -- Al