From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Al Haji-Ali Newsgroups: gmane.emacs.bugs Subject: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs Date: Sun, 16 Jun 2024 11:50:58 +0100 Message-ID: References: <86zfrx8ec0.fsf@mail.linkov.net> <8561a63a-66d3-44cd-872f-73d26af7edbe@gmx.at> <86msnw4qm4.fsf@mail.linkov.net> <86y17gej2x.fsf@gnu.org> <86y17gmxdg.fsf@mail.linkov.net> <868qzehxie.fsf@mail.linkov.net> <86msnu9fhg.fsf@gnu.org> <86zfruc7qh.fsf@mail.linkov.net> <86ikyi9e2l.fsf@gnu.org> <86o78ac6ny.fsf@mail.linkov.net> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@gmx.at> <86frtkeyzo.fsf@mail.linkov.net> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@gmx.at> <86r0d1iaxc.fsf@mail.linkov.net> <8634pfe735.fsf@mail.linkov.net> <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@gmx.at> <86frtdtlns.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21550"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 71386@debbugs.gnu.org To: martin rudalics , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 16 12:53:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sInVd-0005Uc-Qh for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jun 2024 12:53:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sInVP-0002VJ-29; Sun, 16 Jun 2024 06:53:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sInVN-0002V2-FX for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2024 06:53:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sInVN-0007En-7c for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2024 06:53:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sInVO-0005Lu-F4 for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2024 06:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Al Haji-Ali Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jun 2024 10:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71386 X-GNU-PR-Package: emacs Original-Received: via spool by 71386-submit@debbugs.gnu.org id=B71386.171853513320460 (code B ref 71386); Sun, 16 Jun 2024 10:53:02 +0000 Original-Received: (at 71386) by debbugs.gnu.org; 16 Jun 2024 10:52:13 +0000 Original-Received: from localhost ([127.0.0.1]:45926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sInUa-0005Js-Kl for submit@debbugs.gnu.org; Sun, 16 Jun 2024 06:52:13 -0400 Original-Received: from mail-wr1-f44.google.com ([209.85.221.44]:57819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sInUY-0005JV-UR for 71386@debbugs.gnu.org; Sun, 16 Jun 2024 06:52:11 -0400 Original-Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-35dc9cef36dso3241673f8f.3 for <71386@debbugs.gnu.org>; Sun, 16 Jun 2024 03:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718535064; x=1719139864; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=RAXAG/5vLd9YwUf7Y80TMRKtX0nbwclKw5ohxgB/0T4=; b=MAcYluCHbZ7eXcHj/EIqTSbidSgE8FLwMHPsbsOvjQZbOclTe89Qcwc+T9wMpxQDm5 79Fevhl8PsVXIeJVlUwhCkRG1Gk/andTVmpWjRwHLBxic8HWODYHf+L8UZpuUglvol0U BRmZTXRnsmKMo4YiP3h71SxrEzyA7nChGrrqGs2HXiBKA7JFq5KeQv4+aD+S/8zeBNhM l0Edqf2gsIlwrXkUr7eFYYlRKuu4htidyZoBkJr8IeY/zkLW1Us+0EsPx7Ph4uUhiXjO ftZtGFTfvWvhOiqn6+SskAl4OWw9j0iZ4bFTDoSpnVgKuTBQrs/wq84ib7MkXpLvnmY5 23bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718535064; x=1719139864; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RAXAG/5vLd9YwUf7Y80TMRKtX0nbwclKw5ohxgB/0T4=; b=qzzXBaYPp5wN5b6TcumAtvmxU0Pd1ltbxK41c11ITM0ZOShmVczYHGoigseZoWYHKi xtgWHnxX8EF5my1FlXj7ib/rNUeCJ19amhGRq5RLPYy2Fxgn8Ru0d4qbzK2cg14IBSWg liOBkem6Tx7ZBcmrS3oLh5dqPir3/TJ67R6dSN3dvwjnMMQftXMAUr4dHdrE1Df1EYEp gpZweEyZS8xjDImiMFZwYBpdf8mzrRGKB4Gkg2waPhMqzEm0hCu8cPbMpygH+eypCqzi eKqCFlwUm1H9FO6+5Y0osRRR3Pe3oLh+SClQ1TkJqzFt2qimlz8GwTLdqMxHKCsYWAva qACQ== X-Forwarded-Encrypted: i=1; AJvYcCXvBC+N7W+bZfnu8Wc3f/HGJo7jfAkEb8iodJtthiEqC4qINn8urCoLGb5Yc6nwkL1qPHKSMIglg/dZeHQ2S8DD4ngN9OI= X-Gm-Message-State: AOJu0YxcNGibFP48J/ATl7ZuXcNBDYuy2+kqx3LPWmrP2blR1y2weIPa jjUPXXcH8ooVxIQSrtgU2mRUml1z8tqqijuppM6GJad/oCEJMLsY X-Google-Smtp-Source: AGHT+IGg87WZaQWCRlRWSMT5eS/rDBS4j2rRXA75cSkM2hl+uEIU9lwBKWziOU57QhYg6m3sHdoMlQ== X-Received: by 2002:a05:6000:249:b0:35f:20eb:4831 with SMTP id ffacd0b85a97d-3607a75c664mr4384301f8f.38.1718535063447; Sun, 16 Jun 2024 03:51:03 -0700 (PDT) Original-Received: from localhost (sgyl-45-b2-v4wan-166941-cust3717.vm6.cable.virginm.net. [82.37.190.134]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3607509c883sm9280788f8f.29.2024.06.16.03.51.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Jun 2024 03:51:02 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287331 Archived-At: On 15/06/2024, martin rudalics wrote: > I'd still prefer a tab-bar specific option (like 'tab-bar-save-frame-p' > as mentioned earlier) for two reasons. > This is probably the right approach to minimize unattended consequences and it would definitely address the issue (which is, to reiterate, is that fundamentally, tabs behave like windows in many situations, but not when deleting buffers with dedicated windows -- having two windows prevents deleting a frame, but not having two tabs). I imagine Juri wanted to avoid having tab-specific code in `window.el` with the previous patch, hence the more generic hooks. The current patch of Juri should probably be protected with `featurep` or `fboundp` for tab-specific symbols. Also if the proposed change to `window-deletable-p` is adopted, then a grep on `window-deletable-p` also reveals that, for consistency, `delete-windows-on` and even `calendar-exit` in `calendar.el` should be modified similarly to `window--delete`. Best regards, -- Al