From: Arash Esbati <arash@gnu.org>
To: emacs-devel@gnu.org
Cc: Po Lu <luangruo@yahoo.com>
Subject: Re: master 6aa5068ac71 1/3: Improve treatment of touch screen input by rmc and its callers
Date: Wed, 19 Jun 2024 12:36:29 +0200 [thread overview]
Message-ID: <m2frt943te.fsf@macmutant.fritz.box> (raw)
In-Reply-To: <20240617094652.69EE0C1FB5F@vcs2.savannah.gnu.org> (Po Lu via Mailing list for Emacs changes's message of "Mon, 17 Jun 2024 05:46:52 -0400 (EDT)")
Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
> branch: master
> commit 6aa5068ac71cb1b8e46c299138f99fea44319146
> Author: Po Lu <luangruo@yahoo.com>
> Commit: Po Lu <luangruo@yahoo.com>
>
> Improve treatment of touch screen input by rmc and its callers
>
> * lisp/emacs-lisp/rmc.el (read-multiple-choice--short-answers):
> Run touch screen event translation on touch screen events
> received, and respond to pinch, tap and scrolling gestures.
>
> * lisp/net/nsm.el (nsm-query-user): Disable use-dialog-box in
> the details window.
>
> * lisp/touch-screen.el (touch-screen-translate-touch): Autoload.
> ---
> lisp/emacs-lisp/rmc.el | 106 +++++++++++++++++++++++++++++++++----------------
> lisp/net/nsm.el | 11 ++++-
> lisp/touch-screen.el | 1 +
> 3 files changed, 81 insertions(+), 37 deletions(-)
>
> diff --git a/lisp/emacs-lisp/rmc.el b/lisp/emacs-lisp/rmc.el
> index 378687c0326..883f8bf187f 100644
> --- a/lisp/emacs-lisp/rmc.el
> +++ b/lisp/emacs-lisp/rmc.el
>[...]
> + (cond
> + ((null command)) ; Read another event.
> + ((memq (car-safe command) '(mouse-1 mouse-2))
> + ;; Display the on-screen keyboard if a tap should be
> + ;; registered.
> + (frame-toggle-on-screen-keyboard (selected-frame)
> + nil))
> + ;; Respond to scroll and pinch events as if RMC were
> + ;; not in progress.
> + ((eq (car-safe command) 'touchscreen-scroll)
> + (funcall #'touch-screen-scroll command))
> + ((eq (car-safe command) 'touchscreen-pinch)
> + (funcall #'touch-screen-pinch command))
I think this part now generates:
In end of data:
rmc.el:245:32: Warning: the function ‘touch-screen-pinch’ is not known to be defined.
rmc.el:243:32: Warning: the function ‘touch-screen-scroll’ is not known to be defined.
This on macOS with Emacs from master (e6f4370c).
Best, Arash
next parent reply other threads:[~2024-06-19 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171861761168.16246.1990246088317606554@vcs2.savannah.gnu.org>
[not found] ` <20240617094652.69EE0C1FB5F@vcs2.savannah.gnu.org>
2024-06-19 10:36 ` Arash Esbati [this message]
2024-06-19 11:18 ` master 6aa5068ac71 1/3: Improve treatment of touch screen input by rmc and its callers Po Lu
2024-06-19 11:42 ` Arash Esbati
2024-06-27 7:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2frt943te.fsf@macmutant.fritz.box \
--to=arash@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.