From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: scratch/igc fe90d556834: Make glyphs ambiguous roots Date: Mon, 29 Jul 2024 09:21:07 +0200 Message-ID: References: <172218853212.17772.9043342656088870281@vcs2.savannah.gnu.org> <20240728174212.BDB66C41F13@vcs2.savannah.gnu.org> <87h6c8lnva.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8100"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Gerd =?utf-8?Q?M=C3=B6llmann?= , emacs-devel@gnu.org To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 29 09:21:54 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sYKhe-0001yJ-1x for ged-emacs-devel@m.gmane-mx.org; Mon, 29 Jul 2024 09:21:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sYKh0-0005S4-Mq; Mon, 29 Jul 2024 03:21:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sYKgy-0005R6-QS for emacs-devel@gnu.org; Mon, 29 Jul 2024 03:21:12 -0400 Original-Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sYKgx-0004L7-8S; Mon, 29 Jul 2024 03:21:12 -0400 Original-Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-4280bbdad3dso13962045e9.0; Mon, 29 Jul 2024 00:21:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722237669; x=1722842469; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=OMHBeRPfe4UYTYM8zmcSPBbd4l+DAAm/CErfMNUJcVA=; b=kd5pQzaALnFDgjYVu3KUFyfXRpWZYXaPJpeW/szMm59Ys0MQ8F0W/k2GYNA2zb7UMo 8b4bksZTKGhH5LAuhVov737GSS9wwcJTsiLHphwuJ5/SYuyMR6VD5mW+RzU2/XxBy1Y6 xqHEMA2fhPL3bRkvm+bEdciufesf4ORYdjwlCyUKDN8EHXxMJDtIl+F4gwn1BIqebC2Z UXu4lfsFC7Or5RO1AIequ/AYnDCGLlMVSyypyAZPmcM8sSkNbu5d7O0JCLsxwrUjqx4e gtMT0WRs7FoHl12jd/hHc05xT2KIB++69uaPYLH0Y+ZiNxyh7o6IiMMtOmip0fBnAUSd i7FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722237669; x=1722842469; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OMHBeRPfe4UYTYM8zmcSPBbd4l+DAAm/CErfMNUJcVA=; b=CN5fpQX6Ll3CYi07yv0mvzvNFlsSwOXNVI/2haT+K7l+C8ZoOfQZLGpZV7ChBlAqj+ QSSwwTh/Qu9egTmdWZgIhVUv7XtJG01tHLM4HIn8N5XUcBr8CseBHsQ4pfhXpx0XkNkk pE/0BFxHXCtCRGTp2SOwdAzGM/UiDLxg9gosz44YZ4hKBUQzLKX8Ro0LNoQcnmsBj3xI Lt2FbV5TWO5UReqU0FpTv32KXMug1BWrpVo2XGGNpCe8yUcbau/eit/z5yKjGK+t8eTN ygr5gSlidl213bINQegcJcDRoB0wMSkfXmCroLEs14KfKMS0zuriB2asGHw8rGE7kkNA tvMw== X-Forwarded-Encrypted: i=1; AJvYcCVNovTV5sr9nEi9EoPYCLJ3ZO8vy6ZgmlBTwHJ6SzXI++5zCiTZKKbFRmUggcStqwg0k1ZKc7ahvKF6rb+96UEKFmN4 X-Gm-Message-State: AOJu0Yx9E/ptrwFKJFEk719EE/teS9DbJBn+Wk1cPpq0BqfGyo/AiqNp EC4V7CJ5uk/s1sE295VKfjDlvYOqpqYvI88uAduGSQmceI77imGKsFbGuw== X-Google-Smtp-Source: AGHT+IGKM05vDteaTDO8rU0egDiDSgmHtLTah2gcQu7uorbab8fBHSOT57dN+3Kp6zJS3dzafht6Rw== X-Received: by 2002:a05:600c:3511:b0:428:3b5:816b with SMTP id 5b1f17b1804b1-42811d6e2ddmr46046035e9.3.1722237668523; Mon, 29 Jul 2024 00:21:08 -0700 (PDT) Original-Received: from pro2.fritz.box (p4fe3a35e.dip0.t-ipconnect.de. [79.227.163.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4281d805323sm20358955e9.41.2024.07.29.00.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jul 2024 00:21:08 -0700 (PDT) In-Reply-To: <87h6c8lnva.fsf@gmail.com> (Helmut Eller's message of "Mon, 29 Jul 2024 08:21:29 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=gerd.moellmann@gmail.com; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322187 Archived-At: Helmut Eller writes: > On Sun, Jul 28 2024, Gerd Moellmann wrote: > >> We cannot trace glyphs in fix_window because we don't have exclusive >> access to glyph_rows and glyphs. (An optimal solution would allocate >> glyphs from MPS, and change data structures in a way that everything >> needed (row->used, row->enabled_p) is available for the scanner.) > > I don't understand this. Glyph_rows aren't allocated in MPS-managed > memory so there are no memory barriers to worry about. True. > While fix_frame runs, all other threads are suspended. I don't think that is guranteed. but please check. Frames are not roots, so fix_frame can only assume exclusive access to the frame struct itself. Other threads can work on glyph_rows, glyphs and so on while fix_frame runs. > So why don't we have exclusive access? And why is it not a problem for > FRAME_FONT, FRAME_DISPLAY_INFO, etc? FRAME_X_DISPLAY_INFO has the same problem. It's just that I had the glyphs on my todo list. With frame->font I don't see a problem. Fonts are pvecs so we only have to fix the pointer to it, and fix_font should do the rest. BTW, unrelated. Do you observe problems in clear_face_cache? I'm getting EXC_BAD_ACCESS from accessing face->font->driver, sometimes, as if the face hadn't been scanned. But the face looks okay, as far as the face_cache is concerned. Happens since I change the default font to JetBrains Mono. (And happened before that change above.)