From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: "Final" version of tty child frames Date: Thu, 09 Jan 2025 11:45:45 +0100 Message-ID: References: <86wmi0g0x6.fsf@gnu.org> <11a86987cce9fe0a257c3fa58703dc33@finder.org> <86wmgl6jzv.fsf@gnu.org> <092cb755eee3a9b5e06d15c0b07e90b1@finder.org> <276414b03c24964aaeb9e43e8dba5e77@finder.org> <19ca4d76-cd63-4abe-8c8d-ca85c4d15ef2@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22040"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jared Finder , Eli Zaretskii , emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 09 11:46:45 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tVq3p-0005bb-EB for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Jan 2025 11:46:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVq2y-0004IW-3X; Thu, 09 Jan 2025 05:45:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVq2w-0004IM-Q6 for emacs-devel@gnu.org; Thu, 09 Jan 2025 05:45:50 -0500 Original-Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tVq2v-0006xX-6r; Thu, 09 Jan 2025 05:45:50 -0500 Original-Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-385e1fcb0e1so392581f8f.2; Thu, 09 Jan 2025 02:45:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736419547; x=1737024347; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=lJSlfWBd0Lt5KU/EDq1UbXXaaAnWvP8WSgp4Ew1ChSQ=; b=a2hTFZoXQTCDjIjh/+GNFaZ26gAqirOSxZePvFsGxtX/Wm6UtDV8qu/X1S0mat2YbG pOWmKeqTR6fbwNzk4U21n/nl17MSkyV/gwj1dS4GrH3gWkcn1c5LHzBLuIouz1XnqJqD kkEiS4E1dNwd+dgWQFsA/P93LKjfgGSdaJzfDvLSLY1T0udn9YH5m+E6W5OOUaQeUGOP 97WaZC91OGV5r20Sw7XxNo46jdpufCfRCUEhDyRDV9B0YitasuzeRoSORexN5eNEwM5a Hs42ArhrwL9l+eX33kR1fIF1cGbXgrV8j7fCvXT0+dJkPg1VsFoEsF5tUzC9lLuhYtj3 mvvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736419547; x=1737024347; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lJSlfWBd0Lt5KU/EDq1UbXXaaAnWvP8WSgp4Ew1ChSQ=; b=GL/opQZwff/zLHGCY0S8Fk8FUvi2iofa5iwDaC8fOp5lYAI+n9Tmd1LwKxv3q747Sy RtgqGZUchGePWas67VkQGmdN8z/3Hx8ZmClJAUAAYApbRSz6wcR5jOuFBZSUz3UgjBoD TFDjXgkXon0zsbXUH3vVgpddmw/T//F1+f1bOuX9Vn8ISm2zSuL12W9zAKfG2Qsg1PeJ s9k3c+tY63a+dvjjH40Y8KRO9GGjxOv2GbYqhDb9dmMfYJD4seZd6G9QimhZYwEIGRcY LyxAkVN3NSF4E51pzbQWEv9CqazmRSx83UbVC3xV43FH6txwwXFu/RG8MnetyfJbQKo1 nD7A== X-Forwarded-Encrypted: i=1; AJvYcCWiczb9mQY62YWJ+ih4xr80n+4dm9rLDr/BiJTyZjLF46TSIuyRi+73PujHFn0fayiz9E/n@gnu.org, AJvYcCXx+ZQcS3TnPGiqFomwE/j9h94lLNQHjky9IU79cvalj2dLbCjdDkBfv3ChjLiN+CqF6f0Xah9XNnkXmoQ=@gnu.org X-Gm-Message-State: AOJu0YxhiMnxS/M4XPjoNLuQBMk/kV7+KnwI+vqPERgWmdyM8ZMdxKlw xpplMnvZK/mhwvZIO42Ad5ZjkhH1pBRLAehPUt2un+WswbvK3MC8XtJg0g== X-Gm-Gg: ASbGnctSBLn4Wq56nC7UKnGiDSK/focy17rboR04Y8aAwKomffhFCygawtTLKXOf/O4 5ORy6SAu4JGI3NYX1p3FAF6LPLFEf6N4iRJhw05qAKRyk7ZUzOYiO+1hDip/X62A96GYQ8AMpPR V0hQb4BaRp3IM4RGzFv1YzxPbvIRUoGDBT3Mf53SNnVCYogsPxoY9WoFjS0a4y22JTR4odZ0p5g UFUZ9rmfLoVAx589aZ3ojb7WArrnB8z0Ulfdn/LECrd2+CYKHUzJ3xVTiWhDurVJpKVDMdA23rv SgeRTtUNqvR7+FMC454+de2eW4RJGIFGi+w9UNzpy42lvAcwUccB8GRONFpHYJvp0w== X-Google-Smtp-Source: AGHT+IGw+WkirgRjObl2R4O3Aghz7XGugJwefXwFr8ph7hh/OgUjS7OLIDq0dwynoEkJgWcEHmBY9A== X-Received: by 2002:a05:6000:18a8:b0:386:3403:7b63 with SMTP id ffacd0b85a97d-38a8733a319mr5537692f8f.36.1736419546297; Thu, 09 Jan 2025 02:45:46 -0800 (PST) Original-Received: from pro2 (p200300e0b7182e00ad06de2bb2fec9f1.dip0.t-ipconnect.de. [2003:e0:b718:2e00:ad06:de2b:b2fe:c9f1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e4b83a1sm1460975f8f.75.2025.01.09.02.45.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2025 02:45:45 -0800 (PST) In-Reply-To: (martin rudalics's message of "Thu, 9 Jan 2025 11:24:08 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=gerd.moellmann@gmail.com; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327816 Archived-At: martin rudalics writes: >> I've not yet understood where the third frame is created. Probably have to >> see this in the debugger to get into this again. > > Without really checking it must be here > > /* Use default-minibuffer-frame if possible. */ > if (!FRAMEP (KVAR (kb, Vdefault_minibuffer_frame)) > || ! FRAME_LIVE_P (XFRAME (KVAR (kb, Vdefault_minibuffer_frame)))) > { > Lisp_Object initial_frame; > > /* If there's no minibuffer frame to use, create one. */ > initial_frame = call1 (Qmake_initial_minibuffer_frame, > display); > kset_default_minibuffer_frame (kb, initial_frame); > } > > 'default-minibuffer-frame' on ttys is nil, only 'x-create-frame' and the > like set it AFAICT. Even if it were some frame, it might be of no use: > On a tty the mini window to use _must_ be on the visible frame. So > Emacs makes a new initial_frame and uses that frame's mini window. But > the child frame gets another root frame and sooner or later this will > crash anyway. The attached patch fixes it here. That would have taken me some time to understand :-). > martin (who can still post a bug report if you think it's needed) If that solves everything you reported previously, no bug needed. LGTM. (Sorry, I'm a bit forgetful when I'm doing something else, and a todo list doesn't really help, it seems to grow only.) LGTM, please apply.