Wrong extra argument to make-obsolete-overload in semantic/tag-file.el

Wrong extra argument to make-obsolete-overload in semantic/tag-file.el

[Sascha Wilde]

[-- Attachment #1: Type: text/plain, Size: 147 bytes --]

Hi *,

on Sun Oct 25 Stefan added a big bunch of `when' args to various
function calls in the semantic code.  This included the following
change:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 642 bytes --]

diff -r 580466ce1a98 -r 2cc681b53a29 lisp/cedet/semantic/tag-file.el
--- a/lisp/cedet/semantic/tag-file.el   Sun Oct 25 02:07:45 2009 +0000
+++ b/lisp/cedet/semantic/tag-file.el   Sun Oct 25 02:55:27 2009 +0000
@@ -103,7 +103,7 @@
   )
 
 (make-obsolete-overload 'semantic-find-nonterminal
-                        'semantic-go-to-tag)
+                        'semantic-go-to-tag "23.2")
 
 ;;; Dependencies
 ;;
@@ -177,7 +177,7 @@
       )))
 
 (make-obsolete-overload 'semantic-find-dependency
-                        'semantic-dependency-tag-file)
+                        'semantic-dependency-tag-file "23.2")
 
 ;;; PROTOTYPE FILE
 ;;

[-- Attachment #3: Type: text/plain, Size: 349 bytes --]


which is wrong as the function make-obsolete-overload does only take two
arguments and no third `when' arg.

Simply reverting this change fixed semantic for me.

cheers
sascha
-- 
Sascha Wilde
    "Computers are good at following instructions,
     but not at reading your mind."
    D. E. Knuth, The TeXbook, Addison-Wesley 1984, 1986, 1996, p. 9

Re: Wrong extra argument to make-obsolete-overload in semantic/tag-file.el

[Stefan Monnier]

> on Sun Oct 25 Stefan added a big bunch of `when' args to various
> function calls in the semantic code.  This included the following
> change:

Thanks, indeed I forgot to add the `when' arg to
make-obsolete-overload.  Should be fixed now.


        Stefan

Re: Wrong extra argument to make-obsolete-overload in semantic/tag-file.el

[Sascha Wilde]

Stefan Monnier <monnier@iro.umontreal.ca> wrote:

>> on Sun Oct 25 Stefan added a big bunch of `when' args to various
>> function calls in the semantic code.  This included the following
>> change:
>
> Thanks, indeed I forgot to add the `when' arg to
> make-obsolete-overload.  Should be fixed now.

I can confirm, that it works now.

cheers
sascha
-- 
Sascha Wilde
"C++ : an octopus made by nailing extra legs onto a dog"