bug#5921: 23.1; OSX: Emacs 23.1.95 pretest does not compile

bug#5921: 23.1; OSX: Emacs 23.1.95 pretest does not compile

[Markus Triska]

On OSX 10.4 with macports installed, I used:

    $./configure CFLAGS=-I/opt/local/include LDFLAGS=-L/opt/local/lib

and Emacs fails to compile with:

   xsettings.c: In function 'parse_xft_settings':
   xsettings.c:323: error: 'FC_HINT_NONE' undeclared (first use in this function)
   xsettings.c:323: error: (Each undeclared identifier is reported only once
   xsettings.c:323: error: for each function it appears in.)
   xsettings.c:325: error: 'FC_HINT_SLIGHT' undeclared (first use in this function)
   xsettings.c:327: error: 'FC_HINT_MEDIUM' undeclared (first use in this function)
   xsettings.c:329: error: 'FC_HINT_FULL' undeclared (first use in this function)
   xsettings.c: In function 'apply_xft_settings':
   xsettings.c:424: error: 'FC_HINT_STYLE' undeclared (first use in this function)

apparently because (old) /usr/X11R6/include include files are still
picked up with priority by the eventually used flags:

   gcc -I/sw/include -L/sw/lib -c -Demacs -DHAVE_CONFIG_H -I.
   -I/Users/mt/emacs-23.1.95/src -I/usr/X11R6/include
   -I/opt/local/include/gtk-2.0 -I/opt/local/lib/gtk-2.0/include
   -I/opt/local/include/atk-1.0 -I/opt/local/include/cairo
   -I/opt/local/include/pango-1.0 -I/opt/local/include/glib-2.0
   -I/opt/local/lib/glib-2.0/include -I/opt/local/include
   -I/opt/local/include/pixman-1 -I/opt/local/include/freetype2
   -I/opt/local/include/libpng12 -I/opt/local/include
   -I/opt/local/include/freetype2 -Dtemacs -I/opt/local/include/librsvg-2
   -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include
   -I/opt/local/include -I/opt/local/include/gtk-2.0
   -I/opt/local/include/cairo -I/opt/local/include/pixman-1
   -I/opt/local/include/freetype2 -I/opt/local/include/libpng12
   -I/opt/local/include/dbus-1.0 -I/opt/local/lib/dbus-1.0/include
   -DORBIT2=1 -D_REENTRANT -I/opt/local/include/gconf/2
   -I/opt/local/include/orbit-2.0 -I/opt/local/include/dbus-1.0
   -I/opt/local/lib/dbus-1.0/include -I/opt/local/include/glib-2.0
   -I/opt/local/lib/glib-2.0/include -I/opt/local/include
   -I/opt/local/include -MMD -MF deps/xsettings.d xsettings.c

When I reorder ALL_CFLAGS in src/Makefile to place
-I/usr/X11R6/include at the end, Emacs compiles.

bug#5921: 23.1; OSX: Emacs 23.1.95 pretest does not compile

[Jan Djärv]

Can you send the config.log file?

	Jan D.

Markus Triska skrev:
> On OSX 10.4 with macports installed, I used:
> 
>     $./configure CFLAGS=-I/opt/local/include LDFLAGS=-L/opt/local/lib
> 
> and Emacs fails to compile with:
> 
>    xsettings.c: In function 'parse_xft_settings':
>    xsettings.c:323: error: 'FC_HINT_NONE' undeclared (first use in this function)
>    xsettings.c:323: error: (Each undeclared identifier is reported only once
>    xsettings.c:323: error: for each function it appears in.)
>    xsettings.c:325: error: 'FC_HINT_SLIGHT' undeclared (first use in this function)
>    xsettings.c:327: error: 'FC_HINT_MEDIUM' undeclared (first use in this function)
>    xsettings.c:329: error: 'FC_HINT_FULL' undeclared (first use in this function)
>    xsettings.c: In function 'apply_xft_settings':
>    xsettings.c:424: error: 'FC_HINT_STYLE' undeclared (first use in this function)
> 
> apparently because (old) /usr/X11R6/include include files are still
> picked up with priority by the eventually used flags:
> 
>    gcc -I/sw/include -L/sw/lib -c -Demacs -DHAVE_CONFIG_H -I.
>    -I/Users/mt/emacs-23.1.95/src -I/usr/X11R6/include
>    -I/opt/local/include/gtk-2.0 -I/opt/local/lib/gtk-2.0/include
>    -I/opt/local/include/atk-1.0 -I/opt/local/include/cairo
>    -I/opt/local/include/pango-1.0 -I/opt/local/include/glib-2.0
>    -I/opt/local/lib/glib-2.0/include -I/opt/local/include
>    -I/opt/local/include/pixman-1 -I/opt/local/include/freetype2
>    -I/opt/local/include/libpng12 -I/opt/local/include
>    -I/opt/local/include/freetype2 -Dtemacs -I/opt/local/include/librsvg-2
>    -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include
>    -I/opt/local/include -I/opt/local/include/gtk-2.0
>    -I/opt/local/include/cairo -I/opt/local/include/pixman-1
>    -I/opt/local/include/freetype2 -I/opt/local/include/libpng12
>    -I/opt/local/include/dbus-1.0 -I/opt/local/lib/dbus-1.0/include
>    -DORBIT2=1 -D_REENTRANT -I/opt/local/include/gconf/2
>    -I/opt/local/include/orbit-2.0 -I/opt/local/include/dbus-1.0
>    -I/opt/local/lib/dbus-1.0/include -I/opt/local/include/glib-2.0
>    -I/opt/local/lib/glib-2.0/include -I/opt/local/include
>    -I/opt/local/include -MMD -MF deps/xsettings.d xsettings.c
> 
> When I reorder ALL_CFLAGS in src/Makefile to place
> -I/usr/X11R6/include at the end, Emacs compiles.
> 
> 
> 
> 

bug#5921: 23.1; OSX: Emacs 23.1.95 pretest does not compile

[Chong Yidong]

> (old) /usr/X11R6/include include files are still picked up with
> priority by the eventually used flags

Does this patch DTRT?

=== modified file 'src/Makefile.in'
*** src/Makefile.in	2010-04-01 23:08:14 +0000
--- src/Makefile.in	2010-04-10 16:11:26 +0000
***************
*** 269,275 ****
  
  /* C_SWITCH_X_SITE must come before C_SWITCH_X_MACHINE and C_SWITCH_X_SYSTEM
     since it may have -I options that should override those two.  */
! ALL_CFLAGS=-Demacs -DHAVE_CONFIG_H $(MYCPPFLAGS) -I. -I${srcdir} C_SWITCH_MACHINE C_SWITCH_SYSTEM C_SWITCH_X_SITE C_SWITCH_X_MACHINE C_SWITCH_X_SYSTEM C_SWITCH_SYSTEM_TEMACS ${CFLAGS_SOUND} ${RSVG_CFLAGS} ${DBUS_CFLAGS} ${GCONF_CFLAGS} ${CFLAGS} @FREETYPE_CFLAGS@ @FONTCONFIG_CFLAGS@ @LIBOTF_CFLAGS@ @M17N_FLT_CFLAGS@ ${DEPFLAGS}
  ALL_OBJC_CFLAGS=$(ALL_CFLAGS) @GNU_OBJC_CFLAGS@
  
  .SUFFIXES: .m
--- 269,275 ----
  
  /* C_SWITCH_X_SITE must come before C_SWITCH_X_MACHINE and C_SWITCH_X_SYSTEM
     since it may have -I options that should override those two.  */
! ALL_CFLAGS=-Demacs -DHAVE_CONFIG_H $(MYCPPFLAGS) -I. -I${srcdir} C_SWITCH_MACHINE C_SWITCH_SYSTEM C_SWITCH_SYSTEM_TEMACS ${CFLAGS_SOUND} ${RSVG_CFLAGS} ${DBUS_CFLAGS} ${GCONF_CFLAGS} ${CFLAGS} C_SWITCH_X_SITE C_SWITCH_X_MACHINE C_SWITCH_X_SYSTEM @FREETYPE_CFLAGS@ @FONTCONFIG_CFLAGS@ @LIBOTF_CFLAGS@ @M17N_FLT_CFLAGS@ ${DEPFLAGS}
  ALL_OBJC_CFLAGS=$(ALL_CFLAGS) @GNU_OBJC_CFLAGS@
  
  .SUFFIXES: .m

bug#5921: 23.1; OSX: Emacs 23.1.95 pretest does not compile

[Markus Triska]

Chong Yidong <cyd@stupidchicken.com> writes:

> Does this patch DTRT?

It fixes the reported issue (i.e., Emacs now compiles), thank you!

However, from "otool -L emacs", I see that it still gives priority to
libraries from "/sw/lib/", although I again specifically tried to give
priority to those in /opt/local/lib via (CFLAGS and) LDFLAGS.

bug#5921: 23.1; OSX: Emacs 23.1.95 pretest does not compile

[Glenn Morris]

Markus Triska wrote:

> However, from "otool -L emacs", I see that it still gives priority to
> libraries from "/sw/lib/", although I again specifically tried to give
> priority to those in /opt/local/lib via (CFLAGS and) LDFLAGS.

This is probably a duplicate of

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5252

bug#5921: 23.1; OSX: Emacs 23.1.95 pretest does not compile

[Dan Nicolaescu]

Markus Triska <markus.triska@gmx.at> writes:

> On OSX 10.4 with macports installed, I used:
>
>     $./configure CFLAGS=-I/opt/local/include LDFLAGS=-L/opt/local/lib

Have you tries using the --x-includes, -x-libraries, --includedir, --libdir flags?

Using them is better than fiddling with the CFLAGS because they place
various items in the correct order on the command line (at least they
used to, it's doubtfull that these flags are used much these days, so
they might have bitrotted...)


>
> and Emacs fails to compile with:
>
>    xsettings.c: In function 'parse_xft_settings':
>    xsettings.c:323: error: 'FC_HINT_NONE' undeclared (first use in this function)
>    xsettings.c:323: error: (Each undeclared identifier is reported only once
>    xsettings.c:323: error: for each function it appears in.)
>    xsettings.c:325: error: 'FC_HINT_SLIGHT' undeclared (first use in this function)
>    xsettings.c:327: error: 'FC_HINT_MEDIUM' undeclared (first use in this function)
>    xsettings.c:329: error: 'FC_HINT_FULL' undeclared (first use in this function)
>    xsettings.c: In function 'apply_xft_settings':
>    xsettings.c:424: error: 'FC_HINT_STYLE' undeclared (first use in this function)
>
> apparently because (old) /usr/X11R6/include include files are still
> picked up with priority by the eventually used flags:
>
>    gcc -I/sw/include -L/sw/lib -c -Demacs -DHAVE_CONFIG_H -I.
>    -I/Users/mt/emacs-23.1.95/src -I/usr/X11R6/include
>    -I/opt/local/include/gtk-2.0 -I/opt/local/lib/gtk-2.0/include
>    -I/opt/local/include/atk-1.0 -I/opt/local/include/cairo
>    -I/opt/local/include/pango-1.0 -I/opt/local/include/glib-2.0
>    -I/opt/local/lib/glib-2.0/include -I/opt/local/include
>    -I/opt/local/include/pixman-1 -I/opt/local/include/freetype2
>    -I/opt/local/include/libpng12 -I/opt/local/include
>    -I/opt/local/include/freetype2 -Dtemacs -I/opt/local/include/librsvg-2
>    -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include
>    -I/opt/local/include -I/opt/local/include/gtk-2.0
>    -I/opt/local/include/cairo -I/opt/local/include/pixman-1
>    -I/opt/local/include/freetype2 -I/opt/local/include/libpng12
>    -I/opt/local/include/dbus-1.0 -I/opt/local/lib/dbus-1.0/include
>    -DORBIT2=1 -D_REENTRANT -I/opt/local/include/gconf/2
>    -I/opt/local/include/orbit-2.0 -I/opt/local/include/dbus-1.0
>    -I/opt/local/lib/dbus-1.0/include -I/opt/local/include/glib-2.0
>    -I/opt/local/lib/glib-2.0/include -I/opt/local/include
>    -I/opt/local/include -MMD -MF deps/xsettings.d xsettings.c
>
> When I reorder ALL_CFLAGS in src/Makefile to place
> -I/usr/X11R6/include at the end, Emacs compiles.