From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alp Aker Newsgroups: gmane.emacs.bugs Subject: bug#8863: 23.3; Strikethrough won't display on MacOS Date: Sat, 02 Jul 2011 01:53:28 -0400 Message-ID: References: <87aade24li.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1309586077 3689 80.91.229.12 (2 Jul 2011 05:54:37 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 2 Jul 2011 05:54:37 +0000 (UTC) To: 8863@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 02 07:54:34 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QctA1-0003Qg-P3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jul 2011 07:54:33 +0200 Original-Received: from localhost ([::1]:50413 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QctA1-00087f-81 for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jul 2011 01:54:33 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:38081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qct9Y-00084o-S3 for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2011 01:54:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qct9X-0001tN-Cs for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2011 01:54:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52465) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qct9X-0001tF-3P for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2011 01:54:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Qct9W-00074o-7u; Sat, 02 Jul 2011 01:54:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Alp Aker Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Jul 2011 05:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8863 X-GNU-PR-Package: emacs,ns X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.130958603727191 (code B ref -1); Sat, 02 Jul 2011 05:54:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Jul 2011 05:53:57 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qct9R-00074W-1F for submit@debbugs.gnu.org; Sat, 02 Jul 2011 01:53:57 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qct9O-00074I-EY for submit@debbugs.gnu.org; Sat, 02 Jul 2011 01:53:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qct9H-0001s3-Sz for submit@debbugs.gnu.org; Sat, 02 Jul 2011 01:53:48 -0400 Original-Received: from lists.gnu.org ([140.186.70.17]:43449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qct9H-0001rz-KX for submit@debbugs.gnu.org; Sat, 02 Jul 2011 01:53:47 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:38016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qct9F-00082a-UP for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2011 01:53:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qct9E-0001rY-DI for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2011 01:53:45 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:36313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qct9D-0001rQ-U5 for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2011 01:53:44 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Qct9C-00038v-2T for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2011 07:53:42 +0200 Original-Received: from pool-72-95-250-103.pitbpa.east.verizon.net ([72.95.250.103]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 02 Jul 2011 07:53:42 +0200 Original-Received: from alp.tekin.aker by pool-72-95-250-103.pitbpa.east.verizon.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 02 Jul 2011 07:53:42 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 24 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: pool-72-95-250-103.pitbpa.east.verizon.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (darwin) Cancel-Lock: sha1:eDrFWcrN/yUK/ygMSGtdO6dhV+s= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 02 Jul 2011 01:54:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:47733 Archived-At: > Dave Abrahams writes: > > No, but the enclosed 2 patches, together, seem to. Would somebody apply > these, please? I mentioned some problems with Chong Yidong's suggestion, one of which still applies here: this patch won't work with stretch or image glyphs (so, e.g., it won't do strike-through on tab characters). Also (something I didn't mention in the earlier post), this uses the same Quartz drawing API as the existing code for underlining, and so suffers from a problem that exists in that case as well; this kind of line-drawing is subject to anti-aliasing effects that will cause lines whose requested thickness is 1 pixel to appear thicker than that (specifically, the line-drawing commands in question stroke lines so that they're centered on their specified paths, and so a line whose thickness is an odd number of pixels is dithered, making it look thicker). Last week I promised a patch that would implement strike-through and overline face attributes and address problems with the existing implementation of underlining. I'll try to finish that up and post it tomorrow.