From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#2179: 23.0.60; define-key vs define-key-after key syntax Date: Sun, 11 Sep 2011 23:48:49 +0200 Message-ID: References: <4987F2D6.2010900@math.utexas.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1315777796 20256 80.91.229.12 (11 Sep 2011 21:49:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 11 Sep 2011 21:49:56 +0000 (UTC) Cc: 2179@debbugs.gnu.org, Gerard Brunick To: Lars Magne Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 11 23:49:51 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R2ruR-0007TH-JD for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Sep 2011 23:49:51 +0200 Original-Received: from localhost ([::1]:47474 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R2ruR-0003iT-4u for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Sep 2011 17:49:51 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:53386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R2ruO-0003iD-1h for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2011 17:49:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R2ruK-0005Ba-GT for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2011 17:49:47 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R2ruK-0005BU-Dh for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2011 17:49:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R2ryT-0005uS-GG; Sun, 11 Sep 2011 17:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Sep 2011 21:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 2179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 2179-submit@debbugs.gnu.org id=B2179.131577799522659 (code B ref 2179); Sun, 11 Sep 2011 21:54:01 +0000 Original-Received: (at 2179) by debbugs.gnu.org; 11 Sep 2011 21:53:15 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R2rxj-0005tQ-Ei for submit@debbugs.gnu.org; Sun, 11 Sep 2011 17:53:15 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R2rxh-0005tJ-Sy for 2179@debbugs.gnu.org; Sun, 11 Sep 2011 17:53:14 -0400 Original-Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id B5211188A18C; Sun, 11 Sep 2011 23:48:53 +0200 (CEST) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.8.164]) by mail.m-online.net (Postfix) with ESMTP id E36661C00181; Sun, 11 Sep 2011 23:48:53 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.8.164]) (amavisd-new, port 10024) with ESMTP id VWbFSksRJM1v; Sun, 11 Sep 2011 23:48:50 +0200 (CEST) Original-Received: from igel.home (ppp-88-217-122-177.dynamic.mnet-online.de [88.217.122.177]) by mail.mnet-online.de (Postfix) with ESMTP; Sun, 11 Sep 2011 23:48:50 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 501) id B2CB8CA296; Sun, 11 Sep 2011 23:48:49 +0200 (CEST) X-Yow: FUN is never having to say you're SUSHI!! In-Reply-To: (Lars Magne Ingebrigtsen's message of "Sun, 11 Sep 2011 23:18:20 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 11 Sep 2011 17:54:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:51007 Archived-At: Lars Magne Ingebrigtsen writes: > Gerard Brunick writes: > >> (define-key my-map [(control l)] 'do-something) >> >> works as expected, but >> >> (define-key-after my-map [(control l)] 'do-something) >> >> does not. The reason is that define-key does a lot of work to allow >> for a wide range of key syntaxes, but define-key-after just does: >> >> (setq key >> (if (<= (length key) 1) (aref key 0) ... >> >> and (control l) must get mapped to ?\C-l = 12 to be useful in a keymap. > > Yes, you'd expect both key's to allow the same syntax. However, as far > as I can see, all the magic to translate from the `define-key' key > syntax is inside that C function, so that would have to be refactored > out first. I think. Since define-key-after is only useful for menu-bar bindings which don't use characters in keys this doesn't look like a serious restriction. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."