From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "John Wiegley" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add shell-quasiquote. Date: Sun, 18 Oct 2015 10:48:39 -0700 Organization: New Artisans LLC Message-ID: References: <87si59wj42.fsf@T420.taylan> <83eggt4esi.fsf@gnu.org> <87fv19wh7b.fsf@T420.taylan> <83bnbx4d7e.fsf@gnu.org> <87twppuzfu.fsf@T420.taylan> <83a8rh48if.fsf@gnu.org> <87io65utmt.fsf@T420.taylan> <5622B3C6.4030208@cs.ucla.edu> <871tctuqw5.fsf@T420.taylan> <5622C340.1050001@cs.ucla.edu> <87lhb1t9sm.fsf@T420.taylan> <56230695.4070501@cs.ucla.edu> <83y4f0i33y.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1445191328 29394 80.91.229.3 (18 Oct 2015 18:02:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 18 Oct 2015 18:02:08 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 18 20:02:03 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZnsHS-0001N2-8B for ged-emacs-devel@m.gmane.org; Sun, 18 Oct 2015 20:02:02 +0200 Original-Received: from localhost ([::1]:34982 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zns5o-00022M-Mw for ged-emacs-devel@m.gmane.org; Sun, 18 Oct 2015 13:50:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zns4f-00020x-Hb for emacs-devel@gnu.org; Sun, 18 Oct 2015 13:48:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zns4b-0004c7-SQ for emacs-devel@gnu.org; Sun, 18 Oct 2015 13:48:49 -0400 Original-Received: from mail-pa0-x232.google.com ([2607:f8b0:400e:c03::232]:33506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zns4b-0004c3-NF for emacs-devel@gnu.org; Sun, 18 Oct 2015 13:48:45 -0400 Original-Received: by pabrc13 with SMTP id rc13so167120667pab.0 for ; Sun, 18 Oct 2015 10:48:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:in-reply-to:date:organization:message-id :references:user-agent:mail-followup-to:mime-version:content-type; bh=MZOKsUFwNI/IBLxDRZl+Z6bHr+4G3r4r2m6ej/jkJJo=; b=ujx+YffYE1MGFbxssZTLI6zPJEdI3Ol4EXUqqvifAvXZYfzLrRraTc0Z+4Gb0cdLOJ yIp/4LRH1XwZfLkgKOdQHfDcS0B+ueK+RNoZyNDsiuppIyAqk0bfGq1q5gRyy8xE3VEy wwQFehdlDM/LYE3ko7DiMEdnDX+isIAzwYP/bAGB3zDRg03UQq9Fn/PGIv8sPT0Ransb JNxs02g/59shZvxQx+BQAFvd8OdSOBc9rdl2yq17BNBpkMQh1EU6aEU2ZFtM/LVS5rQK V3IAt0EJKX9KfB6ws4F73VI5INI/FQB3jrAU1h7FE/txELbLcwzGuxpRcpz3319J3PoC xZWw== X-Received: by 10.66.121.195 with SMTP id lm3mr29749708pab.84.1445190525239; Sun, 18 Oct 2015 10:48:45 -0700 (PDT) Original-Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id be3sm31887136pbc.88.2015.10.18.10.48.43 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 18 Oct 2015 10:48:44 -0700 (PDT) Original-Received: by Vulcan.local (Postfix, from userid 501) id E169EF45D04F; Sun, 18 Oct 2015 10:48:42 -0700 (PDT) In-Reply-To: <83y4f0i33y.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 18 Oct 2015 18:54:41 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) Mail-Followup-To: emacs-devel@gnu.org X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191988 Archived-At: >>>>> Eli Zaretskii writes: >> I am not a fan of non-POSIX shells. They are a hassle to deal with and can >> cause significant problems in Emacs maintenance. In areas where they are a >> significant problem, we don't need to support them. But this particular >> instance is not a significant problem. Emacs already has a portable, >> tested, easy-to-use function to quote shell arguments, and there's good >> reason to use it here. > I completely agree with everything Paul wrote here. Taylan, I hope these comments will be viewed as an effort to be constructive, rather than dismissive of your work or effort in any way. We have good reason to suspect functions that might duplicate multiple decades of prior art. Until now, shell quoting has been working nicely, so you can imagine we are a touch skeptical of the need to rewrite it at this stage. However, if you can produce some test cases that show a deficiency in shell-quote-argument, you'll have done several useful things for us: 1. Produced a test case covering an untested area; 2. Helped us understand a deficiency in code we had completely trusted; 3. Given us an opportunity to fix that code, benefiting all its users; 4. Allowed us to provide you with a working shell-quote-argument, so you needn't waste further time at that level. This is our hope; it is not meant to discourage you, or emphasize who is wrong about what details. Your energy and enthusiasm are of great value. John