From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Christian Lynbech Newsgroups: gmane.emacs.devel Subject: Issue in src/xfns.c Date: Tue, 14 Jun 2016 20:02:45 +0200 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1465933793 23894 80.91.229.3 (14 Jun 2016 19:49:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 14 Jun 2016 19:49:53 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 14 21:49:41 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bCu7L-0000Vn-Ez for ged-emacs-devel@m.gmane.org; Tue, 14 Jun 2016 21:35:19 +0200 Original-Received: from localhost ([::1]:37707 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCu7K-0000X8-ID for ged-emacs-devel@m.gmane.org; Tue, 14 Jun 2016 15:35:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCu45-00076k-8r for emacs-devel@gnu.org; Tue, 14 Jun 2016 15:31:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCu3z-00031q-Mo for emacs-devel@gnu.org; Tue, 14 Jun 2016 15:31:56 -0400 Original-Received: from [78.143.111.234] (port=59768 helo=Christians-iMac.local) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCu3z-00031C-F7 for emacs-devel@gnu.org; Tue, 14 Jun 2016 15:31:51 -0400 Original-Received: by Christians-iMac.local (Postfix, from userid 501) id 9FAA9489F253; Tue, 14 Jun 2016 20:02:45 +0200 (CEST) User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (darwin) X-detected-operating-system: by eggs.gnu.org: Mac OS X [generic] X-Received-From: 78.143.111.234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204363 Archived-At: I am not entirely sure what the intention was, but I think there is a small issue in xfns.c in relation to the RANDR13_LIBRARY macro. It is used in two places, one where it uses #if and another that uses #ifdef, the latter of which I think should have been a #if. At least it failed to compile for me on a rather old linux system with a setup I know onbly a little about. The define that introduces RANDR13_LIBRARY is a boolean expression so RANDR13_LIBRARY is always defined. As far as I can see this is still present in the git repository on the master branch. An attempt of a patch is given below. Index: xfns.c =================================================================== --- xfns.c (revision 7708) +++ xfns.c (working copy) @@ -4286,7 +4286,7 @@ n_monitors = resources->noutput; monitors = xzalloc (n_monitors * sizeof *monitors); -#ifdef RANDR13_LIBRARY +#if RANDR13_LIBRARY if (randr13_avail) pxid = XRRGetOutputPrimary (dpy, dpyinfo->root_window); #endif ------------------------+----------------------------------------------------- Christian Lynbech | christian #\@ defun #\. dk ------------------------+----------------------------------------------------- Hit the philistines three times over the head with the Elisp reference manual. - petonic@hal.com (Michael A. Petonic)