all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Christian Lynbech <christian@defun.dk>
To: emacs-devel@gnu.org
Subject: Issue in src/xfns.c
Date: Tue, 14 Jun 2016 20:02:45 +0200	[thread overview]
Message-ID: <m2eg7z3ayi.fsf@defun.dk> (raw)


I am not entirely sure what the intention was, but I think there is a
small issue in xfns.c in relation to the RANDR13_LIBRARY macro.

It is used in two places, one where it uses #if and another that uses
#ifdef, the latter of which I think should have been a #if. At least it
failed to compile for me on a rather old linux system with a setup I
know onbly a little about. The define that introduces RANDR13_LIBRARY is
a boolean expression so RANDR13_LIBRARY is always defined.

As far as I can see this is still present in the git repository on the
master branch. An attempt of a patch is given below.


Index: xfns.c
===================================================================
--- xfns.c              (revision 7708)
+++ xfns.c           (working copy)
@@ -4286,7 +4286,7 @@
   n_monitors = resources->noutput;
   monitors = xzalloc (n_monitors * sizeof *monitors);
-#ifdef RANDR13_LIBRARY
+#if RANDR13_LIBRARY
   if (randr13_avail)
     pxid = XRRGetOutputPrimary (dpy, dpyinfo->root_window);
#endif


------------------------+-----------------------------------------------------
Christian Lynbech       | christian #\@ defun #\. dk
------------------------+-----------------------------------------------------
Hit the philistines three times over the head with the Elisp reference manual.
                                        - petonic@hal.com (Michael A. Petonic)



             reply	other threads:[~2016-06-14 18:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-14 18:02 Christian Lynbech [this message]
2016-06-15  4:16 ` Issue in src/xfns.c Ken Raeburn
2016-06-15  4:56   ` John Wiegley
2016-06-15  5:41     ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2eg7z3ayi.fsf@defun.dk \
    --to=christian@defun.dk \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.