From: John Wiegley <jwiegley@gmail.com>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Ibuffer: w and B default to buffer at current line
Date: Thu, 15 Sep 2016 15:05:20 -0700 [thread overview]
Message-ID: <m2eg4kyg2n.fsf@newartisans.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1609141605280.10395@calancha-pc> (Tino Calancha's message of "Wed, 14 Sep 2016 16:21:26 +0900 (JST)")
[-- Attachment #1: Type: text/plain, Size: 1562 bytes --]
>>>>> Tino Calancha <tino.calancha@gmail.com> writes:
> If you compare the first patch with `dired-get-marked-files' (d-g-m-f) you
> might change your mind: (d-g-m-f) returns a list with the file at point when
> there are no marked files. The first patch follow similar idea.
I understand dired may also be taking this bad approach, but that's not a good
reason to continue the practice.
The end goal you're trying to achieve is to make a keystroke more intuitive.
That's a great goal. What it sounds like to me is that we need another layer
above ibuffer-get-marked-files: a command that, if there are marked buffers,
calls ibuffer-get-marked-files, and if there are no marked buffers, calls
ibuffer-current-buffer. Then it's clear to the reader what the command means,
and what is happening, and each function has exactly one job to do.
Monkey-patching Emacs to make single-purpose functions more magical by adding
special arguments -- or special meanings to arguments -- will burden us with
unnecessary technical debt in the future. I don't like this practice, and I'm
unmoved by "prior art" as a justification.
That said, again, I'm 100% in support of the end goal you want to achieve; I
just want to get there in a more principled way. Functions should do what they
say, and not have lots of alternative functionality baked into them because
it's a convenient hack today.
--
John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 629 bytes --]
next prev parent reply other threads:[~2016-09-15 22:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 5:35 Ibuffer: w and B default to buffer at current line Tino Calancha
2016-09-14 6:41 ` John Wiegley
2016-09-14 7:21 ` Tino Calancha
2016-09-14 14:08 ` Drew Adams
2016-09-15 22:05 ` John Wiegley [this message]
2016-09-16 6:40 ` Eli Zaretskii
[not found] ` <<83intw5our.fsf@gnu.org>
2016-09-16 14:53 ` Drew Adams
2016-09-17 16:30 ` John Wiegley
2016-09-17 17:21 ` Eli Zaretskii
2016-09-17 21:35 ` John Wiegley
2016-09-17 23:26 ` Drew Adams
2016-09-17 23:51 ` John Wiegley
2016-09-18 1:45 ` Drew Adams
2016-09-18 2:18 ` John Wiegley
2016-09-18 14:26 ` Eli Zaretskii
2016-09-18 19:35 ` John Wiegley
[not found] ` <<83zin630i9.fsf@gnu.org>
2016-09-17 18:47 ` Drew Adams
2016-09-17 19:25 ` Eli Zaretskii
[not found] ` <<83vaxuib1p.fsf@gnu.org>
2016-09-17 19:33 ` Drew Adams
2016-09-18 14:29 ` Eli Zaretskii
[not found] ` <<d33a60f5-b8b6-4637-b3e6-ea1b09d98f85@default>
[not found] ` <<83poo1i8nf.fsf@gnu.org>
2016-09-18 17:55 ` naming functions [was: Ibuffer: w and B default to buffer at current line] Drew Adams
2016-09-18 19:23 ` John Wiegley
2016-09-18 23:24 ` Drew Adams
2016-09-19 16:35 ` Eli Zaretskii
2016-09-17 18:22 ` Ibuffer: w and B default to buffer at current line Tino Calancha
2016-09-26 12:08 ` Tino Calancha
2016-10-03 12:28 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2eg4kyg2n.fsf@newartisans.com \
--to=jwiegley@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.