From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Identifying the face between STRETCH and right fringe.
Date: Wed, 28 Nov 2018 10:00:53 +0100 [thread overview]
Message-ID: <m2efb5shiy.fsf@gmail.com> (raw)
In-Reply-To: <83y39dg2mh.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 28 Nov 2018 08:03:34 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Tue, 27 Nov 2018 20:38:05 +0100
>> Is there a reason we need to compare with the background of the
>> frame rather than with the background of the default face of the
>> frame?
>
> Basically, because we clear rectangles on display using the frame's
> background color.
>
> Historically, once upon a time, the frame's background was not
> necessarily identical to that of the default face. And given that we
> already have the color recorded in the frame, it is less expensive to
> access that than look up the default face, which might involve
> accessing face-remapping-alist etc. Finally, the frame's face cache,
> which is where we look up faces, is reset from time to time, whereas
> the frame's background color is always valid.
In this particular case extend_face_to_end_of_line has already done:
default_face =
FACE_FROM_ID_OR_NULL (f, lookup_basic_face (it->w, f, DEFAULT_FACE_ID));
so there'd be no additional cost, but that _OR_NULL bit precludes
always using the default face.
Robert
next prev parent reply other threads:[~2018-11-28 9:00 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 16:39 Identifying the face between STRETCH and right fringe Keith David Bershatsky
2018-11-20 17:20 ` Eli Zaretskii
2018-11-21 7:44 ` Robert Pluim
2018-11-23 10:04 ` Eli Zaretskii
2018-11-23 13:25 ` Robert Pluim
2018-11-23 13:48 ` Eli Zaretskii
2018-11-23 14:04 ` Robert Pluim
2018-11-23 15:51 ` Eli Zaretskii
2018-11-23 15:58 ` Robert Pluim
2018-11-23 20:33 ` Eli Zaretskii
2018-11-27 8:56 ` Robert Pluim
2018-11-27 9:34 ` Eli Zaretskii
2018-11-27 11:02 ` Robert Pluim
2018-11-27 11:29 ` Eli Zaretskii
2018-11-27 13:55 ` Robert Pluim
2018-11-27 18:55 ` Eli Zaretskii
2018-11-27 19:14 ` Robert Pluim
2018-11-27 19:38 ` Robert Pluim
2018-11-28 6:03 ` Eli Zaretskii
2018-11-28 9:00 ` Robert Pluim [this message]
2018-11-28 9:42 ` Eli Zaretskii
2018-11-28 9:49 ` Eli Zaretskii
2018-11-28 13:24 ` Robert Pluim
2018-11-28 16:19 ` Eli Zaretskii
2018-11-28 7:13 ` Eli Zaretskii
2018-11-28 8:36 ` Robert Pluim
2018-11-28 9:45 ` Eli Zaretskii
2018-11-28 9:56 ` Robert Pluim
2018-11-28 10:11 ` Eli Zaretskii
2018-11-28 13:21 ` Robert Pluim
2018-11-28 16:20 ` Eli Zaretskii
2018-11-29 12:51 ` Robert Pluim
2018-11-29 14:15 ` Eli Zaretskii
2018-11-28 21:14 ` Alan Third
2018-11-29 12:26 ` Robert Pluim
2018-11-29 12:54 ` Eli Zaretskii
2018-11-29 13:52 ` Robert Pluim
2018-11-29 14:08 ` Eli Zaretskii
2018-11-30 7:59 ` Robert Pluim
2018-11-30 8:04 ` Robert Pluim
2018-11-30 8:22 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2efb5shiy.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.