From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0) Date: Wed, 26 Feb 2020 10:56:41 +0100 Message-ID: References: <87h7zoorys.fsf@thb.lt> <87lfozsuoi.fsf@thb.lt> <83pneblloc.fsf@gnu.org> <83lfozlkmt.fsf@gnu.org> <8c68006d-54b5-7fd5-128a-c253b4899cde@yandex.ru> <83k14jl0j8.fsf@gnu.org> <83ftf6lh79.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="105581"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39662@debbugs.gnu.org, thibault@thb.lt To: dgutov@yandex.ru Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 26 10:57:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j6tRK-000RLM-O5 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Feb 2020 10:57:14 +0100 Original-Received: from localhost ([::1]:41470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6tRJ-0001eg-Qe for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Feb 2020 04:57:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34070) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6tRA-0001dN-Co for bug-gnu-emacs@gnu.org; Wed, 26 Feb 2020 04:57:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6tR8-0007Wk-9s for bug-gnu-emacs@gnu.org; Wed, 26 Feb 2020 04:57:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50421) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j6tR8-0007We-6H for bug-gnu-emacs@gnu.org; Wed, 26 Feb 2020 04:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j6tR8-0001pK-46 for bug-gnu-emacs@gnu.org; Wed, 26 Feb 2020 04:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Feb 2020 09:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39662 X-GNU-PR-Package: emacs Original-Received: via spool by 39662-submit@debbugs.gnu.org id=B39662.15827110117005 (code B ref 39662); Wed, 26 Feb 2020 09:57:02 +0000 Original-Received: (at 39662) by debbugs.gnu.org; 26 Feb 2020 09:56:51 +0000 Original-Received: from localhost ([127.0.0.1]:56394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j6tQx-0001ov-Kh for submit@debbugs.gnu.org; Wed, 26 Feb 2020 04:56:51 -0500 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:38510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j6tQv-0001oh-Sz for 39662@debbugs.gnu.org; Wed, 26 Feb 2020 04:56:50 -0500 Original-Received: by mail-wm1-f50.google.com with SMTP id a9so2299515wmj.3 for <39662@debbugs.gnu.org>; Wed, 26 Feb 2020 01:56:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=4zggkjkX6IV4Zo+CMt0jpld+ppSlRJdd74hl6VQUA8A=; b=iR0Bq/f9SIkIuf/QcthXp6DI9e9axx0mdCbqgEMzwL52YsPvpBtyXslBfRmDCwLu6S ge6rF9QnLJmlq0Ncjg7YeCZdKcFzGd1M5UEM8wi18oMMjKcGLYVZU8oM7X6WzmXJut/M tIy/MzncFd/bW4sYDRfg4t7/lzejkTcdR/0YCOV5zVGiMW/K8L5WHMIpJPwlngumiBQ+ EhX7EYPfEae+g8MGWvzEqxwq3eiiXy3yDNTGJh6PRoG8G5CcOPVGVe9KfdZZxFFjEzqS ZHkgr50bUWjIpKDRCOOL5OuM30jQNTpqDrJvNS0HdACAXuThZzd5fisxsHfi63kC4jSa rxGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=4zggkjkX6IV4Zo+CMt0jpld+ppSlRJdd74hl6VQUA8A=; b=NTxrFWKh8Yn9qHTsAWRzjPLgJxRFX3PRGmr/7d8POp9XX78Ccyx+LHK+MG75aAmRtN gbZufix/cyk+frW8d6Btmd2qGei1ayFnDbXBsDlhR7OITYdP1/p5ALL0oBuDByPv5/62 ybxA/Mku0SMYwgrN+xPYsZvIZIiTpi/IOi3sZLj0kBtmswXcivXijMOvG1WIaUbAb4VC ddpIMvPkGBdeIcu/Wn5qWW7kem0/TkSEphk7cWbEaLePh0Oi2t3icQfc5l0zUBovm2zL DRvlVC2bxDozTMgOsgoBBfOt+UeZ/oqDp4Brqq3hllUVqu9yHKYmU8zlrGGSRaRBzHkH HgFA== X-Gm-Message-State: APjAAAUj9PBnRR8CGnDGIZuFTlmixE+zrO+dtJz1lwZHuETaVEbgBMzT KWZLy1qv3QHfDHGstoLw/Po= X-Google-Smtp-Source: APXvYqx3suv+bENOr1yCoM65IiacnHpmq915OKkPH2478/kTdHd1k2XqrCy1LYuzMrzu5v7vlEIPZg== X-Received: by 2002:a05:600c:34d:: with SMTP id u13mr4637895wmd.77.1582711003714; Wed, 26 Feb 2020 01:56:43 -0800 (PST) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:fd10:e268:ca69:2b17]) by smtp.gmail.com with ESMTPSA id g25sm8638781wmh.3.2020.02.26.01.56.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2020 01:56:42 -0800 (PST) In-Reply-To: <83ftf6lh79.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 19 Feb 2020 17:39:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176491 Archived-At: >>>>> On Wed, 19 Feb 2020 17:39:22 +0200, Eli Zaretskii said: >> Maybe signaling an error is best :-) Eli> That was my original suggestion/tendency, so I obviously agree. Dmitry, would the following work for you? There=CA=BCs a potential similar issue with HEIGHT, but I=CA=BCm not planning on touching that just yet. diff --git a/src/fringe.c b/src/fringe.c index 97aad843c2..2a46e3c34f 100644 --- a/src/fringe.c +++ b/src/fringe.c @@ -1500,7 +1500,8 @@ DEFUN ("define-fringe-bitmap", Fdefine_fringe_bitmap,= Sdefine_fringe_bitmap, BITMAP is a symbol identifying the new fringe bitmap. BITS is either a string or a vector of integers. HEIGHT is height of bitmap. If HEIGHT is nil, use length of BITS. -WIDTH must be an integer between 1 and 16, or nil which defaults to 8. +WIDTH must be an integer from 1 to 16, or nil which defaults to 8. An +error is signaled if WIDTH is outside this range. Optional fifth arg ALIGN may be one of `top', `center', or `bottom', indicating the positioning of the bitmap relative to the rows where it is used; the default is to center the bitmap. Fifth arg may also be a @@ -1535,7 +1536,9 @@ list (ALIGN PERIODIC) where PERIODIC non-nil specifie= s that the bitmap else { CHECK_FIXNUM (width); - fb.width =3D max (0, min (XFIXNUM (width), 255)); + fb.width =3D max (1, min (XFIXNUM (width), 16)); + if (fb.width !=3D XFIXNUM (width)) + args_out_of_range (width, build_string ("Width must be from 1 to 1= 6")); } =20 fb.period =3D 0;