all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Daniel Koning <dk@danielkoning.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stefan@marxist.se, 41761@debbugs.gnu.org, pipcet@gmail.com
Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary
Date: Sun, 16 Aug 2020 14:04:14 -0500	[thread overview]
Message-ID: <m2eeo65s5t.fsf@danielkoning.com> (raw)
In-Reply-To: <83pn7qiss9.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 16 Aug 2020 17:12:22 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> I do think the prior behavior differs somewhat from the way you phrased
>> it. I would write it as:
>>
>>     Originally, when 'inhibit-field-text-motion' was nil, 'count-words'
>>     stopped counting words at the end of the field containing START.
>>
>> (It didn't ignore text inside fields, but rather text that was not
>> inside one specific field.)
>
> I'm not sure I understand the "end of field containing START" part.
> Supposed the region includes several fields, what would the previous
> code do?

It would only count the words between START and the next field boundary,
no matter how many fields came after that. (For START, substitute "the
beginning of the region" or "the beginning of the buffer" if it was
called interactively.)

Try reinstalling the old function definition and evaluating:

ELISP> (with-temp-buffer
         (dotimes (i 9) (insert (propertize "4 words 22 characters " 'field i)))
         (insert "\n4 words 22 characters")
         (call-interactively #'count-words)) ; operates on whole buffer

=> "Buffer has 2 lines, 4 words, and 220 characters."

That result arises because of how `count-words' generates its return
value: it moves point to the beginning of the buffer (after narrowing
the buffer to START and END if they were supplied), then repeatedly
calls `forward-word-strictly' until that function returns nil,
incrementing the running total each time. Before, if it ran into a field
boundary, it would stop short, because `forward-word-strictly' doesn't
jump field boundaries by default.

I think the value of that form demonstrates why the old behavior was
wrong. There does not exist any part of the temp buffer that "has 2
lines, 4 words, and 220 characters." It gives inconsistent results
because the line count and character count use techniques which aren't
affected by fields.

Daniel





  reply	other threads:[~2020-08-16 19:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-08 16:52 bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Pip Cet
2020-06-10 20:15 ` bug#41761: [PATCH] " Daniel Koning
2020-08-14  9:58   ` Stefan Kangas
2020-08-14 11:08     ` Eli Zaretskii
2020-08-14 18:48       ` Daniel Koning
2020-08-14 19:15         ` Eli Zaretskii
2020-08-14 19:44           ` Daniel Koning
2020-08-15  6:30             ` Eli Zaretskii
2020-08-14 23:06           ` Stefan Kangas
2020-08-15 16:28             ` Eli Zaretskii
2020-08-15 17:44               ` Daniel Koning
2020-08-15 17:48                 ` Eli Zaretskii
2020-08-15 19:44                   ` Daniel Koning
2020-08-16 14:12                     ` Eli Zaretskii
2020-08-16 19:04                       ` Daniel Koning [this message]
2020-08-16 19:27                         ` Eli Zaretskii
2020-08-16 19:37                           ` Daniel Koning
2020-08-17 13:51                           ` Stefan Kangas
2020-08-17 16:12                             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2eeo65s5t.fsf@danielkoning.com \
    --to=dk@danielkoning.com \
    --cc=41761@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=pipcet@gmail.com \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.