ca47d10e commit broke the build

ca47d10e commit broke the build

[Martyn Jago]

Frankly I'm not sure why, but my build is broken against emacs 22,23,24

Ref: http://martynjago.co.uk:3333/builds/Org-mode_on_Emacs_24/ca47d10e1f0070f5c6461ff763486b693ff77209

Best, Martyn

Re: ca47d10e commit broke the build

[Jambunathan K]

Martyn

The probelmatic commit could actually be this:
	commit - 07f006e4fd9a7b66643cd7b404c8994665ba8300
which touches the Makefile.

I am unable to reproduce this locally. Ulrich - the intended consumer of
[1]the above commit - also hasn't noted any build failures with his setup [1].

Would it be possible for you (or anyone else) to isolate this further
and identify the root cause.

Thanks for reporting this,
Jambunathan K.

Footnotes: 

[1]  See the last para of this post:
http://lists.gnu.org/archive/html/emacs-orgmode/2011-12/msg00857.html

Martyn Jago <martyn.jago@btinternet.com> writes:
> Frankly I'm not sure why, but my build is broken against emacs 22,23,24
>
> Ref:
> http://martynjago.co.uk:3333/builds/Org-mode_on_Emacs_24/ca47d10e1f0070f5c6461ff763486b693ff77209
>
> Best, Martyn
>
>
>
>



-- 

Re: ca47d10e commit broke the build

[Martyn Jago]

Hi Jambunathan

Jambunathan K <kjambunathan@gmail.com> writes:

> Martyn
>
> The probelmatic commit could actually be this:
> 	commit - 07f006e4fd9a7b66643cd7b404c8994665ba8300
> which touches the Makefile.

The problem was indeed related to the Makefile - the thing that changed
(I'm guessing) is the use of the EMACS variable during `make install'
(re-compilation of org-odt)?

The solution was to change the test-build scripts from:

--8<---------------cut here---------------start------------->8---
make clean && make EMACS=/Applications/Emacs-2x.app/Contents/MacOS/Emacs &&
make install && make doc && /Applications/Emacs-2x.app/Contents/MacOS/Emacs -Q -batch -l
/Users/martyn/.cruise/projects/Org-mode_on_Emacs_24/work/testing/org-test.el
-eval "(setq org-confirm-babel-evaluate nil)" -f
org-test-run-batch-tests
--8<---------------cut here---------------end--------------->8---

...to:

--8<---------------cut here---------------start------------->8---
make clean && make EMACS=/Applications/Emacs-2x.app/Contents/MacOS/Emacs &&
make install EMACS=/Applications/Emacs-2x.app/Contents/MacOS/Emacs && make
doc EMACS=/Applications/Emacs-2x.app/Contents/MacOS/Emacs &&
/Applications/Emacs-2x.app/Contents/MacOS/Emacs -Q -batch -l
/Users/martyn/.cruise/projects/Org-mode_on_Emacs_24/work/testing/org-test.el
-eval "(setq org-confirm-babel-evaluate nil)" -f
org-test-run-batch-tests
--8<---------------cut here---------------end--------------->8---

...since the compile version was detected to be incompatible (EMACS was
defaulting to v22.1.1 during make install).

This fixes my v24 and v23 test builds.

There is a broken test under v22 which I will look at in the near
future.

Best, Martyn

[...]