From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs Subject: bug#13000: 24.2.90; underwave doesn't look as good as other IDEs Date: Thu, 27 Dec 2012 16:33:19 +0800 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1356597265 26696 80.91.229.3 (27 Dec 2012 08:34:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 27 Dec 2012 08:34:25 +0000 (UTC) Cc: aurelien.aptel@gmail.com To: 13000@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 27 09:34:40 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1To8vI-0003rS-4g for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Dec 2012 09:34:40 +0100 Original-Received: from localhost ([::1]:48190 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1To8v3-0005hc-Nn for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Dec 2012 03:34:25 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1To8uv-0005gd-OA for bug-gnu-emacs@gnu.org; Thu, 27 Dec 2012 03:34:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1To8uu-0007FT-NM for bug-gnu-emacs@gnu.org; Thu, 27 Dec 2012 03:34:17 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1To8uu-0007FO-JF for bug-gnu-emacs@gnu.org; Thu, 27 Dec 2012 03:34:16 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1To8ve-0002JM-9s for bug-gnu-emacs@gnu.org; Thu, 27 Dec 2012 03:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Dec 2012 08:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13000 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 13000-submit@debbugs.gnu.org id=B13000.13565972608835 (code B ref 13000); Thu, 27 Dec 2012 08:35:02 +0000 Original-Received: (at 13000) by debbugs.gnu.org; 27 Dec 2012 08:34:20 +0000 Original-Received: from localhost ([127.0.0.1]:33102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1To8uy-0002IR-11 for submit@debbugs.gnu.org; Thu, 27 Dec 2012 03:34:20 -0500 Original-Received: from mail-da0-f47.google.com ([209.85.210.47]:62919) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1To8uw-0002II-1j for 13000@debbugs.gnu.org; Thu, 27 Dec 2012 03:34:18 -0500 Original-Received: by mail-da0-f47.google.com with SMTP id s35so4222662dak.6 for <13000@debbugs.gnu.org>; Thu, 27 Dec 2012 00:33:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:face:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=SkRuM9yPhLhol5iWPaYEzdrWSL4SZDdzwGR1ibsHRzM=; b=g2R7wDsJVG3Nx7y+i1YHzSLiZ42EhJPAihKqQ2ZtczGcH07MH91H5yOStZ3x1zSJf1 bPd7BN75Y1h5p8FC8wdW0MhIuAvYFsHnj77lCtxGlm7NLuN+2/16TsBf2J1ouP1MmRui tAOY0FAFMI7ZaODggOivbRIRWKvw3xfkHeQHy5o4Kcdki0xwDQlgSFUOnx5WOGZ7qdOT PgqD1Fx+pY8+vwFPiw2+hK3Bao4R+g2GuHmjifyVEOy1KPpbozkFn2U660ddsHEh7obE twpkoxnHau1NT1f44gZ/VNRSWB92zzDhi5LGHViocngmuAViaGdxNbEA0AYYp/SQb23v Cotw== X-Received: by 10.66.73.105 with SMTP id k9mr88094785pav.37.1356597211317; Thu, 27 Dec 2012 00:33:31 -0800 (PST) Original-Received: from localhost (basil.offersbridge.com. [209.141.62.117]) by mx.google.com with ESMTPS id d1sm18079298pav.6.2012.12.27.00.33.28 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 27 Dec 2012 00:33:30 -0800 (PST) Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= In-Reply-To: (Leo's message of "Wed, 26 Dec 2012 14:31:03 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (OS X 10.8.2) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:69069 Archived-At: The following patch by YAMAMOTO Mitsuharu brings the code to be in line with the comment. I tested it with an X11 build and the wave looked better. === modified file 'src/xterm.c' *** src/xterm.c 2012-12-12 15:33:30 +0000 --- src/xterm.c 2012-12-27 01:20:52 +0000 *************** *** 2633,2646 **** static void x_draw_underwave (struct glyph_string *s) { ! int wave_height = 2, wave_length = 3; int dx, dy, x0, y0, width, x1, y1, x2, y2, odd, xmax; XRectangle wave_clip, string_clip, final_clip; dx = wave_length; dy = wave_height - 1; x0 = s->x; ! y0 = s->ybase + 1; width = s->width; xmax = x0 + width; --- 2633,2646 ---- static void x_draw_underwave (struct glyph_string *s) { ! int wave_height = 3, wave_length = 2; int dx, dy, x0, y0, width, x1, y1, x2, y2, odd, xmax; XRectangle wave_clip, string_clip, final_clip; dx = wave_length; dy = wave_height - 1; x0 = s->x; ! y0 = s->ybase - wave_height + 3; width = s->width; xmax = x0 + width;