Re: outorg-edit-as-org and mu4e

[Alan Schmitt <alan.schmitt@polytechnique.org>]

Thorsten Jolitz <tjolitz@gmail.com> writes:

> Ok, then its not a bug but just a (slightly) different use case.

Yes.

> I don't use mu4e, actually I never heard of it (is it good?). 

I like it. It may not be as full-featured as gnus, but it has reliable links to
messages (even when they are moved around). I could never get the nnregistry to
work reliably for me.

> Could you test these changes and let me know if it works for you? Then I'm
> happy to apply them to outorg, no matter if this version:
>
> #+begin_src emacs-lisp
>   (and (derived-mode-p 'message-mode)
>        (outorg-prepare-message-mode-buffer-for-editing))
> #+end_src

I tried this and it almost works, since mu4e make the "--text follows this
line--" read only. Here is how I patched outorg.el:

#+BEGIN_SRC diff
Changes from head to working tree
1 file changed, 4 insertions(+), 3 deletions(-)
 outorg.el | 7 ++++---

	Modified   outorg.el
diff --git a/outorg.el b/outorg.el
index 189ddb9..ab3e48d 100644
--- a/outorg.el
+++ b/outorg.el
@@ -469,7 +469,8 @@ headline and out-comments all text below this line - if any."
     (goto-char (point-min))
     ;; (re-search-forward "--text follows this line--" nil 'NOERROR)
     (re-search-forward mail-header-separator nil 'NOERROR)
-    (replace-match "* \\&")
+    (let ((inhibit-read-only t))
+      (replace-match "* \\&"))
     (beginning-of-line)
     (let ((start-body (point)))
       (comment-region start-body (point-max))
@@ -994,7 +995,7 @@ With ARG, act conditional on the raw value of ARG:
            (error "Cannot edit read-only buffer")
          (setq inhibit-read-only t)
          (setq outorg-code-buffer-read-only-p t)))
-  (and (eq major-mode 'message-mode)
+  (and (derived-mode-p 'message-mode)
        (outorg-prepare-message-mode-buffer-for-editing))
   (and (eq major-mode 'picolisp-mode)
        (save-excursion
@@ -1076,7 +1077,7 @@ With ARG, act conditional on the raw value of ARG:
   ;;  (marker-position outorg-code-buffer-point-marker))
   (and outorg-code-buffer-read-only-p
        (setq inhibit-read-only nil))
-  (and (eq major-mode 'message-mode)
+  (and (derived-mode-p 'message-mode)
        (outorg-prepare-message-mode-buffer-for-sending))
   (and (eq major-mode 'picolisp-mode)
        (save-excursion
#+END_SRC

I've made a few tests and things seem to work. I'll keep using it and will
report if something break.

Thanks,

Alan