From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: John Wiegley Newsgroups: gmane.emacs.devel Subject: Re: setq's with missing final arguments. Date: Sun, 22 Nov 2015 15:20:17 -0800 Message-ID: References: <20151122122657.GA2332@acm.fritz.box> <065d0399-7e58-465d-b57f-5ebe91695e59@default> <20151122230815.GE2332@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1448234438 23128 80.91.229.3 (22 Nov 2015 23:20:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Nov 2015 23:20:38 +0000 (UTC) Cc: Drew Adams , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 23 00:20:37 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a0dvu-0003Ct-93 for ged-emacs-devel@m.gmane.org; Mon, 23 Nov 2015 00:20:34 +0100 Original-Received: from localhost ([::1]:57866 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0dvt-0004eY-WC for ged-emacs-devel@m.gmane.org; Sun, 22 Nov 2015 18:20:34 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0dvm-0004co-Fy for emacs-devel@gnu.org; Sun, 22 Nov 2015 18:20:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0dvi-0000QA-Hv for emacs-devel@gnu.org; Sun, 22 Nov 2015 18:20:26 -0500 Original-Received: from mail-pa0-x229.google.com ([2607:f8b0:400e:c03::229]:33205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0dvi-0000Q6-Cd for emacs-devel@gnu.org; Sun, 22 Nov 2015 18:20:22 -0500 Original-Received: by pabfh17 with SMTP id fh17so177471967pab.0 for ; Sun, 22 Nov 2015 15:20:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mail-followup-to:mime-version:content-type; bh=2TkxYGit+3bNjHU3II7tEEI+U69DAOhVyyOQskFQpbU=; b=rvgpYDaZ2H+bZDQZUBZtJYpZ48SeoxEYp5vsi7qRHTn3RpRB0AR4JqrxN3bSq6P0Yv /fyoa0JqeAy+S7OxsKVWyG4yRVMyqdSuapTLrfJyrRd3QqVzzxAuD3dr29UePrs6zdLM Zw203dE/GtZlr5NdJ6MbY1MEpUoTFMZKHS9iKRd0Zk8Nqd6cfjLdijgjxQQtTz4D+F5R JRyMBSafn94ALI/O/9AGxQrBkXOhT07Td8WK3uxDUbFgaxVuuhQZxpKSU8hWjFnQPNQd y0aqrTHMjKJVeQJKQ+AZq+io2pfOsLHcjZN5xYnljvF/l1iy5cIqtnaa5wUeC94vrhFu u0Yg== X-Received: by 10.68.190.233 with SMTP id gt9mr32664424pbc.127.1448234421633; Sun, 22 Nov 2015 15:20:21 -0800 (PST) Original-Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id ce3sm7775410pbb.35.2015.11.22.15.20.20 (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 22 Nov 2015 15:20:20 -0800 (PST) X-Google-Original-From: "John Wiegley" Original-Received: by Vulcan.local (Postfix, from userid 501) id 6B00410A8346A; Sun, 22 Nov 2015 15:20:19 -0800 (PST) In-Reply-To: <20151122230815.GE2332@acm.fritz.box> (Alan Mackenzie's message of "Sun, 22 Nov 2015 23:08:15 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) Mail-Followup-To: Alan Mackenzie , Drew Adams , emacs-devel@gnu.org X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195078 Archived-At: >>>>> Alan Mackenzie writes: > I now think we should make any setq with a missing value throw an error, > whether in interpreted code or in the byte compiler. And I think we should > do it for Emacs 25.1. > John? I agree it should cause an error, and every usage in core should be fixed. Also please fix `setf', which has the same problem. `set', on the other hand, gives this error: Error: wrong-number-of-arguments; Data: (set 1) We should yield the same in the other two cases. And think about what other functions should receive this same treatment. John