From: Robert Pluim <rpluim@gmail.com>
To: Carlos Pita <carlosjosepita@gmail.com>
Cc: 37752@debbugs.gnu.org
Subject: bug#37752: Scaling factor inconsistencies between X with and without GTK
Date: Tue, 15 Oct 2019 09:56:46 +0200 [thread overview]
Message-ID: <m2d0ey4f29.fsf@gmail.com> (raw)
In-Reply-To: <CAELgYheD=Z3__BQntdiiRNmuNAgi0M+MS8wJcpowv_47JJ7kaA@mail.gmail.com> (Carlos Pita's message of "Mon, 14 Oct 2019 21:21:54 -0300")
>>>>> On Mon, 14 Oct 2019 21:21:54 -0300, Carlos Pita <carlosjosepita@gmail.com> said:
Carlos> In many places in xterm.c you have code like:
Carlos> #ifdef USE_GTK
Carlos> scale = xg_get_scale (f);
Carlos> #endif
Carlos> Sometimes scale is only used in GTK specific code and that's ok.
Carlos> But sometimes it's used in code that's not particular to GTK, for example:
Carlos> int scale = 1;
Carlos> #ifdef USE_GTK
Carlos> scale = xg_get_scale (f);
Carlos> #endif
Carlos> FRAME_CR_SURFACE (f) =
Carlos> cairo_image_surface_create (CAIRO_FORMAT_ARGB32,
Carlos> scale * FRAME_PIXEL_WIDTH (f),
Carlos> scale * FRAME_PIXEL_HEIGHT (f));
I canʼt find that code in master.
Carlos> Besides, there is x_get_scale_factor, also defined in xterm.c, which
Carlos> computes the scaling factor in a GTK-independent way, and also
Carlos> discriminates between x and y scaling factors. It's only used by
Carlos> x_draw_underwave.
Carlos> I would like to abstract both cases inside x_get_scale_factor, that
Carlos> would then use xg_get_scale if in GTK or compute just one scaling
Carlos> factor (for x or for y) otherwise. Notice that given that the scaling
Carlos> factor is the ratio of the effective resolution to a base resolution
Carlos> of 96 dpi *truncated down* to the nearest integer, AFAICS it's almost
Carlos> impossible to get different scaling factors for x and for y.
Sure, that makes sense. Do you have a test case showing a display
difference, or is this just code cleanup?
Robert
next prev parent reply other threads:[~2019-10-15 7:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 0:21 bug#37752: Scaling factor inconsistencies between X with and without GTK Carlos Pita
2019-10-15 7:56 ` Robert Pluim [this message]
2019-10-15 8:09 ` Carlos Pita
2019-10-15 9:37 ` Robert Pluim
2019-10-15 22:40 ` Carlos Pita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2d0ey4f29.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=37752@debbugs.gnu.org \
--cc=carlosjosepita@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.