From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0) Date: Tue, 18 Feb 2020 16:45:20 +0100 Message-ID: References: <87h7zoorys.fsf@thb.lt> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="71918"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39662@debbugs.gnu.org, Dmitry Gutov To: Thibault Polge Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 18 16:47:50 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j456E-000Ibe-7A for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 Feb 2020 16:47:50 +0100 Original-Received: from localhost ([::1]:37416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j456D-0000Rs-9R for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 Feb 2020 10:47:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39824) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j454V-0006mH-0w for bug-gnu-emacs@gnu.org; Tue, 18 Feb 2020 10:46:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j454T-0004YA-VG for bug-gnu-emacs@gnu.org; Tue, 18 Feb 2020 10:46:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35185) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j454T-0004Y0-RQ for bug-gnu-emacs@gnu.org; Tue, 18 Feb 2020 10:46:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j454T-00034C-QL for bug-gnu-emacs@gnu.org; Tue, 18 Feb 2020 10:46:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Feb 2020 15:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39662 X-GNU-PR-Package: emacs Original-Received: via spool by 39662-submit@debbugs.gnu.org id=B39662.158204073011746 (code B ref 39662); Tue, 18 Feb 2020 15:46:01 +0000 Original-Received: (at 39662) by debbugs.gnu.org; 18 Feb 2020 15:45:30 +0000 Original-Received: from localhost ([127.0.0.1]:41158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j453x-00033O-RF for submit@debbugs.gnu.org; Tue, 18 Feb 2020 10:45:30 -0500 Original-Received: from mail-wr1-f42.google.com ([209.85.221.42]:34919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j453w-000338-SP for 39662@debbugs.gnu.org; Tue, 18 Feb 2020 10:45:29 -0500 Original-Received: by mail-wr1-f42.google.com with SMTP id w12so24530786wrt.2 for <39662@debbugs.gnu.org>; Tue, 18 Feb 2020 07:45:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=o/lY7miw16NXv/uno4dZUv8sgUH2L1OFMfQG4oBDPk0=; b=O2AiJKcHFfDU4Nw0+fKF8igAlEQFzbzHBVLQ5WWVgDKFbFJtwKA2LfOGc+hWYKlbbL hUF0BLbCLNtGQplLlcz7T42PAhVCMFpGDvG4NApeaWCyJy0PSYZfe/E3uRUJ2C95UXDo hPb4dlFMrsNdKEKKj4TWrDx35VwkUraqa95mkORbNRSJykcyItXe2NLVRaS4zxEGsWVX HX+aBFMv9viGlTdRyyThVGHXczi6XZprjK/Hr9HxsXUU4xAgArlDIqsEijyARXtnhz5E 53t21q6SHATHGYT1O1lm6Rp0mQi5t4tck2I78Mic3eyPQi1g3Ak3W/2mnb+3RQLPXCHC TDAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=o/lY7miw16NXv/uno4dZUv8sgUH2L1OFMfQG4oBDPk0=; b=UcgqQhy9dd0HrlOhGFWunPtJL0RJ2OSxJasroLvNyBT9z6GYzMRXwJEF+ACpCckUJs Qt4UvjiP8aFSM80mL22qNZrbbfYF210QLq8gp0f2eVq4aDBYpmFeXdrKcHObjG3XVYk7 vjktADy2AHOdgTPhDjCydwftOKV25T3aE1eAGb65vbKuJDcQIE0V1PpSh6CIaOuhA3Dm VtCr87YTy6Ygztrn0e1H5nlmDFcIY5aD9jvXE9vYTQgCsdBgmQW4KZL9qf1+F0CTDSmT j7i7K/G2y2RvHsoZMtaZqiLv2zKAAnkhis+g0gHIEHBW2QOuDOpCttqGVwbGwVsMm+vY kcgQ== X-Gm-Message-State: APjAAAXlbDWjlGit06rVH/4GrZ2UcusUZJsb0RTOg/0gyUpU4iA/b2cF lwgdlbGWs48bcC3l0V78WtY= X-Google-Smtp-Source: APXvYqyiCJxF0Ioxhxr9aj1J/CgivaZlZ5Kp+LJMLOMAcb74OWWtY/MyYntMFcg6D02I6a7Cz81o3Q== X-Received: by 2002:adf:f6d0:: with SMTP id y16mr2681126wrp.140.1582040722784; Tue, 18 Feb 2020 07:45:22 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id c4sm4048302wml.7.2020.02.18.07.45.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2020 07:45:21 -0800 (PST) In-Reply-To: <87h7zoorys.fsf@thb.lt> (Thibault Polge's message of "Tue, 18 Feb 2020 16:06:19 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176192 Archived-At: >>>>> On Tue, 18 Feb 2020 16:06:19 +0100, Thibault Polge = said: Thibault> Emacs built from commit b519d515bac8bd8c1265fe3965a51be249581= 817, on Thibault> GNU/Linux, with the Lucid or GTK3 toolkits (haven't tried any= thing Thibault> else), will crash eval'ing this snippet: Thibault> (progn Thibault> (package-initialize) Thibault> (package-install 'diff-hl) Thibault> (fringe-mode 0) Thibault> (dired "~") Thibault> (diff-hl-dired-mode 1)) Yes, if fringe-mode is disabled the width calculated by diff-hl for the bitmap is zero, which x_cr_define_fringe_bitmap doesn=CA=BCt like. Does this bandaid fix it for you? It will still crash if you later re-enable fringe-mode. Perhaps we should signal an error for this case and have diff-hl deal with the fallout? (define-fringe-bitmap docstring says the width has to be from 1-16). diff --git a/src/xterm.c b/src/xterm.c index 21d99f0c7b..7836a57fc6 100644 --- a/src/xterm.c +++ b/src/xterm.c @@ -552,6 +552,9 @@ x_end_cr_xlib_drawable (struct frame *f, GC gc) static void x_cr_define_fringe_bitmap (int which, unsigned short *bits, int h, int wd) { + if (h =3D=3D 0 || wd =3D=3D 0) + return; + int i, stride; cairo_surface_t *surface; cairo_pattern_t *pattern;