From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#39133: 28.0.50; Emacs slowdown on special char Date: Mon, 02 Mar 2020 08:40:02 +0100 Message-ID: References: <83lfqa5aa2.fsf@gnu.org> <83r2004rqn.fsf@gnu.org> <8336c5rw5t.fsf@gnu.org> <83y2txq8fw.fsf@gnu.org> <83muacrgwj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="109112"; mail-complaints-to="usenet@ciao.gmane.io" Cc: lg.zevlg@gmail.com, 39133@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 02 08:41:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j8fhT-000SGB-7U for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Mar 2020 08:41:15 +0100 Original-Received: from localhost ([::1]:55930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8fhS-00042r-3d for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Mar 2020 02:41:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60103) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8fhI-0003wl-Br for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2020 02:41:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8fhG-0003V3-2t for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2020 02:41:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59482) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j8fhF-0003Ut-W5 for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2020 02:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j8fhF-0003UT-SG for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2020 02:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Mar 2020 07:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39133 X-GNU-PR-Package: emacs Original-Received: via spool by 39133-submit@debbugs.gnu.org id=B39133.158313481313321 (code B ref 39133); Mon, 02 Mar 2020 07:41:01 +0000 Original-Received: (at 39133) by debbugs.gnu.org; 2 Mar 2020 07:40:13 +0000 Original-Received: from localhost ([127.0.0.1]:37222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j8fgT-0003Sn-Ay for submit@debbugs.gnu.org; Mon, 02 Mar 2020 02:40:13 -0500 Original-Received: from mail-wr1-f67.google.com ([209.85.221.67]:35990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j8fgR-0003SL-99 for 39133@debbugs.gnu.org; Mon, 02 Mar 2020 02:40:11 -0500 Original-Received: by mail-wr1-f67.google.com with SMTP id j16so11204690wrt.3 for <39133@debbugs.gnu.org>; Sun, 01 Mar 2020 23:40:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=2Iwk2tKRgu+iJ4YEvE1mFLzUKTirWyqq74bq0alYpns=; b=BXUX9d+BOtoFmvdSE6PLJhfsNrc3k3iSlO1CHeuJ+Bsj895XlKZAtIMl9fjfUmQV8f YSfIvD0pJdzhqLjRWVyT6IgAPmSp7fCZVtyur3JWL5KAYjxYtFtqo1vXr2tNmIn4bvp0 6MDOvSc8ntKHN9s+QQisV0oqEJhAJLl8wEejr0KzxWTv7vSRduElqrtCFOPqC6d9jF0m owmeAYHwCFw2ZG3XoFviLIPyx+jkCdVjDonqjehEK4Ed3Hxog7NBMYrXNDQTdD2ICvAp VGWmV4y5M+CA/ndfTGEf/TW8JnrGZGdVxEy802yvszMj4mXmgTU36GTcOutfY9HuD69U reeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=2Iwk2tKRgu+iJ4YEvE1mFLzUKTirWyqq74bq0alYpns=; b=DBmUndEepJbMlOhBM8337cAW3BMB8qKfO3x4+x28EAP0ofM7Sue4wzNeQgOGv1Ospj vf8U0U/TBLG37kbUWqA41658DWytr5OntDIZ+Mbu9lWyYtNRNwpTs//kTe615SNLVxez iK58j3EnGDzfQPUIVez4RWVsLoekjMNGAkykAJExwJHhYTsaPLw1MIqbS9JUR81WviuM lLK4mdw/JwdcB7RJZ0mUcb0motEuqf4qANlJDzJh0ftvpSbMryZ4sd9oB9ZLs27fMkv1 NX3PSxLq5M0SuZpyPhRz7dO6b/Mx9DDH7QHCwWNIf9nuLrhbaSSpCsica2mIwV+T+XfK Ac4w== X-Gm-Message-State: ANhLgQ2QqBDQuzpUIpXbTcJC+4+HlbWBhGhgEGkkOIHUNPKKJowhmoHP FaFo1FK1eQrJiaFPQptQwYw= X-Google-Smtp-Source: ADFU+vs9DXz/k/6j60JKPOlwU40fTnWCnd14RHJ4JH1nuYKcsoMHAfTX74PZfmnHgjidcDvyqFe1RA== X-Received: by 2002:adf:e6ca:: with SMTP id y10mr359592wrm.220.1583134805284; Sun, 01 Mar 2020 23:40:05 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id f15sm8521411wru.83.2020.03.01.23.40.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2020 23:40:04 -0800 (PST) In-Reply-To: <83muacrgwj.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 24 Jan 2020 17:52:12 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176752 Archived-At: >>>>> On Fri, 24 Jan 2020 17:52:12 +0200, Eli Zaretskii said: >> From: Robert Pluim >> Cc: 39133@debbugs.gnu.org, lg.zevlg@gmail.com, >> mituharu@math.s.chiba-u.ac.jp, handa@gnu.org >> Date: Fri, 24 Jan 2020 16:41:40 +0100 >> >> >>>>> On Fri, 24 Jan 2020 14:50:10 +0100, Robert Pluim said: Robert> Yes, I worked that out. A simple crash, for once :-) >> >> >From 667f47abecc13e8a47181f338e727d95e57a6354 Mon Sep 17 00:00:00 2001 >> From: Robert Pluim >> Date: Fri, 24 Jan 2020 14:11:44 +0100 >> Subject: [PATCH] Don't attempt to cache glyph metrics for FONT_INVALID_CODE >> >> This was causing massive slowdown in redisplay when eg #xfe0f >> (VARIATION SELECTOR-16) was present, as the cache ended up very large, >> unused, and being recreated on every call to font_fill_lglyph_metrics >> (Bug#39133). >> >> * src/composite.c (fill_gstring_body): Hoist FONT_OBJECT_P check out >> of loop. Calculate glyph code and check for FONT_INVALID_CODE before >> calling font_fill_lglyph_metrics. Pass glyph code to it. >> >> * src/font.c (font_fill_lglyph_metrics): Add code parameter, move >> glyph code calculation up the call stack into fill_gstring_body. >> >> * src/font.h: Adjust font_fill_lglyph_metrics prototype. Eli> Thanks. So Mike Fabian has tested this, and it works for him. Which branch would you like me to push this to? Robert