From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: lg.zevlg@gmail.com, 39133@debbugs.gnu.org
Subject: bug#39133: 28.0.50; Emacs slowdown on special char
Date: Mon, 02 Mar 2020 08:40:02 +0100 [thread overview]
Message-ID: <m2d09v19yl.fsf@gmail.com> (raw)
In-Reply-To: <83muacrgwj.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 24 Jan 2020 17:52:12 +0200")
>>>>> On Fri, 24 Jan 2020 17:52:12 +0200, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: 39133@debbugs.gnu.org, lg.zevlg@gmail.com,
>> mituharu@math.s.chiba-u.ac.jp, handa@gnu.org
>> Date: Fri, 24 Jan 2020 16:41:40 +0100
>>
>> >>>>> On Fri, 24 Jan 2020 14:50:10 +0100, Robert Pluim <rpluim@gmail.com> said:
Robert> Yes, I worked that out. A simple crash, for once :-)
>>
>> >From 667f47abecc13e8a47181f338e727d95e57a6354 Mon Sep 17 00:00:00 2001
>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Fri, 24 Jan 2020 14:11:44 +0100
>> Subject: [PATCH] Don't attempt to cache glyph metrics for FONT_INVALID_CODE
>>
>> This was causing massive slowdown in redisplay when eg #xfe0f
>> (VARIATION SELECTOR-16) was present, as the cache ended up very large,
>> unused, and being recreated on every call to font_fill_lglyph_metrics
>> (Bug#39133).
>>
>> * src/composite.c (fill_gstring_body): Hoist FONT_OBJECT_P check out
>> of loop. Calculate glyph code and check for FONT_INVALID_CODE before
>> calling font_fill_lglyph_metrics. Pass glyph code to it.
>>
>> * src/font.c (font_fill_lglyph_metrics): Add code parameter, move
>> glyph code calculation up the call stack into fill_gstring_body.
>>
>> * src/font.h: Adjust font_fill_lglyph_metrics prototype.
Eli> Thanks.
So Mike Fabian has tested this, and it works for him. Which branch
would you like me to push this to?
Robert
next prev parent reply other threads:[~2020-03-02 7:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 13:21 bug#39133: 28.0.50; Emacs slowdown on special char Evgeny Zajcev
2020-01-14 15:26 ` Eli Zaretskii
2020-01-14 16:24 ` Robert Pluim
2020-01-15 4:26 ` YAMAMOTO Mitsuharu
2020-01-15 8:25 ` Robert Pluim
2020-01-15 10:47 ` Evgeny Zajcev
2020-01-15 16:19 ` Eli Zaretskii
2020-01-24 10:13 ` Robert Pluim
2020-01-24 10:22 ` Eli Zaretskii
2020-01-24 13:09 ` Robert Pluim
2020-01-24 13:40 ` Eli Zaretskii
2020-01-24 13:50 ` Robert Pluim
2020-01-24 15:41 ` Robert Pluim
2020-01-24 15:52 ` Eli Zaretskii
2020-03-02 7:40 ` Robert Pluim [this message]
2020-03-02 8:49 ` Eli Zaretskii
2020-03-02 9:25 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2d09v19yl.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=39133@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=lg.zevlg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.