all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Eli Zaretskii <eliz@gnu.org>, Lars Ingebrigtsen <larsi@gnus.org>,
	emacs-devel@gnu.org
Subject: Re: bug#40248: 27.0.90; Failure open .authinfo.gpg from Gnus
Date: Tue, 31 Mar 2020 18:13:10 +0200	[thread overview]
Message-ID: <m2d08s1p0p.fsf@gmail.com> (raw)
In-Reply-To: <m24ku44w85.fsf@gmail.com> (Robert Pluim's message of "Tue, 31 Mar 2020 13:09:14 +0200")

>>>>> On Tue, 31 Mar 2020 13:09:14 +0200, Robert Pluim <rpluim@gmail.com> said:

>>>>> On Tue, 31 Mar 2020 12:31:04 +0200, Andreas Schwab <schwab@linux-m68k.org> said:
    Andreas> On Mär 31 2020, Robert Pluim wrote:
    >>> My reading of set_network_socket_coding_system is that having a plist
    >>> in make-network-process with :coding nil overrides a non-nil
    >>> coding-system-for-{read-write}, which I donʼt think we want.

    Andreas> You are right, make-network-process and make-serial-process handle that
    Andreas> differently than make-process and make-pipe-process.  I think this is a
    Andreas> bug, they should all handle :coding nil the same (same as absence).

    Robert> I think I agree with that. Basically this, initially (and the same for
    Robert> make-serial-process)

Now that Iʼve actually tested it, the change looks like this, making
make-network-process and make-serial process behave the same as
make-process and make-pipe-process. Iʼve looked at all uses of those
two functions in Emacs' sources, and none of them depend on the change
in semantics, in fact only a couple of them actually pass a :coding
keyword.

Having said all that, this does go back a looooong way (2002 at
least), so maybe we want to let sleeping dogs lie.

diff --git a/src/process.c b/src/process.c
index e18a5aa538..2db45b18b2 100644
--- a/src/process.c
+++ b/src/process.c
@@ -3205,14 +3206,12 @@ DEFUN ("make-serial-process", Fmake_serial_process, Smake_serial_process,
 		       BUF_ZV_BYTE (XBUFFER (buffer)));
     }
 
-  tem = Fplist_member (contact, QCcoding);
-  if (!NILP (tem) && (!CONSP (tem) || !CONSP (XCDR (tem))))
-    tem = Qnil;
+  tem = Fplist_get (contact, QCcoding);
 
   val = Qnil;
   if (!NILP (tem))
     {
-      val = XCAR (XCDR (tem));
+      val = tem;
       if (CONSP (val))
 	val = XCAR (val);
     }
@@ -3226,7 +3225,7 @@ DEFUN ("make-serial-process", Fmake_serial_process, Smake_serial_process,
   val = Qnil;
   if (!NILP (tem))
     {
-      val = XCAR (XCDR (tem));
+      val = tem;
       if (CONSP (val))
 	val = XCDR (val);
     }
@@ -3261,16 +3260,14 @@ set_network_socket_coding_system (Lisp_Object proc, Lisp_Object host,
   Lisp_Object coding_systems = Qt;
   Lisp_Object val;
 
-  tem = Fplist_member (contact, QCcoding);
-  if (!NILP (tem) && (!CONSP (tem) || !CONSP (XCDR (tem))))
-    tem = Qnil;  /* No error message (too late!).  */
+  tem = Fplist_get (contact, QCcoding);
 
   /* Setup coding systems for communicating with the network stream.  */
   /* Qt denotes we have not yet called Ffind_operation_coding_system.  */
 
   if (!NILP (tem))
     {
-      val = XCAR (XCDR (tem));
+      val = tem;
       if (CONSP (val))
 	val = XCAR (val);
     }
@@ -3304,7 +3301,7 @@ set_network_socket_coding_system (Lisp_Object proc, Lisp_Object host,
 
   if (!NILP (tem))
     {
-      val = XCAR (XCDR (tem));
+      val = tem;
       if (CONSP (val))
 	val = XCDR (val);
     }



  reply	other threads:[~2020-03-31 16:13 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26 23:07 bug#40248: 27.0.90; Failure open .authinfo.gpg from Gnus Juan José García Ripoll
2020-03-27  8:18 ` Eli Zaretskii
2020-03-27 13:34   ` Eli Zaretskii
2020-03-27 16:21     ` Juan José García-Ripoll
2020-03-28  7:55       ` Eli Zaretskii
2020-03-28  8:40         ` Lars Ingebrigtsen
2020-03-28  9:17           ` Eli Zaretskii
2020-03-29  7:45             ` Lars Ingebrigtsen
2020-03-29 13:49               ` Eli Zaretskii
2020-03-31  9:20                 ` Robert Pluim
2020-03-31  9:53                   ` Andreas Schwab
2020-03-31 10:16                     ` Robert Pluim
2020-03-31 10:31                       ` Andreas Schwab
2020-03-31 11:09                         ` Robert Pluim
2020-03-31 16:13                           ` Robert Pluim [this message]
2020-03-31 17:59                             ` Eli Zaretskii
2020-03-31 19:53                               ` Robert Pluim
2020-04-02 11:10                             ` Lars Ingebrigtsen
2020-04-02 12:48                               ` Robert Pluim
2020-04-03 11:52                                 ` Lars Ingebrigtsen
2020-04-03 12:50                                   ` Robert Pluim
2020-03-28 14:03         ` Juan Jose Garcia Ripoll
2020-03-28 14:36           ` Eli Zaretskii
2020-03-29  7:48         ` Lars Ingebrigtsen
2020-03-29 13:52           ` Eli Zaretskii
2020-03-30  9:37             ` Robert Pluim
2020-03-30 13:10               ` Eli Zaretskii
2020-03-30 14:10                 ` Robert Pluim
2020-03-30 14:33                   ` Eli Zaretskii
2020-04-02 11:11                     ` Lars Ingebrigtsen
2020-04-03 11:31                       ` Eli Zaretskii
2020-04-03 11:43                         ` Robert Pluim
2020-07-19  2:45                           ` Lars Ingebrigtsen
2020-07-19 14:23                             ` Eli Zaretskii
2020-07-19 14:29                               ` Lars Ingebrigtsen
2020-07-19 14:43                                 ` Eli Zaretskii
2020-07-19 14:45                                   ` Lars Ingebrigtsen
2020-07-23  0:20                                   ` Juri Linkov
2020-07-23 13:36                                     ` Dmitry Gutov
2020-07-20  8:42                               ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2d08s1p0p.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.