From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alex Bochannek Newsgroups: gmane.emacs.bugs Subject: bug#43441: 27.1; [PATCH] Fix incorrectly base64-padded faces in gnus-convert-face-to-png Date: Mon, 28 Sep 2020 08:58:36 -0700 Message-ID: References: <875z8cpghq.fsf@gnus.org> <878scuw186.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1982"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) Cc: 43441@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 28 17:59:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kMvYZ-0000HN-Cy for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Sep 2020 17:59:15 +0200 Original-Received: from localhost ([::1]:57650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMvYY-0007Pb-FP for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Sep 2020 11:59:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMvYM-0007PF-Oz for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2020 11:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42269) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kMvYM-0002qk-19 for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2020 11:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kMvYL-0001HM-Ux for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2020 11:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Bochannek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Sep 2020 15:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43441 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 43441-submit@debbugs.gnu.org id=B43441.16013087294895 (code B ref 43441); Mon, 28 Sep 2020 15:59:01 +0000 Original-Received: (at 43441) by debbugs.gnu.org; 28 Sep 2020 15:58:49 +0000 Original-Received: from localhost ([127.0.0.1]:53815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMvY8-0001Gt-PE for submit@debbugs.gnu.org; Mon, 28 Sep 2020 11:58:49 -0400 Original-Received: from 50-0-39-243.dsl.static.fusionbroadband.com ([50.0.39.243]:23341 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMvY4-0001Gb-PV for 43441@debbugs.gnu.org; Mon, 28 Sep 2020 11:58:47 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.lapseofthought.com (Postfix) with ESMTP id 4C0RyQ4R2Wz3jlJc; Mon, 28 Sep 2020 08:58:38 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at lapseofthought.com Original-Received: from mail.lapseofthought.com ([127.0.0.1]) by localhost (mail.lapseofthought.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o86hf4ECU6zW; Mon, 28 Sep 2020 08:58:37 -0700 (PDT) Original-Received: from awb-mbp.local (unknown [IPv6:2601:646:4200:b470:5cac:749b:fb04:efd2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4C0RyP1h2Qz3jjJv; Mon, 28 Sep 2020 08:58:37 -0700 (PDT) In-Reply-To: <878scuw186.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 28 Sep 2020 14:10:49 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189212 Archived-At: Lars Ingebrigtsen writes: > Alex Bochannek writes: > >> Took me a little while, but I broke this out into a utility function as >> you suggested. I also wrote some tests for it. As part of me getting >> familiar with ERT, I added a bunch of tests for gnus-string< and >> gnus-string>, which I hope are useful. They should probably be in a >> separate commit, but I leave that up to you. > > Thanks; looks good to me. I did some minor touch-ups before committing > -- the first line in the comment string should be a complete sentence, > and ";;" instead of ";;;", and when is preferred over else-less ifs and > pushed to Emacs 28. Great, thanks! -- Alex.