From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Kevin Foley Newsgroups: gmane.emacs.bugs Subject: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer Date: Sun, 25 Oct 2020 16:08:07 -0400 Message-ID: References: <87lffu9zye.fsf@gnus.org> <87a6wa8d1w.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22545"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44202@debbugs.gnu.org To: Stefan Kangas , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 25 21:09:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kWmKF-0005de-B6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Oct 2020 21:09:11 +0100 Original-Received: from localhost ([::1]:54114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWmKD-0005Bf-Rg for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Oct 2020 16:09:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWmK6-0005BU-SX for bug-gnu-emacs@gnu.org; Sun, 25 Oct 2020 16:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54420) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kWmK6-0001sQ-HM for bug-gnu-emacs@gnu.org; Sun, 25 Oct 2020 16:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kWmK6-0005Ya-D6 for bug-gnu-emacs@gnu.org; Sun, 25 Oct 2020 16:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kevin Foley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Oct 2020 20:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44202 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44202-submit@debbugs.gnu.org id=B44202.160365650321311 (code B ref 44202); Sun, 25 Oct 2020 20:09:02 +0000 Original-Received: (at 44202) by debbugs.gnu.org; 25 Oct 2020 20:08:23 +0000 Original-Received: from localhost ([127.0.0.1]:37733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWmJT-0005Xe-4r for submit@debbugs.gnu.org; Sun, 25 Oct 2020 16:08:23 -0400 Original-Received: from mout-p-201.mailbox.org ([80.241.56.171]:50376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWmJR-0005XQ-NS for 44202@debbugs.gnu.org; Sun, 25 Oct 2020 16:08:22 -0400 Original-Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4CK8Cz3k1PzQjVL; Sun, 25 Oct 2020 21:08:15 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Original-Received: from smtp1.mailbox.org ([80.241.60.240]) by gerste.heinlein-support.de (gerste.heinlein-support.de [91.198.250.173]) (amavisd-new, port 10030) with ESMTP id A2AIqNMKHYja; Sun, 25 Oct 2020 21:08:11 +0100 (CET) In-Reply-To: X-Rspamd-Score: -4.61 / 15.00 / 15.00 X-Rspamd-Queue-Id: 31C3717E0 X-Rspamd-UID: 118708 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191535 Archived-At: Stefan Kangas writes: > Lars Ingebrigtsen writes: > >> But... I think it would be helpful if help-mode-revert-buffer (and >> other similar functions) did heed that variable -- then there'd be one >> simple way to control all this. > > Agreed. It would seem logical to just be able to say: > > (add-to-list 'revert-without-query "\\`\\*Help\\*\\'") I also agree with this. I think this was how I originally tried to solve this problem (it was a while ago) but it didn't seem supported. >> Or even perhaps have revert-buffer look at that variable and do the >> right thing instead of punting to revert-buffer--default. >> >> That is, it would look at file names for buffers visiting files, and >> buffer names for other buffers. > > If we could get `revert-buffer' to handle this, it seems to me that it > would be even better. I could update `revert-buffer' to include the logic for IGNORE-AUTO and NOCONFIRM that are used in `revert-buffer--default' with some additional logic to handle buffers without associated files. Should I leave this logic in `revert-buffer--default' as well or have it only exist in `revert-buffer'? I believe that would also require changing `help-mode' to use `revert-buffer-function' and `revert-buffer' instead of binding `help-mode-revert-buffer', right? Kevin Foley