From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matt Armstrong Newsgroups: gmane.emacs.bugs Subject: bug#46836: 28.0.50; Clean up obsolete comment for unchain_marker Date: Sun, 28 Feb 2021 14:54:27 -0800 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20988"; mail-complaints-to="usenet@ciao.gmane.io" To: 46836@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 28 23:55:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGUy0-0005MZ-Rh for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Feb 2021 23:55:12 +0100 Original-Received: from localhost ([::1]:38136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGUxz-0005xK-Dl for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Feb 2021 17:55:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGUxq-0005wt-Qu for bug-gnu-emacs@gnu.org; Sun, 28 Feb 2021 17:55:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35945) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGUxq-0003Jw-Jq for bug-gnu-emacs@gnu.org; Sun, 28 Feb 2021 17:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lGUxq-0004uO-J0 for bug-gnu-emacs@gnu.org; Sun, 28 Feb 2021 17:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Matt Armstrong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Feb 2021 22:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 46836 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.161455288218774 (code B ref -1); Sun, 28 Feb 2021 22:55:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Feb 2021 22:54:42 +0000 Original-Received: from localhost ([127.0.0.1]:47491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGUxV-0004si-Pa for submit@debbugs.gnu.org; Sun, 28 Feb 2021 17:54:42 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:39740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGUxT-0004sa-S7 for submit@debbugs.gnu.org; Sun, 28 Feb 2021 17:54:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGUxT-0005uZ-K4 for bug-gnu-emacs@gnu.org; Sun, 28 Feb 2021 17:54:39 -0500 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:56001) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGUxR-00037I-Is for bug-gnu-emacs@gnu.org; Sun, 28 Feb 2021 17:54:39 -0500 Original-Received: from matts-mbp-2016.lan (24-113-169-116.wavecable.com [24.113.169.116]) (Authenticated sender: matt@rfc20.org) by relay11.mail.gandi.net (Postfix) with ESMTPSA id BD6AA100002 for ; Sun, 28 Feb 2021 22:54:31 +0000 (UTC) Received-SPF: pass client-ip=217.70.178.231; envelope-from=matt@rfc20.org; helo=relay11.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201034 Archived-At: --=-=-= Content-Type: text/plain I wondered why there was a scare comment for unchain_marker, when the code itself did not look like it was especially different from the other nearby functions. It turns out that the call into this function from GC was removed a few years ago. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-Clean-up-obsolete-comment.patch Content-Transfer-Encoding: quoted-printable >From c03f9fc86ee79a995acae012cac07609ebaa3d5e Mon Sep 17 00:00:00 2001 From: Matt Armstrong Date: Sun, 28 Feb 2021 14:41:33 -0800 Subject: [PATCH] Clean up obsolete comment MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Commit cf3164523b (* src/alloc.c: Avoid O(N=C2=B2) complexity when unchaining markers (bug#24548)., 2018-03-23) removed the call from GC into unchain_marker, so there is no need to warn about it. * src/marker.c (unchain_marker): Clean up obsolete comment. --- src/marker.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/marker.c b/src/marker.c index 5979151317..2b137b14c8 100644 --- a/src/marker.c +++ b/src/marker.c @@ -634,16 +634,15 @@ set_marker_restricted_both (Lisp_Object marker, Lisp_= Object buffer, /* Detach a marker so that it no longer points anywhere and no longer slows down editing. Do not free the marker, though, as a change function could have inserted it into an undo list (Bug#30931). */ + void detach_marker (Lisp_Object marker) { Fset_marker (marker, Qnil, Qnil); } =20 -/* Remove MARKER from the chain of whatever buffer it is in, - leaving it points to nowhere. This is called during garbage - collection, so we must be careful to ignore and preserve - mark bits, including those in chain fields of markers. */ +/* Remove MARKER from the chain of whatever buffer it is in. Set its + buffer NULL. */ =20 void unchain_marker (register struct Lisp_Marker *marker) --=20 2.30.0 --=-=-= Content-Type: text/plain In GNU Emacs 28.0.50 (build 1, x86_64-apple-darwin20.3.0, NS appkit-2022.30 Version 11.2.1 (Build 20D74)) of 2021-02-27 built on matts-mbp-2016.lan Repository revision: de33de1a660283f45a10acfaedef20c460553dbd Repository branch: master Windowing system distributor 'Apple', version 10.3.2022 System Description: macOS 11.2.2 --=-=-=--